ros / common_tutorials Goto Github PK

ROS common_tutorials stack migrated from https://code.ros.org/svn/ros-pkg/stacks/common_tutorials/branches/common_tutorials-0.1/

Python 10.77% C++ 71.98% CMake 17.25%

common_tutorials's Introduction

Robot Operating System (ROS)
===============================================================================

ROS is a meta-operating system for your robot.  It provides
language-independent and network-transparent communication for a
distributed robot control system.

Installation Notes
------------------

For full installation instructions, including system prerequisites and
platform-specific help, see:

  http://wiki.ros.org/ROS/Installation

common_tutorials's People

Contributors

Stargazers

Watchers

Forkers

130s mmabby dr-lingyunxu aranyadan wambamthankyoumam vrabaud scpeters k-okada rkoyama1623-2021 wangxihuiok bigjun ncnynl adangge rencheng123456 snrkiwi chenrui2014 ganindu7 lukefrasera ros-1 bilal9876 2amour yashbutala sergeant-wizard gerrygekao lxlhappylife niddipi achalarvind jyhjana hang-cui alss1923 dgr1992 coswang1120 atifkarim fujitatomoya sloretz 222foxqazw davidhan008 mikaelarguedas svirac yangshuo11 tobias-fischer xfbd ameur580 zabula kasumi-ksm 7sant johari-kritika cokthemhok mantues mathila-amarasena yinhongzhi subaruarai lucasw ros-o rodrigofbernardo jondave qianniuxinyu leawoliu007 jspricke

common_tutorials's Issues

Python Actionlib Tutorials

Any plan to port the intermediate and advanced tutorials to python?

http://wiki.ros.org/actionlib_tutorials

lacks include directories when build in isolation without install

nodelet_tutorial_math/CMakeLists.txt lacks include directories:

include_directories(${catkin_INCLUDE_DIRS})

Mismatch between actionlib_tutorials wiki and this repository

I just noticed there's some mismatch between the wiki and this repository. I'm willing to help clean it up if I get some feedback on how it should be fixed.

The actionlib_tutorials page says to create a catkin package called learning_actionlib, while this repository has a package called actionlib_tutorials.
The first two beginner tutorials (Fibonacci c++ server
and Fibonacci c++ client) use the learning_actionlib package name.
The two python beginner tutorials use the actionlib_tutorials package name. Also, those python scripts are not contained in this git repository.

Should the tutorial recommend to the user how to recreate the contents of the actionlib_tutorials package in this repository?

nodelet_tutorial_math fails to build on OS X

See:

http://answers.ros.org/question/56553/rosmake-fails-on-os-x/
http://pastie.org/pastes/6368348/text

The failure is:

{-------------------------------------------------------------------------------
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /Users/alex/ros_ws/common_tutorials/nodelet_tutorial_math/build
  cd build && make -j -l8
  Scanning dependencies of target rospack_genmsg_libexe
  [  0%] Built target rospack_genmsg_libexe
  Scanning dependencies of target rosbuild_precompile
  [  0%] Built target rosbuild_precompile
  Scanning dependencies of target nodelet_math
  [100%] Building CXX object CMakeFiles/nodelet_math.dir/src/plus.cpp.o
  Linking CXX shared library ../lib/libnodelet_math.dylib
  clang: warning: argument unused during compilation: '-pthread'
  Undefined symbols for architecture x86_64:
    "class_loader::class_loader_private::AbstractMetaObjectBase::addOwningClassLoader(class_loader::ClassLoader*)", referenced from:
        void class_loader::class_loader_private::registerPlugin<nodelet_tutorial_math::Plus, nodelet::Nodelet>(std::string const&, std::string const&) in plus.cpp.o
    "class_loader::class_loader_private::AbstractMetaObjectBase::setAssociatedLibraryPath(std::string)", referenced from:
        void class_loader::class_loader_private::registerPlugin<nodelet_tutorial_math::Plus, nodelet::Nodelet>(std::string const&, std::string const&) in plus.cpp.o
    "class_loader::class_loader_private::AbstractMetaObjectBase::AbstractMetaObjectBase(std::string const&, std::string const&)", referenced from:
        class_loader::class_loader_private::AbstractMetaObject<nodelet::Nodelet>::AbstractMetaObject(std::string const&, std::string const&) in plus.cpp.o
    "class_loader::class_loader_private::AbstractMetaObjectBase::~AbstractMetaObjectBase()", referenced from:
        class_loader::class_loader_private::AbstractMetaObject<nodelet::Nodelet>::AbstractMetaObject(std::string const&, std::string const&) in plus.cpp.o
    "class_loader::class_loader_private::getFactoryMapForBaseClass(std::string const&)", referenced from:
        std::map<std::string, class_loader::class_loader_private::AbstractMetaObjectBase*, std::less<std::string>, std::allocator<std::pair<std::string const, class_loader::class_loader_private::AbstractMetaObjectBase*> > >& class_loader::class_loader_private::getFactoryMapForBaseClass<nodelet::Nodelet>() in plus.cpp.o
    "class_loader::class_loader_private::getCurrentlyActiveClassLoader()", referenced from:
        void class_loader::class_loader_private::registerPlugin<nodelet_tutorial_math::Plus, nodelet::Nodelet>(std::string const&, std::string const&) in plus.cpp.o
    "class_loader::class_loader_private::getCurrentlyLoadingLibraryName()", referenced from:
        void class_loader::class_loader_private::registerPlugin<nodelet_tutorial_math::Plus, nodelet::Nodelet>(std::string const&, std::string const&) in plus.cpp.o
    "class_loader::class_loader_private::getPluginBaseToFactoryMapMapMutex()", referenced from:
        void class_loader::class_loader_private::registerPlugin<nodelet_tutorial_math::Plus, nodelet::Nodelet>(std::string const&, std::string const&) in plus.cpp.o
    "class_loader::class_loader_private::hasANonPurePluginLibraryBeenOpened(bool)", referenced from:
        void class_loader::class_loader_private::registerPlugin<nodelet_tutorial_math::Plus, nodelet::Nodelet>(std::string const&, std::string const&) in plus.cpp.o
    "console_bridge::log(char const*, int, console_bridge::LogLevel, char const*, ...)", referenced from:
        void class_loader::class_loader_private::registerPlugin<nodelet_tutorial_math::Plus, nodelet::Nodelet>(std::string const&, std::string const&) in plus.cpp.o
        __GLOBAL__I_a in plus.cpp.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  make[3]: *** [../lib/libnodelet_math.dylib] Error 1
  make[2]: *** [CMakeFiles/nodelet_math.dir/all] Error 2
  make[1]: *** [all] Error 2
-------------------------------------------------------------------------------}
[ rosmake ] Output from build of package nodelet_tutorial_math written to:
[ rosmake ]    /Users/alex/.ros/rosmake/rosmake_output-20130302-173409/nodelet_tutorial_math/build_output.log
[rosmake-5] Finished <<< nodelet_tutorial_math [FAIL] [ 41.04 seconds ]

This looks like a failure to link against class_loader.

Ubuntu package ros-indigo-turtle-actionlib is based on a non-working shape_server.cpp source

The ros-indigo-turtle-actionlib ubuntu package is built with the shape_server.cpp source of the master branch. That source however results in a non-working tutorial. Using a proper source from another branch will fix this. Here is the diff of my own patch:

--- shape_server.cpp.master 2014-04-16 02:13:10.000000000 +0200
+++ shape_server.cpp    2014-10-12 22:03:45.462655224 +0200
@@ -5,7 +5,7 @@
 #include <math.h>
 #include <angles/angles.h>

-#include <turtle_actionlib/Velocity.h>
+#include <geometry_msgs/Twist.h>
 #include <turtle_actionlib/ShapeAction.h>

 // This class computes the command_velocities of the turtle to draw regular polygons 
@@ -22,7 +22,7 @@

     //subscribe to the data topic of interest
     sub_ = nh_.subscribe("/turtle1/pose", 1, &ShapeAction::controlCB, this);
-    pub_ = nh_.advertise<turtle_actionlib::Velocity>("/turtle1/command_velocity", 1);
+    pub_ = nh_.advertise<geometry_msgs::Twist>("/turtle1/cmd_vel", 1);

     as_.start();
   }
@@ -85,25 +85,25 @@

       if (dis_error_ > error_tol)
       {
-        command_.linear = l_scale*dis_error_;
-        command_.angular = 0;
+        command_.linear.x = l_scale*dis_error_;
+        command_.angular.z = 0;
       }
       else if (dis_error_ < error_tol && fabs(theta_error_)> error_tol)
       { 
-        command_.linear = 0;
-        command_.angular = a_scale*theta_error_;
+        command_.linear.x = 0;
+        command_.angular.z = a_scale*theta_error_;
       }
       else if (dis_error_ < error_tol && fabs(theta_error_)< error_tol)
       {
-        command_.linear = 0;
-        command_.angular = 0;
+        command_.linear.x = 0;
+        command_.angular.z = 0;
         start_edge_ = true;
         edge_progress_++;
       }  
       else
       {
-        command_.linear = l_scale*dis_error_;
-        command_.angular = a_scale*theta_error_;
+        command_.linear.x = l_scale*dis_error_;
+        command_.angular.z = a_scale*theta_error_;
       } 
       // publish the velocity command
       pub_.publish(command_);
@@ -126,7 +126,7 @@
   double dis_error_, theta_error_;
   int edges_ , edge_progress_;
   bool start_edge_;
-  turtle_actionlib::Velocity command_;
+  geometry_msgs::Twist command_;
   turtle_actionlib::ShapeResult result_;
   ros::Subscriber sub_;
   ros::Publisher pub_;

Add CI for pull requests

Probably when the next release is made, add PR testing.

Fibonacci.action docs aren't generated

As seen on ROS answers: http://answers.ros.org/question/207632/broken-url-in-tutorial/

The docs for Fibonacci.action do not appear to be generated properly.

Fibonacci Example for SimpleActionServer not working..

Running Win10 + WSL with Ubuntu 16.04 and ROS Lunar

Running unmodified code from 'actionlib_tutorials' to test SImpleActionServer; I start the server with
$ rosrun actionlib_tutorials fibonacci_server.py

In a seperate window, I can see the topics from
$rostopic lsit

Then I start an echo before calling the client:

$ rostopic echo /fibonacci/feedback

Finally, in a separate window I start the client:

$ rosrun actionlib_tutorials fibonacci_client.py

and nothing happens....

After a minute or so, I start to receive warnings in the client AND echo windows:

[WARN] [1534645446.029767]: Inbound TCP/IP connection failed: timed out

Any thoughts as to why the SinmpleActionServer is not working?

Catkinize turtle_actionlib

turtle_actionlib is not verified to work with Groovy nor catkin.

Release request 0.1.9+

It's been more than 2 years since the last release and there are new commits.

Thank you in advance.

catkinize nodelet_tutorials_math

nodelet_tutorials_math is not verified to work with Groovy nor catkin.

Can't compile in macOS Sierra 10.12.1

Hello.

I'm trying to install ROS Jade on macOS 10.12.1, using clang++ and libc++, but I keep getting the following error when trying to compile common_tutorials, specifically nodelet_math_tutorial. The compiler basically tells me that There is no definition of several variables in the global namespace. You can see the output here. I have tried several approaches, such as changing from libc++ to libstdc++, but then its deprecated and some other packages fail. I have no idea what to do!

Thanks

Release common_tutorials to Noetic?

Would you mind releasing common_tutorials to ROS Noetic? It looks like all of its dependencies have been released, and recursively 10 repos need it.

I'm not sure how much work it will need. At a minimum it needs #24.