Code Monkey home page Code Monkey logo

android's People

Contributors

70h avatar airon90 avatar altonss avatar ankittiwari101 avatar bors[bot] avatar brarcher avatar clxf12 avatar comradekingu avatar dependabot[bot] avatar gdonisi avatar illusiveman196 avatar joeax910 avatar kethen avatar laralem avatar mdvhimself avatar meskobalazs avatar nyatsuki avatar obfusk avatar oersen avatar pfaffenrodt avatar pxn avatar sergiowalls avatar slavekb avatar solokot avatar stoyandimitrov avatar tacothedank avatar theimpulson avatar thelastproject avatar vistaus avatar weblate avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

android's Issues

Improve UX, UI

Issue by ghost
Thursday Jun 29, 2017 at 20:13 GMT
Originally opened as brarcher/loyalty-card-locker#123


So, this is a feature request (might possibly work on this myself). My mother has a ton of loyalty cards, so she wants to use an app like this. However the only ones user friendly enough to use are proprietary (her preferred is Stocard). I've introduced her to free software and she wants to stop using proprietary software as much as possible. The problem with this app is that, as opposed to stocard, there are no logos, no searchable stores to easy add cards, you have to choose what form of barcode is the right one, the colours are bland, the list is one big scrolling hell if you have a ton of cards (no searching)

So, to recap, it would be nice to see the following:

  • colours
  • searching
  • directory for know stores, search for one to add it easily (if legally possible with image preloaded in app for known stores, if not make it possible to import these images easily so that they can be loaded from third party not affiliated with this project)
  • two panes, one for most used stores (with a tile ui showing the logos with their names on the bottom of the tile), one for an alphabetical list. Maybe a manual pinning of stores too?

Anyways, this is a great app that fills a void on F-Droid, so I'm happy it exists. I hope we'll be able to bring it up to par with the proprietary ones

Prevent stuck partial wake lock

Issue by brarcher
Saturday Jun 10, 2017 at 02:35 GMT
Originally opened as brarcher/loyalty-card-locker#100


Google playstore analytics indicates that usually when a partial wakelock is held it is done for less than a minute. However, a few times a user did something to cause the partial wake lock to be held for 4-8 hours. The reason for this needs to be determined.

Is the partial wake lock the lock used when displaying a barcode and brightening the screen? Is that causing the phone to not sleep?

Create better layout for entering/displaying card info

Issue by brarcher
Tuesday Jan 31, 2017 at 01:22 GMT
Originally opened as brarcher/loyalty-card-locker#88


The layout when adding a card, namely:

and when displaying a card for scanning or reading at a store, namely:

could be improved. They are functional, but could be improved to be more visually appealing and perhaps easier to use. In addition, if the application is to let a user add a thumbnail of the store, namely brarcher/loyalty-card-locker#86, there currently is no place to put the thumbnail.

There are a number of other applications available on Google Play. Although this application should not be a clone of them, perhaps they could be used as inspiration.

Bulk-select and delete cards

Issue by github-kp
Sunday Sep 10, 2017 at 13:26 GMT
Originally opened as brarcher/loyalty-card-locker#140


Suggestion:
Add menu entry "Delete all cards" to the main menu.

Why is this useful?

Scenario A:
Deleting all cards one after the other is cumbersome.

Scenario B: "Clean import"

  • User wants the same cards on 2 devices.
  • User adds or modifies cards on device 1.
  • User exports the cards of device 1 to a file.
  • User deletes all cards on device 2.
  • User imports the file on device 2.

This feature would also solve the following issue I observed:

  • The same cards exists on 2 devices.
  • User modifies a card name on device 1.
  • User exports the cards of device 1 to a file.
  • User imports the file on device 2.
  • Card name on device 2 does not get updated.

Added ability to import a barcode from a local image

Issue by franga2000
Monday Oct 14, 2019 at 18:43 GMT
Originally opened as brarcher/loyalty-card-locker#317


Adds an "Import from image" button next to "Capture card" that does exactly what was described in #248 - allows the user to pick an image from their device that contains the barcode they want to add.

Signed-off-by: Miha FrangeΕΎ<[email protected]>


This change is Reviewable


franga2000 included the following code: https://github.com/brarcher/loyalty-card-locker/pull/317/commits

Simultaneous usage on two or more devices: thoughts

Issue by shapirus
Monday Mar 05, 2018 at 08:37 GMT
Originally opened as brarcher/loyalty-card-locker#220


Let's assume I want to keep a cards database shared with my family (say 2 devices for now). Right now, there is one standard possibility:

  1. Edit cards on device 1
  2. Export on device 1
  3. Sync with your favorite file sync software
  4. Import on device 2

And then in the reverse order when the database is changed on device 2.

This requires manual actions and in addition the export path is not configurable yet (as described in brarcher/loyalty-card-locker#168) which doesn't allow to use synchronization software which works with folders (you don't want to share the sdcard's entire root where the export .csv file is saved). The latter can be worked around using the "send to" button, though.

A better option would be to sync the actual database. But there are a few issues preventing this:

  1. The database path cannot be configured. Current path is /data/data/protect.card_locker which means that whatever software is trying to access that location to sync it to other devices, must run with root privileges. Making this path configurable or creating a copy of the database (updated on every change) in a user-accessible location would solve this.

  2. The application must implement the reload-on-database-change function in order to load the changes made on the other device and synced back. Or, if we sync the database's copy in /sdcard, load that one when it's changed.

  3. Conflict resolution (when two devices edit the databases while no data sync is happening between them). It is the most difficult part implementing which is probably not worth the trouble. Or maybe not? We can probably simply merge cards that are in /data with the updated version from /sdcard thus keeping added cards from both devices. Deletions and edits have to be additionally handled, though. "Newest change wins" principle? That will need a new "datetime changed" field for each record in the database if it's not there yet.

Then again, cloud sync for those who don't care to set up their own file sync solution? That might be planned for the future. That cloud subscription might (and probably should) be a paid one, earning something in addition to the donations :)

Allow custom export folder

Issue by beng7
Sunday Dec 24, 2017 at 17:57 GMT
Originally opened as brarcher/loyalty-card-locker#168


Hi
Please allow user to be able to set custom Export folder as opposed to default /storage /emulated/0
--> e.g. to export to the nexcloud directory so cards are automatically backed up in nextcloud
Thanks a lot

[Feature Request] Wear OS support

Issue by Sanaki
Wednesday May 16, 2018 at 02:50 GMT
Originally opened as brarcher/loyalty-card-locker#247


Right now Wear Codes (iap for more than one code), Pass2U, and Stocard seem to support Wear OS for loyalty cards. I don't particularly trust either free option and I'd rather not have to use them if possible when I'm already more than happy with this app. While I realize this may be somewhat unlikely, any form of Wear OS support would be very welcome.

Multiple Barcodes

Issue by AndiLeni
Wednesday Aug 22, 2018 at 17:59 GMT
Originally opened as brarcher/loyalty-card-locker#264


Hello,

I would like to suggest the following feature:
Several barcodes of different types on one card.
For example, IKEA has two types of barcode on the card, depending on where they are used in the store.

Regards
Andi

Save related coupons

Issue by Lucki
Thursday Oct 18, 2018 at 13:23 GMT
Originally opened as brarcher/loyalty-card-locker#279


Some stores serve coupons as barcodes. Would be nice to be able to store them along the cards.

I'm often using Revolution IRC which channel handling could be useful here to seperate the main barcode view. You could swipe across all different cards with customizable names (#264) until you're at the coupons section. That's a simple scrollable list with customizable notes above.

Of course they often have an expiration date so this is a bit related to #229. I've thought of adding a red color to the barcode which then can deleted by a long press. Maybe a striked out text or something similar would work too.

My barcode scans and shows number, but displays the wrong format

Issue by myuseraccount
Thursday May 30, 2019 at 18:11 GMT
Originally opened as brarcher/loyalty-card-locker#302


I have a library card that the camera scans successfully and captures the number, but the displayed barcode doesn't match the card. In fact, when I go to edit the entry, none of the displayed barcode options are correct. It seems that the scanning library supports other barcode formats than the ones in the list, but it just randomly guesses one when it doesn't actually support that one for display within the app. Took me awhile to figure out why it wouldn't scan off the screen.

How do I find out what format the barcode is, so I can request support for this type?
IMG_20190530_103413

New feature: set an expiry date for a card

Issue by ghost
Sunday Mar 18, 2018 at 17:04 GMT
Originally opened as brarcher/loyalty-card-locker#229


Suggestion:
Add a entry "card valid until" to the card editor. The date can be picked with the date picker.

Why is this useful?

Scenario:
There are various membership cards (e.g. library cards) that expire after a certain period of time. The function gives the user an overview when he has to extend his cards

Added option to keep the screen on

Issue by franga2000
Monday Oct 14, 2019 at 18:41 GMT
Originally opened as brarcher/loyalty-card-locker#316


Implements a setting that keeps the screen on and the app above the keyguard when displaying a barcode (as discussed in #287).

(I noticed my previous PR was on an old version so this is the same but rebased to master)

Signed-off-by: Miha FrangeΕΎ<[email protected]>


franga2000 included the following code: https://github.com/brarcher/loyalty-card-locker/pull/316/commits

New feature: Copy the card ID

Issue by denilsonsa
Friday Feb 10, 2017 at 20:28 GMT
Originally opened as brarcher/loyalty-card-locker#90


  1. I select the saved card from the initial screen.
  2. Now I can see all the details. But I can't copy.
    • I wish I could tap on the card ID and it would copy it.
    • To improve the user feedback, upon copying it should display a message (toaster) saying the id was copied.
    • To increase the discoverability of this feature, a copy icon can be added next to the card id.

This feature is specially useful for airline mileage numbers, or any number that can be used during online purchases.

It might be worth also implementing this "copy" feature to the "Note" field.

Store photographs of the card

Issue by matthijskooijman
Monday Sep 25, 2017 at 09:37 GMT
Originally opened as brarcher/loyalty-card-locker#144


It would make sense to, in addition to storing the card number / bar code, store photographs of the card itself. In some cases, this helps convincing store clerks that you're actually showing a customer card. It also makes displaying a card prettier (IMHO), since there's a nice image instead of just the barcode.

Additionally, the card overview could show the card front or back instead of just the card name (this is what mobile pocket also does. They offer pre-fab pictures for a lot of cards, but you can also take your own photographs).

This ties in with #86 (adding a logo to a card to use in the overview) and with #136 (setting a custom color for each card in the overview).

Add support for QR Model 2

Issue by numericOverflow
Friday Jun 15, 2018 at 23:45 GMT
Originally opened as brarcher/loyalty-card-locker#253


I have a couple cards that use model 2 QR codes, but it looks like the app only generates model 1 codes. They typically work, but some scanners a flakey and really seem to want that model 2 image.

Supposedly model 2 has better support for curved surfaces and distorted images, along with more data capacity (but we likely don't care about huge data payload).

http://www.qrcode.com/en/codes/model12.html

App crashes when loading About dialog on Android 5 devices

Issue by brarcher
Monday Jan 06, 2020 at 07:24 GMT
Originally opened as brarcher/loyalty-card-locker#340


Due to a bug in androidx.appcompat:appcompat versions 1.1.0 through 1.2.0-alpha01, loading the About dialog on Android 5 devices results in a crash:

FATAL EXCEPTION: ControllerMessenger
Process: protect.card_locker, PID: 14560
android.content.res.Resources$NotFoundException: String resource ID #0x3040002
	at android.content.res.HwResources.getText(HwResources.java:1252)
	at android.content.res.Resources.getString(Resources.java:374)
	at com.android.org.chromium.content.browser.ContentViewCore.setContainerView(ContentViewCore.java:948)
	at com.android.org.chromium.content.browser.ContentViewCore.initialize(ContentViewCore.java:848)
	at com.android.org.chromium.android_webview.AwContents.createAndInitializeContentViewCore(AwContents.java:649)
	at com.android.org.chromium.android_webview.AwContents.setNewAwContents(AwContents.java:788)
	at com.android.org.chromium.android_webview.AwContents.<init>(AwContents.java:635)
	at com.android.org.chromium.android_webview.AwContents.<init>(AwContents.java:573)
	at com.android.webview.chromium.WebViewChromium.initForReal(WebViewChromium.java:315)
	at com.android.webview.chromium.WebViewChromium.access$100(WebViewChromium.java:100)
	at com.android.webview.chromium.WebViewChromium$1.run(WebViewChromium.java:267)
	at com.android.webview.chromium.WebViewChromium$WebViewChromiumRunQueue.drainQueue(WebViewChromium.java:127)
	at com.android.webview.chromium.WebViewChromium$WebViewChromiumRunQueue$1.run(WebViewChromium.java:114)
	at com.android.org.chromium.base.ThreadUtils.runOnUiThread(ThreadUtils.java:144)
	at com.android.webview.chromium.WebViewChromium$WebViewChromiumRunQueue.addTask(WebViewChromium.java:111)
	at com.android.webview.chromium.WebViewChromium.init(WebViewChromium.java:264)
	at android.webkit.WebView.<init>(WebView.java:548)
	at android.webkit.WebView.<init>(WebView.java:483)
	at android.webkit.WebView.<init>(WebView.java:466)
	at android.webkit.WebView.<init>(WebView.java:453)
	at android.webkit.WebView.<init>(WebView.java:443)
	at protect.card_locker.MainActivity.displayAboutDialog(MainActivity.java:343)
	at protect.card_locker.MainActivity.onOptionsItemSelected(MainActivity.java:291)

The root cause of the bug is this change: https://android.googlesource.com/platform/frameworks/support/+/26079d87c79a64829f036236353fac1dae4e0613%5E%21/#F2

sAlwaysOverrideConfiguration forces updating the Resources configuration and thereby messes up the webview inflation on older devices.

A fix in appcompat will be available in 1.2.0-alpha02. As of this writing, that version has not yet been released.

Add possibility to reorder the cards

Issue by lgasp
Friday Nov 04, 2016 at 07:01 GMT
Originally opened as brarcher/loyalty-card-locker#65


I looked for a way to reorder the card list, to have the most important and used cards, first.

Maybe it's possible by esporting the cards and reordering them in the CSV file, and reimporting them.

Is it possible to add a "reordering cards" feature?

Thanks

Please add GS1_128 barcode type (for UK Nectar cards)

Issue by jaimet
Tuesday Mar 19, 2019 at 12:55 GMT
Originally opened as brarcher/loyalty-card-locker#299


According to this issue comment, "this application will not be able to support GS1_128 barcodes" (as zxing is currently unable to generate this type).

I have a (UK-issued) Nectar card and when I scan the card using "Capture card", the generated barcode does not match the barcode on my Nectar card. Comparing the 2 images to those created by online barcode generator websites, it appears as though loyalty-card-locker is creating a "Code-128" barcode while the real (scanned) card is a "GS1-128 (UCC/EAN-128)" barcode.

Is there any way round this? Many thanks.

(The next time that I'm in store, I'll see whether any of the other barcodes shown under "Edit card" work. Hopefully, I won't arouse suspicion by futzing with their checkout machine for 10 minutes! πŸ˜†πŸ˜†πŸ˜†)

edit: I've just found https://stackoverflow.com/a/34538369/3499840 ("ZXing does support GS1-128...")

[Feature Request] Encrypted Backups

Issue by trymeouteh
Wednesday Dec 12, 2018 at 21:36 GMT
Originally opened as brarcher/loyalty-card-locker#285


When you export a file it is not encrypted and this can be a concert when your backing this file up to cloud storage. Please add the ability to encrypt a file when it is backed up with a password and when you import the file it will as for the password to import the data.

[Feature Request] Add archive OR multiple list support

Issue by shtrom
Saturday Jun 02, 2018 at 07:37 GMT
Originally opened as brarcher/loyalty-card-locker#250


There are a number of cards that I no longer use, but want to keep if I happen to need them in the future. However, they are always displayed in the list, and make it harder to find the cards that I use more often.

It would be good to have a archive feature, where card information is retained, but they are not shown in the main list, but in a new archive list, with the ability to send cards back and forth between archive and main.

Alternatively, support for multiple lists (e.g., archive, groceries, clothes, ...), would also work, in a more flexible way.

WIP: Multiple barcode support

Issue by TheLastProject
Saturday Jan 04, 2020 at 23:45 GMT
Originally opened as brarcher/loyalty-card-locker#337


After seeing #279, I felt the tabs were a good way to support multiple barcodes.

Fixes #264 and I feel it also fixes #279 (because multiple barcodes per store make this possible, just note what the code is for). I am also going to assume this fixes #286 as the user's primary concern seems to be an easier way to add another card from a store they already have.

This code groups together every loyalty card with the same store name and, if multiple loyalty cards with the same store name exist, adds a scrollable tabview to switch between them. The text on each tab is based on the note. If there is no note for that specific loyalty card, it falls back to numbering them. It also switches to using a floating action button. Clicking the "+" button when viewing a loyalty card will start the edit activity with the store name pre-filled, to make adding additional cards to the same store easy.

Some screenshots:
photo_2020-01-05_00-41-56
photo_2020-01-05_00-41-57
photo_2020-01-05_00-42-00
photo_2020-01-05_00-42-01


TheLastProject included the following code: https://github.com/brarcher/loyalty-card-locker/pull/337/commits

Initial pkpass support

Issue by TheLastProject
Monday Dec 09, 2019 at 16:14 GMT
Originally opened as brarcher/loyalty-card-locker#327


This will probably take a bit longer to make completely useful, but this at least does the initial parsing. Marking this WIP just because I believe in sharing progress to allow for early feedback.

When this is done, it will fix #309.

TODO:


This change is Reviewable


TheLastProject included the following code: https://github.com/brarcher/loyalty-card-locker/pull/327/commits

[Feature Request] Duplicate Card

Issue by trymeouteh
Wednesday Dec 12, 2018 at 21:43 GMT
Originally opened as brarcher/loyalty-card-locker#286


If I have to add a second gift card for a store I already have a handy feature would be to hold your finger onto a card and them tap Duplicate. Then it will copy all the data from the previous card except it will ask for a new barcode number and once you add the barcode you tap save and a new card is made.

Landscape view not usable on some devices

Issue by callegar
Monday Feb 26, 2018 at 21:05 GMT
Originally opened as brarcher/loyalty-card-locker#212


On my Samsung S5 mini, the rotated, landscape view has become unusable on recent versions of the application. This is because the card title is too tall, not leaving enough space to the barcode, that ends up as large as the screen width, but only a couple of mm tall, which is insufficient for reliable scanning.

7Rewards: PDF417 barcode generation bug

Issue by albuic
Wednesday Jul 11, 2018 at 00:41 GMT
Originally opened as brarcher/loyalty-card-locker#258


The generation of PDF417 seems to be buggy when using line break characters.
You can test the difference between the app and another generator like https://barcode.tec-it.com/en/PDF417?data=hello%0Ahere
It might be a bug in the zxing library but I did not find anything about it on here: https://github.com/zxing/zxing/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+pdf

Otherwise it might be the difference between linux and windows line break encoding: LF vs CR+LF
In that case a checkbox to select the type of line break (per barcode) might be needed.

For information, the 7Eleven stores in the US use this type of barcode for their loyalty cards (named 7Rewards program) and the generated barcode on the 7Eleven card is the same as the one in the URL above.

(Really nice App btw ;-) )

Zoom the barcode

Issue by bracuphoth
Thursday Aug 02, 2018 at 21:20 GMT
Originally opened as brarcher/loyalty-card-locker#262


I installed the app on a 8" screen tablet. And I discovred that even the portrait version is way too big for the scanner. With a 5" telephone screen everything works fine.

Improve use of screen space / make barcode larger

Issue by devurandom
Saturday Sep 22, 2018 at 16:25 GMT
Originally opened as brarcher/loyalty-card-locker#268


It would be great if the screen space could be used more efficiently on smaller screens.

In portrait mode the use is fine. There is a lot of space that is not used, but the general layout looks good and nothing is disproportionately small.
screenshot_20180922-181432 edit

However, in landscape mode the space around the title is huge compared to the actual text. The size of the barcode suffers from this -- it is displayed way smaller than it could be, which makes it hard to scan.
screenshot_20180922-181409 edit

I would propose for landscape mode to make the padding around the title much smaller and the barcode much larger. The space below the ID number should also be much smaller, to allow more space for the barcode.

Feature request: Android based watch support

Issue by gtr33m
Tuesday Nov 06, 2018 at 03:18 GMT
Originally opened as brarcher/loyalty-card-locker#282


I have an amazfit Stratos which is Android 5.1 based with a 320x300 pixel resolution. The app installs and works with a bit of tweaking of the fonts, however the title bar of an individual barcode is too large and takes up too much of the screen. Could you please include an optimisation for a smaller screen?

Thanks

New entry/edit can be stopped without being asked to save

Issue by tobiasisenberg
Saturday Dec 09, 2017 at 20:53 GMT
Originally opened as brarcher/loyalty-card-locker#167


When a new entry is entered or an existing one edited, it is possible to tap the top-left arrow which brings me back to the overview of existing entries, but without being asked to save. This means that all data/changes are lost if this top-left arrow is tapped without having saved first. It would be better if a safety question would pop up, asking to save or to cancel the new/edited entry.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.