Small picture (logo) per card about android HOT 41 CLOSED

Sorry this has been taking so long! It's finally probably ready (after some further testing) after @leaumar figured out why the tests were failing (I should never have used setID() in Android, it did not do what 4 months ago me expected it to do).

Thanks everyone for your patience and @leaumar for helping fix this :)

from android.

I guess this import tool pinged everyone then.

You guessed right 🙄

from android.

I support adding a square image in place of the current icon as an initial letter. The user will choose ready-made pictures from the gallery. No need to take photos and photo cropping and editing functions. there will be no photos in your application, the user adds them himself.

from android.

Kommentar von x-jokay
_ Mittwoch, 22. Februar 2017 um 05:25 GMT_

I think your idea is good and practicable. Legally, that shouldn't be a problem because the user decides for himself what it wants to use as an image.
advantage it is simple and if the first picture is also used as a logo you do not need a logo database

from android.

Well, it's more that there are a lot of things to make and I want to make the things well. Given the knowledge I gained dealing with images by implementing front and back card image for the next release (which took a few attempts to get right) this should become easier to implement properly soon.

from android.

See #25 for that. I don't have any WearOS devices myself though so that will probably need to be community-contributed.

from android.

Comment by brarcher
Saturday Jan 28, 2017 at 17:13 GMT

Before creating this application I took a look at Stocard and a few others and how they worked. My concern with packaging the logos in the app is a legal one (discussion here). It is not clear to me if I would need to get permission from each company in writing prior to packaging their logo into the application and using it. Stocard's model appears to be based on partnerships with retailers. Although I do not know for sure, I suspect Stocard has the permission of the 1800 companies (as reported on Google Play) whose logo it uses.

It is unfortunately more complicated than all of that, however. This application is free (as in speech and beer) because of the license I have selected (GPLv3). To provide the assets with the same freedom if a logo from another company were to be included the company would need to give permission not only to me but to anyone who would fork this project, not knowing what they may do with it.

In the end, I am glad to provide an application that I (and hopefully others) find useful. I do not want to expose myself to legal trouble, nor be able to provide the application with the level of freedom and flexibility I expect.

Sadly, although your feature request would be really nice to have, I must decline it. Hopefully the reason is understood.

from android.

Comment by x-jokay
Saturday Jan 28, 2017 at 17:23 GMT

The idea was not to package the logos directly into the application but to provide the possibility to set a picture per card.

from android.

Comment by brarcher
Saturday Jan 28, 2017 at 17:56 GMT

Oh, that sounds do-able.

from android.

Comment by brarcher
Saturday Jan 28, 2017 at 17:57 GMT

How would that work, in your mind? Would the user take a picture with the camera of a logo? Would they import a photo? Something else?

from android.

Comment by x-jokay
Saturday Jan 28, 2017 at 18:05 GMT

For stocard I had taken some picture from a google image search and cropped it before setting it in the app.

You may link to an existing picture from the user's gallery or better import / copy it to some sub-dir of the loyality-card-locker data dir?

from android.

Comment by x-jokay
Saturday Jan 28, 2017 at 18:06 GMT

Or do directly a base64 encode of the picture.

from android.

Comment by ni720
Tuesday Feb 21, 2017 at 13:01 GMT

That would significantly raise the acceptance in some shops for this app. As soon as an employee sees the logo of his company he is more likely to accept scanning the loyalty card from an app. Some shops however have a strict no-app-policy.

from android.

Comment by brarcher
Wednesday Feb 22, 2017 at 02:55 GMT

Some shops however have a strict no-app-policy

Really? I've not heard of that before. Interesting.

I am for the idea of having a user selectable logo displayed with the summary on the main page and with the barcode. What is holding back the idea is a nice layout design for when there is and is not a logo present. I'm not the best that that, and am hoping that someone with an idea may contribute a suggestion.

from android.

Comment by x-jokay
Wednesday Feb 22, 2017 at 05:07 GMT

Why not using a default card icon as kind of placeholder if no picture was set?

from android.

Comment by x-jokay
Wednesday Feb 22, 2017 at 05:25 GMT

from android.

Comment by x-jokay
Wednesday Feb 22, 2017 at 05:25 GMT

Some samples without and with icon.

from android.

Comment by x-jokay
Wednesday Feb 22, 2017 at 06:08 GMT

I'm not sure if it's really necessary to have the barcode displayed on the main page?

from android.

Comment by jimmyswimmy
Friday Apr 07, 2017 at 04:04 GMT

This last set of pictures offers an interesting idea - it would be awesome to include pictures of the card. I was shopping at Costco and the cashier wanted to see the card, but then scanned my phone... but he said if I'd had pictures he would have accepted that. I'd be interested to try to implement this (know nothing about android programming but I'm a quick study) if x-jokay has all of those icons etc. I hate front end work.

from android.

Comment by x-jokay
Friday Apr 07, 2017 at 05:20 GMT

The screenshots were taken from the app stocard, I don't "own" those icons.

from android.

Comment by brarcher
Friday Apr 07, 2017 at 20:49 GMT

If the issue is icons, I've used a number of icons from The Noun Project for other applications. @jimmyswimmy, if you are interested in taking this on and need some icons, maybe give that a look. The only thing which would need to be done is to ensure that the icons are release under a Creative Commons license and give credit in the README and in the About dialog. Here is an example of adding references for image resources.

from android.

Comment by ioangogo
Tuesday Jul 25, 2017 at 11:20 GMT

Has any progress happened in this issue yet, I am tempted to work on this issue as I also feel like it would be useful in shops that might be a bit hesitant on scanning a barcode from this app

I'm currently thinking about how display it on the card page, I'll upload some scribbles at a later point as I am currently not near a laptop/desktop

from android.

Comment by brarcher
Tuesday Jul 25, 2017 at 11:44 GMT

I've not made any progress on this. I encourage you to give it a shot!

from android.

Comment by x-jokay
Tuesday Jul 25, 2017 at 11:47 GMT

Not as I'm aware of :)

Anyway, mobile payment solution providers start to integrate customer cards directly and will be used automatically during payment process.

We may continue to use this app for customer cards which are not yet supported.

from android.

Comment by ioangogo
Thursday Jul 27, 2017 at 13:15 GMT

Currently i have 3 ideas for the placement of the store logo, 2 i have mocked up in GIMP and the other is just having the logo over the barcode. I like it being by the store name, but that only works with stores that have a logo like the national trust, or the body-shop, most have their name in the logo so having it above the barcode may work but does not allow for low resolution images.

Mockups:

1

2

from android.

Comment by ioangogo
Thursday Jul 27, 2017 at 22:42 GMT

@x-jokay yeah, android pay supports quite a few now, although I did find this useful when visiting a national trust property and my farther had forgotten his card

from android.

Comment by brarcher
Friday Jul 28, 2017 at 00:22 GMT

but that only works with stores that have a logo like the national trust

I would expect that if the store had or did not have the name in the logo it would still be recognizable to the end user, and may not require having the store name and logo both.

Could you create a mock-up with the logo above the barcode, to see what that is like?

but does not allow for low resolution images

Do you mean that if one were to use a low resolution image it would not look good, so for a good experience one would need to source higher resolution images?

from android.

Comment by ioangogo
Friday Jul 28, 2017 at 00:45 GMT

@brarcher on the resultion thing, yes I did mean that

I'll try to make a mock up of the logo above the barcode when I can.

from android.

Comment by brarcher
Friday Jul 28, 2017 at 02:14 GMT

Thanks for taking this on, @ioangogo!

from android.

Comment by ioangogo
Monday Jul 31, 2017 at 17:22 GMT

Here is a mock up of it above the barcode

from android.

Comment by brarcher
Monday Jul 31, 2017 at 17:35 GMT

I like the full sized barcode more, what do you think?

Another thing that I am thinking is perhaps the order of the information could be better, to put the more relevant information closer to the top. For example:

Or, another option might be to omit the store name if there is an icon:

Do you have an opinion on the order of the presented data? Perhaps there is a better idea.

from android.

Comment by ioangogo
Monday Jul 31, 2017 at 18:40 GMT

I personaly prefer the current set up, It just kind of flows with the large images at the bottom and the small text at the top

from android.

Comment by ioangogo
Wednesday Aug 02, 2017 at 14:22 GMT

Or do directly a base64 encode of the picture.

@x-jokay the app uses a sqlite database so it may be possible to use the SQLITE BLOB data type, but to keep the CSV exporting simple I might use your suggestion

from android.

Comment by matthijskooijman
Friday Sep 15, 2017 at 16:48 GMT

Just to double-check: Is this issue about just adding a logo, or are photographs of the card itself also considered? It has been mentioned in the comments, but I'm not sure if they're also considered (I do think images of the card, front and back, really add something. Using the front side of the card as the "logo" in the overview of cards works really well in mobile pocket which I was using before). If it helps, I'm happy to create a separate issue for that, though I suspect these could be tied together, also in terms of implementation.

from android.

Comment by x-jokay
Sunday Sep 24, 2017 at 19:34 GMT

It was about adding a logo to the card (manually from the gallery) :)

I think a separate issue for this will be a good idea.

This issue can then be linked if it really makes sense for the implementation.

from android.

Comment by ioangogo
Monday Dec 11, 2017 at 01:37 GMT

Sadly due to workload related reasons I will probably not be able to do this now, I hope someone else picks this up. I had written some code, but it was mostly updating the database, sadly the laptop it was on died and I haddent committed it to my fork

from android.

@TheLastProject umad?

from android.

No clue what you're talking about, just copying over issues because I'm continuing this project (see the README of brarcher/loyalty-card-locker). I guess this import tool pinged everyone then. That's quite unfortunate, wasn't my intention to cause any type of spam. I'll report that to the import tool. Sadly GitHub doesn't offer any native support for copying issues yet I still want to keep track of what issues I have fixed in my fork so... yeah...

from android.

@redseasix yes, but it seems very difficult to provide a simple file chooser and set a locally stored image, so the discussion goes on ^^

from android.

Good news, after using Wear Codes on my Wear OS smartwatch ^^

Any plans on making your app work on Wear OS too? Stocard works on Wear OS too.

from android.

I don't think it will be this different than on an Android smartphone (beside the screen size, which surely need app optimizations).

from android.