Comments (5)
Comment by brarcher
Monday Mar 19, 2018 at 03:02 GMT
I never thought of a card that would expire. But you are right, that is possible.
In the previous layout adding new fields was easy: just throw it in the list. The new layout, though, will be trickier. Where would you think this data should be presented? Should it appear in the summary list, or only when viewing a single card? Could you give a mock-up of how you seeing it look?
What happens when a card expires? Is the field data only, in which case nothing happens?
When there is metadata I want to keep about a card I'll put it in the note field. Would adding the expiration date to the note field work (as a workaround) or would it be kludgy?
from android.
Comment by ghost
Sunday Mar 25, 2018 at 19:37 GMT
I thought it would make sense to cross out the entry in the overview list and write the text of the entry in italics once the card has expired.
If you look at a single customer card, the field should of course also be visible, because you can edit the card from there.
As a workaround, I write "expired" in the notes field. It is nice, but changing or adding it is easy to forget.
I could give a mock-up of how I see it looking but it would take some time.
from android.
Comment by brarcher
Monday Mar 26, 2018 at 14:43 GMT
I think a mock-up would be helpful. The edit screen is understandable:
The date can be picked with the date picker.
and the card selection screen is simple enough:
cross out the entry in the overview list and write the text of the entry in italics once the card has expired.
What about the view which looks at one card? I'm wondering how that should appear? Also crossing out and italics?
from android.
I need to still fix the relevant unit tests but 6488dc0 implements this pretty much.
from android.
Okay, the unit tests finally work. So the next release will contain the option to set an expiry :)
from android.
Related Issues (20)
- Improve design of multi-barcode picker
- Sandbox PdfRenderer in a Service with android:isolatedProcess
- Highlight archived cards HOT 2
- Display loyalty cards as a text list, without thumbnails HOT 3
- Hide Card ID for binary content? HOT 2
- Loyalty card shortcut not updating with latest card information HOT 2
- About screen text can overflow into arrow HOT 1
- Proposal to Enhance Testing Infrastructure and Automate Workflows HOT 1
- Incorrect Implementation of describeContents() in LoyaltyCard Class HOT 3
- Google Play: "Can't install Catima (2.29.0)" HOT 3
- Errors in Spanish Translation HOT 1
- Cannot save balance in Arabic
- Option to disable the edit button on the lock screen HOT 3
- FR: Share text to app instead of image HOT 4
- Shortcut in control panel HOT 1
- Unable to open a card from the device control quick settings tile HOT 10
- Add an attached document (PDF) HOT 8
- can android.hardware.camera use required=false? HOT 2
- Barcode scanner error unreadable on Samsung in light mode
- Front of Card Image not the default HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android.