Comments (3)
I suppose you mean when "Prevent screen lock" is enabled in Catima settings and you turned off and on your screen again?
Probably not that hard to implement. I'm not quite sure about it. I see your point (accidental press), but I also see how other users could be confused that "the edit button disappeared". Having more opinions and pros and cons here would be useful :)
from android.
I'm definitely not interested in adding another setting. I strongly watch out to try to have as little settings as possible in Catima to keep it easy to find the settings that matter, keep the amount of code paths down (every extra code path introduces a chance for extra bugs).
I've been thinking of this issue a bit more and I think the general issue here is not so much the edit button specifically, but the fact that drawing over the lock screen means the UI could be interacted with when people expect the device to be locked. This could either be accidental UI presses in someone's pants, but also a clumsy handover to a cashier causing a card to be unfavourited or left.
Because of this, I think it may be worth considering to, instead of just hiding the edit button, do the following:
- Hide all the UI elements that would change the state of the card or activate activity switches ("Edit", "Quick spend/receive", "Share", "Star", "Duplicate", "Archive", "Delete")
- Show some kind of message (maybe a Snackbar? Not sure) that says that some options are hidden because the device is locked and to unlock the device to get access to all options, that can be tapped to unlock. I haven't tested it, but it seems like isKeyguardLocked and requestDismissKeyguard functions should make this possible to do.
from android.
I have Keep screen on and Prevent screen lock enabled. But I like the option to lock the phone with the screen on and the code, but the edit button bothers me. An "edit button on locked screen" with a disable / enable option would be a cool feature.
Edit: If I accidentally press the edit button when the screen is locked then after unlocking I'm in the Edit Card and I don't want that.
from android.
Related Issues (20)
- Make status bar colour match app bar colour HOT 5
- Exclude archived cards in ShortcutHelper HOT 1
- created data marix does not contain the proper information HOT 4
- Improve design of multi-barcode picker
- Sandbox PdfRenderer in a Service with android:isolatedProcess
- Highlight archived cards HOT 2
- Display loyalty cards as a text list, without thumbnails HOT 3
- Hide Card ID for binary content? HOT 2
- Loyalty card shortcut not updating with latest card information HOT 1
- About screen text can overflow into arrow HOT 1
- Proposal to Enhance Testing Infrastructure and Automate Workflows HOT 1
- Incorrect Implementation of describeContents() in LoyaltyCard Class HOT 3
- Google Play: "Can't install Catima (2.29.0)" HOT 3
- Errors in Spanish Translation HOT 1
- Cannot save balance in Arabic
- FR: Share text to app instead of image HOT 4
- Shortcut in control panel HOT 1
- Unable to open a card from the device control quick settings tile HOT 10
- Add an attached document (PDF) HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android.