Add the icon of the site about android HOT 11 CLOSED

Comment by brarcher
Tuesday Jun 04, 2019 at 15:11 GMT

Is it possible for a GitHub project to have its own favicon? I see that one can have a custom webpage with GitHub and have a favicon there:

https://github.community/t5/GitHub-Pages/Favicon-with-github-pages/td-p/273

However I do not believe that the project page can have its own favicon. If I am incorrect, feel free to let me know.

from android.

Comment by egvimo
Wednesday Jun 05, 2019 at 07:22 GMT

I think he meant that the favicon of the respective customer card website is used instead of the first letter as is the case now.

from android.

Comment by atallo
Wednesday Jun 05, 2019 at 07:36 GMT

I think he meant that the favicon of the respective customer card website is used instead of the first letter as is the case now.

Yes. I wanted to say that. Forgive my bad English.

from android.

Comment by franga2000
Wednesday Jun 05, 2019 at 08:12 GMT

I would just like to drop in and mention that I am currently working on a way to do this using an online database (an open-source crowd-sourced one, of course) that would not only have the icons (square) but also the full (wide) logos and some metadata for each brand.

I am currently experimenting with integrating this into the app in a way that does not compromise any of the current features (I'll make a branch on my fork when it's good enough). Is that something you would be interested in merging?

from android.

Comment by brarcher
Friday Jun 14, 2019 at 03:10 GMT

Ok, got it. That would be pretty cool. There was a discussion about this in the past in one of the issues. Previously the layout was not so friendly, and there were suggestions to add support for store icons to the app. I was concerned about embedding the icons into the app without proper permission, and as a compromise updated the app to what you see today.

One point of caution is needing to use the internet permission to access the online database. Currently the app does not need internet access to function. This is intentional. If support for the database was added two common ways to accomplish it would be (1) to give the app internet access or (2) embed the icons into the app. Both of those are undesirable.

There is another option, which is to make a plugin for the app which adds support for accessing the database. The plugin would have internet access, and there would be some interface between this app and the plugin to get the data. That would involve a lot more work. We'd need to discuss what the payoff would be and if it is worth it.

Anyway, I look forward to see what you are working on when you are ready. (:

from android.

Comment by jxosborne
Friday Jul 12, 2019 at 17:13 GMT

This is a great idea; but as mentioned there may be some issues with IP and the respective cards if the data is maintained somewhere. It might be a better option to simply have the option to add an image from the local device to use as the icon, it would be much more straight forward to implement, and would take away any legal issues. In addition to that, it would be very handy to have that same icon displayed as the widget graphic when adding a shortcut to a card onto the home screen.

Thanks for all the great work you've done with this application, I've been using it for nearly a year now!

from android.

Comment by TheLastProject
Tuesday Dec 03, 2019 at 16:53 GMT

I believe that store icons would fall under fair use as long as you're clear you're not associated with any of the stores. A generic "Loyalty Card Locker is not affiliated with any of the company icons listed, company icons copyright their respective owners" statement in the About screen should be sufficient, I believe.

I think the best way would be to have a list of store names and icons, so that if someone starts typing a store name like "Ama", "Amazon" would show up in the list with an icon and it could be tapped to select it and set that icon too.

One point of caution is needing to use the internet permission to access the online database. Currently the app does not need internet access to function. This is intentional. If support for the database was added two common ways to accomplish it would be (1) to give the app internet access or (2) embed the icons into the app. Both of those are undesirable.

While I understand that, is embedding the icons in the app really that undesirable? For example, Font Awesome has 433 brand logos, which total 445 kb on disk space for all the .svg files. While they lack many icons for retail chains who would have loyalty cards, I'd believe if we choose smart, size would not be an issue? And we wouldn't have to host the logos in this repository, as we'd have a third party supplying them. Including them in build time seems quite possible. I think that would severely limit any copyright worries of embedding the icons too.

from android.

Comment by TheLastProject
Tuesday Dec 03, 2019 at 17:02 GMT

https://github.com/simple-icons/simple-icons/blob/develop/_data/simple-icons.json also looks quite promising: just an icon and a background colour in hex. I'd happily write a script to embed relevant icons if we can figure out which of these would offer loyalty cards to not include too much useless stuff.

from android.

Comment by vertigo220
Thursday Aug 27, 2020 at 14:44 GMT

Just found this app after deciding to ditch a couple others I'd been using due to permission creep, so I'd like to second what @brarcher said about the adding of internet permission being undesirable. I chose this app because it's open-source and uses the bare essential permissions, and not internet. So if this is done, I would much prefer a plugin, though really if the ability to use an image, as requested in #86 and #144 (which are practically duplicates of each other and very similar to this issue), then the user could do this themselves, and personally I think an image with a full name would be more immediately recognizable vs a favicon with a single letter or small image. For example, the blue image with white lettering saying "Lowe's" would be far preferable to just the blue image with no lettering that is used as their favicon.

from android.

Comment by vertigo220
Thursday Aug 27, 2020 at 14:47 GMT

Just had another thought: instead of a plugin, you could make another version of the app with internet access and this feature, so users could install that, generate the icons, save the database, then uninstall and install the version without internet access (assuming they wanted to) and load the backup. This would be easier for development, and the only downside would be that the user would have to install the internet version whenever they needed to add a card and get a new icon, but they could do that without uninstalling the non-internet version.

from android.

Closing this as a duplicate of #8

from android.