I know nothing about VSCode plugins, but isn't Thenable a typo? Shouldn't it be Themable?

https://github.com/GodotExplorer/godot-tools/blob/4c47fff9afbcd81694506516cfff53fc0bd01413/src/gdscript/completion.ts#L48

If the condition is something like if (somecondition or someother) and condition: it gives a false warning.

The regex should be something like (if|elif|while|match)\s*\(.*\)\s*:\s*$

But there's one other case this doesn't catch, and that's when you have something like if (somecondition) or someother: but I wouldn't know how to fix that in one regex expression without a negative look behind for and/or which javascript doesn't support.

In 0.3.4, Godot 2.1:

All constants in this script of my project are indicated as unused:

However, they are:

...

I get no accurate completion from Group.* either.
They should be resolvable since it's all consts. Maybe it's a more general intellisense problem regarding consts?

The same happens with member vars, but they are not consts so I guess it's harder to verify:

How could you guess?^^

In that case it would be nice to not squiggle those since it's not reliable, unless they are prefixed by _ though, as an option?

When typing self. the intellisense completion appears to include every possible symbol, not just those that the Sprite class responds to.

Is it possible to have a feature as provided by https://marketplace.visualstudio.com/items?itemName=stringham.move-ts ? This together with a proper rename function - which I also opened an issue for - would give great power for refactoring and limit possible bugs created by it.

I like writing code my own way, like using brackets in if statements for example, even when they aren't needed.

It'd be nice to be able to disable some of these rules or even all of them.

I don't think there's a way to do it with the current settings, am I missing something?

Also, I've added the extension from the extension manager in VSCode, but I still get warnings for inlined if else statements (even though they're fixed here).

Plugin Version: 0.2.9
VSCode Version: 1.14.2

I get syntax highlighting, but [CTRL+SPACE] produces only templates, not functions.

The definition for user created methods and variables is always shown at least 2 times, when the method/variable is only defined once:

if x > y: continue is a valid Godot statement, but is displayed as an error.

This statement:

			info("Mesh names match, deleting old one")

gives the error

 ': or \' expected at end of line.

But there is no error. If you delete the comma in the string, the error message goes away.

What is license of your code? GPL?

Getting weird results, when naming variable as ll (lowercase LL).

Shows syntax warning, that "Variable ll is never used", although it's clearly used later. Screenshot:

If I rename this variable, then it works correctly. Screenshot:

Maybe there's more variable names that produce this false syntax error.

Hi, I set the VS Code to be my default text editor and when I set this: {project} --goto {file}:{line}:{col}, the console drops this error:

the mode arguments from "--goto" must have format "FILE(:LINE(:CHARACTER))"

What that means?, thanks in advanced, cheers.

PD: I'm not an experienced programmer, that's why I don't understand.

For javascript it works like this:

http://stackoverflow.com/questions/31283811/vs-code-autocompletion-base-on-word-in-file
http://stackoverflow.com/questions/30793337/vscode-intellisense-autocomplete-for-javascript

: (

When I have a warning about a variable being never used, I delete that line but the warning stays.
Tested on linux 64 bit with latest visual studio code binary from the website.

Refactoring in Godots native editor is a nightmare for me. Rename one node and create possible bugs all over the place. VS code seems to have a proper rename function which changes variable occurences but as microsoft/vscode#7213 states this has to be added to the language extension as it is highly language specific.
My only alternative is "Change all occurences" which also changes strings - not the wanted behaviour. This would be an awesome feature and I bet one many Godot devs would like.

Test case:
if command.match("*"+text+"*"):
gives a warning.

Example ('for' is part of the string, yet it's detected as an expression):

"Update GDScript symbols done" notification on program open is intrusive. Can it be done in a less intrusive manner, hidden, or have an option to be hidden?

The following is valid GDScript, at least it works in the engine itself with no complaints, but gets highlighted as an error. (see Line 64 and Line 71)

Screenshot:

• ': or ' expected at end of the line.

return val if sign_flag else -val

var ret = plugin.get_properties(self) if plugin != null else []

sorry my english
if I deleted the comment 2 the keyword disappears.

I installed the Godot game engine through Steam, and it puts the engine under the directory Godot Engine. The space (in Godot Engine) is messing up the argument parsing (because the editor argument is not escaped/quoted), and causing the extension to fail when loading the editor:

PS D:\projects\godot> D:/SteamLibrary/steamapps/common/Godot Engine/godot.windows.opt.tools.32.exe -path D:/projects/godot  res://C:/settings.json

D:/SteamLibrary/steamapps/common/Godot : The term 'D:/SteamLibrary/steamapps/common/Godot' is not recognized as the name of a cmdlet, function,
script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ D:/SteamLibrary/steamapps/common/Godot Engine/godot.windows.opt.tools ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (D:/SteamLibrary/steamapps/common/Godot:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

VS Code gives the error output: Invalid editor path to run the project

A few strings I've tried:

Normal string
"D:/SteamLibrary/steamapps/common/Godot Engine/godot.windows.opt.tools.32.exe"

Single quoted string
"'D:/SteamLibrary/steamapps/common/Godot Engine/godot.windows.opt.tools.32.exe'"

Caret before space
"D:/SteamLibrary/steamapps/common/Godot^ Engine/godot.windows.opt.tools.32.exe"

Quoted with caret before space
"'D:/SteamLibrary/steamapps/common/Godot^ Engine/godot.windows.opt.tools.32.exe'"

back slash (single backslash was giving "Invalid escape character in string", presumably because of the json spec https://github.com/Microsoft/vscode/issues/23601)
"D:/SteamLibrary/steamapps/common/Godot\\ Engine/godot.windows.opt.tools.32.exe"

& quoted (which is what powershell expanded it out to be when you do tab completion)
"&'D:/SteamLibrary/steamapps/common/Godot Engine/godot.windows.opt.tools.32.exe'"

This extension has been identified as using command-links in either hovers or decorations. The August release (1.16) is the last release to support this in the MarkedString and with September the MarkdownString must be used. We are doing this because of security concerns. Background and details are explained here: microsoft/vscode#33577 (comment)

The adoption should be straight forward and usages of MarkedString need to be replaced with:

let md = new MarkdownString(content);
md.isTrusted = true;

Please let us know if you need more information. Thanks and Happy Coding

Builtin methods like _ready, _fixed_process etc. are indexed in the whole workspace. I think it would be more useful to only have the engine's built-in definition, so you can access the documentation easily. The current implementation makes it harder to find the information you're looking for (the screenshot is for a small project - with a large godot game, it's going to be worse).

I would suggest 2 options:

• Don't index the symbol when it's a built-in method
• Or only add the definition once and leave "Click to show 8 definitions"

An example how python does it in Visual Studio Code: https://donjayamanne.github.io/pythonVSCodeDocs/docs/refactoring_extract-method/

I quickly created a new icon, based on the one from Godot 3.0.
Glasses are from iconmonstr

what do you think? :)

Since Godot 2.1.3 there's been introduced ternary if else shorthand. Currently this plugin has no support.

Screenshot:

Godot Docs: http://docs.godotengine.org/en/stable/learning/scripting/gdscript/gdscript_basics.html?highlight=ternary#if-else-elif

The search for the next line in function blockIndetCheck can be confused by a trailing space of the next indented line like showing in the following screenshot.

The constants true, false, & null don't show up in my autocomplete results.

My guess is that there's something wrong here

VSCode now has auto indentation support, but this needs indentation rules per language to work:

Hi,

Great work on this toolset, thanks for your hard work.

When typing pass in an empty function/code block the autocomplete doesn't suggest pass and typing pass + [Enter] will give you something you then have to delete.

Could you add pass to the autocomplete dictionary please?

Thanks

Adam

I configured the editor path to the directory my executable is located in, but I am still getting "Current workspace is not a godot project" error when I attempt to run the project from VS Code.

My user settings look like the below:

{
    "editor.codeLens": false,
    "csproj.itemType": {
        "*": "Content",
        ".ts": "TypeScriptCompile",
        ".cs": "Compile"
    },
    "csharp.format.enable": false,
    "GodotTools.completeNodePath": true,
    "GodotTools.editorPath": "C:\\Godot_v3.0-stable_win64.exe\\"
}

A statement with a semicolon in a quoted string should not be flagged as an error.

Test case:

	func("hi; test!")

Because keywords in comments are treated as normal sourcecode they trigger end of line errors like shown in the following screenshot.

If I'd write this:

def derp():
pass # replace later

Which is generated by connecting signals in the editor to scripts, the extension sees this as an error in the code analysis while it shouldn't be, mistaking it for this behaviour:

def derp():
# replace later

When I connecting a signal by editor ,it cannot insert signal method to gdscript file.

Looks like there was a new version of the extension published to the Visual Studio Code Marketplace that causes at least the syntax highlighting to fail with a "Load GDScript documentations failed" error.

In the Marketplace the extension has the folloving in the More Info section:

In addition the Change Log in the Marketplace displays the 0.3.5 version with following changes:

• Add option to disable syntax checking for GDScript
• Improved inline if else statement syntax checking
• More resource type supported for syntax highglight
• Bump default godot version to 3.0
• Sync the documentations from godot 3.0

Latest commit to this repository however was on Jan 1 and there's no mention of 0.3.5 anywhere.

I do not know if it comes from my editor or your code but I did not find any answer on the web:

This work fine

But when I ctrl+clic to see the full documentation :

On VSCode version 1.7.1, and no auto-completions seem to be working. I don't get them while typing, and ctrl+space gives me the message about not finding them. Hovering doesn't work either. Snippets working correctly, though.

Waring the assign and equals operation below:

var value = value
self.condition == Utils.create_condition(logicmain, cd, format)
if a = b:
  pass

func valid(param):
    return param = null

func iterate():
  for i in (50):
    pass

This results in error: Invalid for expression. Removing parens from the expression clears the error:

func iterate():
  for i in 50:
    pass

This is correct GDScript code, but you get "Expected end of statement after expression" error on any match pattern after the first one:

func match_func():
  var str = "hello"
  match str:
    "world":
      pass
    "hello":
      pass
    "third":
      pass

Something went wrong with colors here:

https://dl.dropboxusercontent.com/s/5l3m6sk7vio5pu0/shot_170324_140847.png

texture = (_mSprite if !mState else GameVars.backTheme)

or

texture = _mSprite if !mState else GameVars.backTheme

Prompt errors :
': or \' expected at end of the line.
Expected indented block after expression
and

texture = _mSprite if mState else GameVars.backTheme

or

texture = _mSprite if not mState else GameVars.backTheme

don't
Thanks for your awesome work !

Hi,
This is legal syntax in Godot, but is reported as an error in your extension.

I get this marked as error:

https://dl.dropboxusercontent.com/s/udr4vsx1nz6dogn/shot_170323_170407.png

Is it possible to get C# support for the upcoming 3.0 release