divinumofficium / divinum-officium Goto Github PK

r111 inadvertently converted /trunk/web/www/horas/Latin/Sancti/02-08.txt to 
UTF-8. Consequently, the accents in Lectio94 will not appear correctly.

We are going to need to code the following things into Sancta Missa for the 
rubrics for dates ≧ 1960, because there is a lack of accuracy there for 
Masses after the octaves of Christmas, Epiphany, etc. 

I have also written in the "Gallican" prefaces, which are permitted for use in 
the 1962 Missal, and should be offered as an option in versions ≧ 1960 on 
those days indicated by the rubrics. As soon as I get a good English 
translation, I'll include that as well.

Dear administrators,

Please find attached a patch against r30 of the divinum-officium project
making a number of corrections to the offices of Doctors. I would be
grateful if you would please consider it for inclusion, and will
endeavour to amend it if it should be unsatisfactory.

The main changes are as follows:

- The Magnificat antiphon 'O Doctor optime' is removed from the propers
where it occured there, as it is the common.
- Names for insertion in the aforementioned antiphon are added and
corrected in a number of cases.
- Several Doctors not previously referring to the common of Doctors are
corrected to do so.
- Ss. John of the Cross and Anthony of Padua gain separate 'Trident
1910' offices to reflect the dates of their elevations.
- A line of logic for the 'Rubrics 1960' made obsolete by the above
changes is removed.
- St Bede's feast is corrected to be of lesser double rank.
- Numerous other small corrections.

Thank you for your time.

Kind regards,
Gregor Dick

I find the format on the handheld to be wasteful of screen space. I'd like to 
choose very small margins so that the text goes out to the edges of the screen.

Offer width choice to user?

This would apply to all rubrics and days -- it's a basic format issue.

In both Trident1570 and Trident1910 psalm 117 is being omitted from Sunday 
Prime.

The downloadable files on 
http://www.divinumofficium.com/www/horas/Help/download.html should be updated 
regularly with the latest edits that we have made to the repo.

We also need to add a link on this page, and preferably on the home page as 
well, to the Google Code site.

On the download page, the wording could be:

The repository for the code for this site can be found at 
http://code.google.com/p/divinum-officium.  This site provides a Subversion 
repository for the Divinum Officium Project, so that edits can be made to the 
code while they are made accessible to the entire team.  Errors may also be 
posted as "Issues", located on the heading of the Google Code site. This 
repository always has the most up-to-date version of the files, as the 
repository goes live from here to the website usually every Saturday.

Any corrections or suggestions?

I suggest using the Test::* packages from CPAN (Test::More, Test::HTML::Lint, 
TAP::Harness) to build a test suite for this project.

I found this presentation a useful introduction to the Test::* packages: 
http://petdance.com/perl/automated-testing/

You can see my initial work here:
  https://github.com/fiapps/officiumprog/tree/master/t

I built a simple Perl object (Test::Officium in TestOfficium.pl) that takes 
named parameters specifying an office and gives access to the HTML and plain 
text for the office.

Individual test files (*.t) use this functionality to fetch a particular office 
(let's call it $off), and can then:
 * validate the HTML with html_ok($off->html())
 * check for the presence of particular strings with like($off->text(), $regex, $comment)
 * check for the absence of something with unlike($off->text(), $regex, $comment)

Individual test files can be run directly with Perl (useful for debugging), but 
to run the whole suite we would use a simple script based on TAP::Harness to 
run all the .t files and summarize the results.

Checking for a regex is sufficient to do a whole host of tests:
 * is the alleluia absent from a particular office when it occurs after Septuagesima and present when it occurs (in a different year) before Septuagesima?
 * Is the correct hymn selected for a virgin martyr and a non-virgin martyr?
 * Is Psalm 50 said at lauds and not at matins when feria IV falls during the quattor tempora?

On the four Ember days, the 1960 Missal offers a "missa brevior" which should 
be offered as an option under the 1960 version of the Sancta Missa.  I have 
attached the Latin-English files which I have edited for these days.

If you call up Sancta Missa on December 25, 2011, you will see that there is a 
radio button on the top of the site to select the Mass (1st, 2nd or 3rd Mass of 
Christmas).  We could do the same thing for the Ember Saturdays, with the 
titles "Forma Longior" and "Forma Brevior" rather than 1, 2, and 3.

Check and apply the attached patch files for Common 7 from Roberto Lionello 
<[email protected]>.

What steps will reproduce the problem?
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=10-17-2011&command=p
rayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=

What is the expected output? What do you see instead?
The hymn at matins should be that for a non-martyr virgin. Instead, the hymn 
for a martyr virgin appears.

Please provide any additional information below.

After noting the problem with the office of St. Therese, I decided to see if 
the same problem occurred in other offices of non-martyr virgins. I looked at 
all of the offices of non-virgin martyrs I could find in in the 1961 calendar, 
and this is the only error I found.

What steps will reproduce the problem?
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=10-5-2011&command=pr
ayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=

What is the expected output? What do you see instead?
The antiphon for the 8th psalm should be "Intellegite, qui obliviscimini Deum." 
(1961 editio typica, p. 128). The first word appears incorrectly as 
"Intelligite".

Please provide any additional information below.

The antiphon in question is in "horas/Latin/Psalterium/Psalmi matutinum.txt", 
under both [Day3] and [Day31].

In the Tridentine rubrics both the antiphons for Sunday Vespers are doubled 
when there should only be the fragment before the psalms.

What steps will reproduce the problem?
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=10-5-2011&command=pr
ayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=

What is the expected output? What do you see instead?
The responsory after lectio iii. is completely wrong. It should read (1961 ed. 
typica, 806):
R. In hymnis et confessionibus benedicebant Dominum,
* Qui magna fecit in Israel, et victoriam dedit illis Dominus omnipotens.
V. Ornaverunt faciem templi coronis aureis, et dedicaverunt altare Domino.
R. Qui magna fecit in Israel, et victoriam dedit illis Dominus omnipotens.
&Gloria
R. Qui magna fecit in Israel, et victoriam dedit illis Dominus omnipotens.

Please provide any additional information below.
The file containing the error is horas/Latin/TemporaM/101-3.txt
The correct responsory is TemporaM/101-1:Responsory3
But the file erroneously references 101-2

Furthermore, according to the 1961 ed. typica, after "benedicebant Dominum" 
there should be a comma, whereas TemporaM/101-1:Responsory3 has a period 
instead. The punctuation is otherwise correct.

What steps will reproduce the problem?
1. use DIVINUM_OFFICIUM_URL a base url with ~ in it
2. generate any hora
3. the cross image at Deus in adiutorium is missing

Because its image URL has had the ~ removed.

Solutions
a) don't erase the ~, or
b) use Unicode characters for the crosses instead of images

Could someone kindly assist me with coding on the Sancta Missa site?  The 
commemoration of St. Mark, Pope today should be the Collect: "Gregem tuum", 
Secret: "Oblatis muneribus" and Postcommunion: "Refectione Sancta" from the 
"Commune Summorum Pontificum" (Missa/Latin/Commune/C4b.txt).  This should be 
the case for all years where the collect "Gregem tuum" supersedes the collect 
for the Pope in question.

Though documented, the --entry switch to divinum-get.pl was unimplemented.

For Saturday, 9/24: Vespers should be First Vespers of the Sunday, not of the 
Ember Day.  Perhaps a script could be written so that for 1955 and 1960, Ember 
Saturday in September ends after None.

Also for Saturday, 8/6, Vespers should be of the Transfiguration, not of the 
Sunday. This may necessitate a special script in Perl when the decision is made 
as to what happens at Vespers.

Problem:
In the office for St. Michael (1960 rubrics, 
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=9-29-2011&command=pr
ayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=), an 
alleluia should appear at the end of certain antiphons:
1. The second and fifth antiphons for the psalms at Lauds should have an 
alleluia at the end (cf. ed. typica, 1198). These same antiphons are also used 
for terce (2nd antiphon), none (5th), and vespers.
2. The antiphon for the Benedictus should also have an alleluia at the end (cf. 
ibid., 1199).

The alleluia correctly appears in the antiphon for the Magnificat.

Analysis:
The antiphons in question come from the ersatz "common of Angels," viz., the 
office of the apparition of St. Michael (formerly May 8, but no longer extant 
in the 1961 breviary). In that file, the alleluias are present in parentheses, 
which means they will only be displayed in Eastertide (the antiphon for the 
Benedictus is [Ant 2]).

This correction could impact other offices. The May 8 office is used by St. 
Raphael (Oct 24) and by St. Gabriel (March 24). However, in both cases, the 
proper office overrides the antiphons, so there is no problem.

The only potential issue I see is with older versions of the breviary, which I 
haven't checked.

WARNING:
Do not directly apply this patch. The attached patch makes the three antiphons 
in question correspond to the 1961 editio typica, but once again, Google Code's 
editor has converted the text from CP1252 to UTF-8, inducing spurious and 
erroneous changes to Capitulum Vespera and Lectio94.

As an aside, I note that life would be simpler in many respects if we were to 
convert the data files from CP1252 to UTF-8.

Although all Latin texts should be supplied with accents, a most visible change 
would be achieved by adding them to the Ordinary.

This is in r73 or thereabouts, but not on the live site currently (10-10-2011).
What steps will reproduce the problem?
1.  Look at Vespers for 1-1-2011 : it's Holy Name, but ought to be the Nativity 
Octave (Circumcision)
2.  Look at Lauds: it's Sancta Maria in Sabbato (!!)

What is the expected output? What do you see instead?
Should be an octave of the Nativity day.

Correct typo ("Gomm.). With the patch, the citation for lectio 7 will 
correspond to the 1961 editio typica
(p. 1197).

What steps will reproduce the problem?
1. in Matutinum and Prima, look at the gloria popup link in the little response 
or the pater noster in the V/R's

What is the expected output? What do you see instead?

Expect "Pater noster" and "Gloria" with the initial in red: it's red but 
lowercase.

In the oratio for St. Margaret Mary, the last word before "$Qui vivis" should 
be mereamur, not mereamus.

What steps will reproduce the problem?
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=10-18-2011&command=p
rayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=

What is the expected output? What do you see instead?
In Lectio4, the initial line "Ex libro sancti Hieronymi..." should be black, 
because it is meant to be read aloud. Instead it appears in red. Eliminate the 
exclamation mark before these words and add a line below it reading "!Cap. 7". 
See attached patch. With these changes, the text will conform to the 1961 ed. 
typica, p. 1226.

Please provide any additional information below.
web/www/horas/Latin/Sancti/10-18.txt

The cookies are currently expressed in sort-of perl, as a sequence of 
equations.  It would be safer and more flexible to send a serialized hash.

Should
* use the source:tags directory
* update using svn export
* interact with a user to eyeball the changes
* not delete anything (?)
* somehow keep track of the current state
The goal is to make the current live site be based on a latest tag, but without 
having to download the entire site on every upgrade.

What steps will reproduce the problem?
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=10-3-2011&command=pr
ayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=

What is the expected output? What do you see instead?

The hymn at matins is the one for a virgin martyr. St. Thérése should 
obviously use the other hymn, which begins with the same words, but has 3 
strophes instead of 5.

Please provide any additional information below.

The fact that both hymns begin with the same words may be the problem, since 
divinum-officium often refers to hymns by their first words.

On third class feasts of Our Lady in the 1960 version, such as February 11, 
August 5, and September 12, the benedictions before the Matins lessons must be: 
Ille nos benedicat, Ipsa Virgo Virginum, and Ad Societatem.

What steps will reproduce the problem?
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=10-11-2011&command=p
rayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=

What is the expected output? What do you see instead?
In Responsory3, the the three responses should read "Speciosa facta es et 
suavis in deliciis tuis, sancta Dei Genetrix", according to the 1961 editio 
typica (p. 1218). The output differs in three respects: it has "est" in place 
of "es", it capitalizes "Sancta", and spells the last word "Genitrix." The 
latter two are questions of style, but I think it's better to conform to the 
ed. typica.

Please provide any additional information below.
The file is /trunk/web/www/horas/Latin/Sancti/10-11.txt

The file www/horas/Help/Rubrics/Notanda.txt was probably made by scanning: 
there are numerous typos of strange kinds.

The error of G for C seems common throughout the data.

Check and apply attached patches from Roberto Lionello 
<[email protected]> to Common 6.

Using the Tridentine 1910 calendar, on Semi-double feasts, the structure of 
Matins is completely wrong: there is a first Nocturn of 6 psalms followed by 3 
readings, then a second Nocturn of 2 psalms then 3 readings, and a third 
Nocturn of only 3 readings. I think that the structure here should be similar 
to a Double Feast with 3 Nocturns of 3 Psalms + 3 Readings each. It seems 
something has gone wrong with the algorithm at this point.

I defer to those more knowledgeable in Perl than myself, as trying to fix this 
issue caused today's meltdown:

I think it would be appropriate, given the fact that the 1962 edition is the 
editio typica of the Extraordinary Form, that when the site first opens, 
instead of defaulting to the "Divino Afflatu" version, that instead, it default 
to the "Rubrics 1960" edition.

Apply the attached patch from Roberto Lionello <[email protected]>

r117 fixed #39, but also converted the file 
(web/www/horas/Latin/Sancti/10-17.txt) to utf-8. If the edit was done with the 
Google Code website, this is why it was converted. Apparently loading the file 
into the editor converts it to utf-8 on the client side. If the changes are 
saved or a patch is submitted, the patch or new file includes conversion to 
utf-8.

The Common files (horas/Latin/Commune) are a visible place where accent and 
ligature characters should be added.

On the Sancta Missa page in general, the Confiteor should be printed twice, 
with the priest's and the server's Confiteor.

The second half of Psalm 2:1 should read "et populi meditati sunt inania". The 
"et" is missing. Both the online text of the Vulgate and the Seduni 2008 
printing of the breviary have it.

Matins for October 7 (1960 version) should have the hymn "In monte olívis 
cónsito". It appears properly in the English version but not the Latin. There 
are a few other typos that I am fixing.

Make all the text have Latin accents where required and ligatures (æ œ á é 
í ó ú) as required.

This is a big job. It would probably be possible to slurp a big liturgical 
Latin text from somewhere, and also use our Psalms repository, to get a 
dictionary of unaccented->accented transformations word by word, and then apply 
the substitutions automatically.

What steps will reproduce the problem?
http://divinumofficium.com/cgi-bin/horas/Pofficium.pl?date1=9-21-2011&command=pr
ayMatutinum&version=Rubrics%201960&testmode=regular&lang2=Latin&votive=

What is the expected output? What do you see instead?

1. In lectio 5, "regempatrem" (should be 2 words) and ", Matthaeum.," 
(incorrect) instead of "; Matthaeum,".
2. In the responsory after lectio 7, "in unes orbis terrae verba eorum" ("unes" 
should be "fines").

Please provide any additional information below.

In both cases, and perhaps in others as well, the correct text appears in 
horas/Latin/Sancti (but not SanctiM), in Laszlo's last release (July 9, 2011, 
see 
https://github.com/fiapps/officiumprog/blob/master/horas/Latin/Sancti/09-21.txt 
). However, your trunk does not seem to have this correction. Didn't you start 
with Laslzo's last release?

In the monastic office, per http://saintsshallarise.blogspot.com, the 
Athanasian Creed is only to be said on Trinity Sunday (as it is in the 1960 
office), and the Regula of St. Benedict should be there in its place.

on any page, the list of available languages appears at the bottom

the list is based on [languages] in horas.dialog

but it's checked against actually available languages in $datafolder and 
presented in readdir order, which is pretty much uncontrollable (depends on 
file system history).

should be alphabetical, or retain the order given in horas.dialog.

(noticed during cross-system regression testing)

probably applies to missa.dialog too.

Encode all the data in UTF-8 instead of Latin-1.

Offer format option : UTF-8 or ASCII. 
For ASCII, rewrite _all_ non-ASCII characters in all languages, and send 
charset=US-ASCII.
For UTF-8, send charset=UTF-8.

This is a fairly big job.

"Melchiades" should be genitive (-is), as in 12-10r.txt and 1961 ed. typica (p. 
900).

Vespers of Holy Saturday (in the 1955 and 1960 rubrics) should not have the 
Gloria Patri after the psalms.

I am working on Prayers.txt including the pater noster.

Do we want to use this issue tracker instead of Redmine?

Pro: it's here, it's integrated, it's easy to use, it's fast.

Con: it's feature-poor, it wouldn't have access to the work we've already done, 
it's completely public.

At the end of the first antiphon of Sunday Vespers, there should be a cross 
asterisk after the first line of the first psalm when the antiphon is "Dixit 
Dominus".

Apply the given patch for Common 10.