Comments (6)
It might not be a bad idea if we could program in the rules of concurrence and
occurrence for the 1960 rubrics.
Original comment by [email protected]
on 2 Oct 2011 at 1:18
from divinum-officium.
Original comment by [email protected]
on 2 Oct 2011 at 2:06
- Added labels: Component-Ordo
from divinum-officium.
Several bugs seem to be at work here, and fixing them is likely to have
unintended side-effects. I've created a branch called "precedence" for
experimental fixes.
The first revision in the branch, r76, fixes the Ember Day bug mentioned above,
but will require testing for unexpected effects elsewhere.
Original comment by igregord
on 8 Oct 2011 at 8:43
from divinum-officium.
Another such bug: With the Divino afflatu rubrics, feasts of the Lord should
take precedence over lesser Sundays. See, for example, 9-14-2008.
Original comment by igregord
on 11 Oct 2011 at 8:09
from divinum-officium.
The precedence branch now corrects all of the bugs mentioned above. I have
tested Matins and Vespers for the whole of 2008, and for some other small
intervals, with both the 1960 and Divino afflatu rubrics, and the only changes
to the offices were intentional. I'm happy to make any necessary further tests
before the branch is merged to trunk, however.
The last change to the branch, r113, splits the conditional for determining
whether the sanctoral or temporal office should take precedence into several
conditionals that set a flag as appropriate. It had become unwieldy with the
previous changes. Some of its logic was also redundant or incorrect, owing
either to recent changes or (presumably) to earlier changes by Laszlo himself.
The change makes the test more readable, but it is not terribly slick; I would
welcome any suggestions for a neater solution.
Below is a summary of the changes on the branch:
- Respect the request of callers to &monthday to retrieve the following day's
date (for Vespers and Compline of the following). Fixes the above Ember day
bug. (r76)
- Fixed concurrence of feasts with Sundays according to the 1960 rubrics:
second Vespers of a feast take precedence over first Vespers of a Sunday of
equal rank. Fixes the Transfiguration bug. (r78)
- Feasts of the Lord often take precedence over Sundays, with the rules varying
according to the set of rubrics. Fixes the Holy-Cross-day bug. (r102)
- Split up the conditional as noted above. (r113)
Original comment by igregord
on 16 Oct 2011 at 6:40
from divinum-officium.
Merged to trunk in r129.
Original comment by igregord
on 19 Oct 2011 at 8:06
- Changed state: Fixed
from divinum-officium.
Related Issues (20)
- epubgen2.sh broken
- More extra line breaks HOT 1
- Suggestion to delete stale branches from "reverts"
- Failed workflows HOT 1
- Spurious commemoratio of S. Venantius in 1st Vespers of Pentecost (Trid / DA)
- 'epubgen2.sh -m' doesn't generate Mass texts properly. HOT 1
- Collect of Trinity 5-25-2024 (DA and possibly other versions) HOT 2
- Emissa.pl doesn't handle `nofancychars`. HOT 3
- Proper Last Gospels not appearing among Propers HOT 1
- Vigil of St John the Baptist 2024 (DA) & other anticipated vigils which are not just commemorated HOT 9
- Votive Masses not working
- Martyrology problems (with 1960 rubrics) HOT 2
- The Capitular Office appears at Prime with the 1960 rubrics HOT 2
- Post Missam Error HOT 1
- Oremus should not precede orations in the office of Holy Saturday (1960 rubrics) HOT 1
- Double commemoration of St. Apollonia in English (1960 rubrics)
- "Dirígere et sanctificáre" conclusion in English when other languages selected
- 02-01-2025 1960 rubrics HOT 4
- No Credo on June 24 (DA and earlier)
- 06-23-2024: No commemoratio vigiliae on Sunday (rubrica 1960) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from divinum-officium.