Props to Scott Nix for this one. The index and follow tags output by Thematic should be removed because it is the browser default.

https://code.google.com/p/thematic/issues/detail?id=143

"Found a HTML validation error in thematic_postmeta_authorlink.
There is an extra closing span tag when creating the authorlink when it is not a link.
PS I only saw it because I validated an attachment page and thematic_is_custom_post_type() returns true on attachment pages. ", -middlesister

i think part of the reason this didn't get fixed, is that gene added on with something more complicated. let's fix this asap, and tackle the micro-formats in another issue.

move old callback to legacy.php, call it if thematic_is_xhtml()

As the title says, how should we go about handling doing a makeover on the styles (to make them responsive/fluid and avoid the use of @import and perhaps Superfish + the menu scripts altogether in favor of a pure CSS menu system?). One solution would be to add a hidable message for a couple of releases that instructs a user to install a Legacy Thematic plugin that contains the old styles and Superfish + menu scripts. Of course this will break their site but they would just have to change the url of their @imports in their child theme's style.css. We could post a sticky in the forums instructing them on this or something.

Let me know what you think,

James

P.S. On an unrelated matter, does Thematic use the default WP body classes? e.g. http://codex.wordpress.org/Function_Reference/body_class

https://code.google.com/p/thematic/issues/detail?id=143

""I think that is the tip of the iceberg here. Forgive me for hijacking the Issue but its easier than starting a new issue and merging this into it.

1. The micro formats are different "nickname" vs "n" between built-in post types and custom post types. The sad thing is I think that is my handiwork.
2. When the micro-formatted avatar & vcard display is activated for in the theme options for the author template it spits out a lot of empty markup if the author meta data has not been entered.

I've got a working copy of a patch that conditionally outputs the markup on the author template based on different variations of possible meta input but I'm thinking it may be better to put it all in a function. " --gene

maybe we can look at this AFTER we do the big translation overhaul.

can this be filtered to show a different sidebar so that if people want a custom sidebar on the "archive" template, they don't have to create a child archive.php they can filter thematic_sidebar. can we pass it a 2nd parameter?

Remove all widgets except the footer, primary, and secondary sidebar widgets. The rest can be optionally added via add_theme_support.

Proposed changes:

#wrapper    -> .site-wrapper
#header     -> .site-header
      #blog-title    -> .site-title
      #blog-description -> .tagline
#main        -> .main-content
      #container    -> .content-container
           #content    -> .site-content
           #primary    -> .primary-aside
           #secondary -> .secondary-aside
#footer       -> .site-footer

I am unsure which of #main and #content should become .site-content. Feedback welcome.
cc @scottnix @SeamlessThemes

Similary to twentythirteen and twentyfourteen
http://themes.trac.wordpress.org/browser/twentythirteen/1.1/inc/back-compat.php

Integrate breadcrumbs into the theme. Totally optional via add_theme_support. Hybrid Core has an extension that works as a standalone script. We can use that.

Proposal: sidebar-right, sidebar-left and fullwidth. Are people using a lot of 3-column layouts these days?

This bug can be seen with the built-in WP recent comment widget. Even with comment pagination turned off, permalinks look like this:

http://yoursite.com/archive-path/post-name/comment-page-1/

Should have a bookmark in the HTML at the end like this: "#post-1745”

See forums for background:
http://thematictheme.com/forums/topic/recent-comment-widget-problem/

Some of the divs in header.php / footer.php have filter callbacks allowing customisation - but some div's are unfiltered. Is there some policy decision... or it would be welcomed if I go through all files, add filters and submit a pull request for inclusion?

e.g

echo ( apply_filters( 'thematic_open_header', '

I'd like to see as little js a possible. I am willing to borrow heavily from twentytwelve and twentythirteen for this.

We can probably reserve the suckerfish scripts for the compatibility mode and retire them in html5.

cc @scottnix @SeamlessThemes @emhr

This one is large. Let's take it a file/section at a time, including checks for the backwards compatibility mode

• document head
• site header
• main content
• widgets and asides
• comments and discussion
• shortcodes
• theme options

running theme check:

RECOMMENDED: No reference to add_theme_support( 'custom-header', $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
RECOMMENDED: No reference to add_theme_support( 'custom-background', $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

should we continue to ignore these? i'm in favor of leaving them for the distant future... and/or child themes. thoughts?

choice beween

• genericons
• fontawesome
• entypo

My site's frontpage is static and a different page is used for posts. The page which has posts is displaying the same title tag as the frontpage, even though I chose to have a different one for this page.

Frontpage: http://test.oscarciutat.com/
Posts page: http://test.oscarciutat.com/blog/

Both pages are titled after the title of the site: TEST TEST. The posts page should display Blog in its title tag.

I'm using WP 3.4.1 with Thematic 1.0.2.1

Solution: add input#s{max-width:100%} to stylesheet.

Such a minor thing, but I will forget if I don't mark it down.

Original

if (function_exists('childtheme_override_category_archives'))  {
    /**
     * @ignore
     */
    function thematic_category_archives() {
        childtheme_override_category_archives();
    }
} else {
    /**
     * Display category archives
     *
     * Added to the archive list on the page template Archives Page
     *
     * Override: childtheme_override_category_archives
     */
    function thematic_category_archives() { ?>
                <li id="category-archives" class="content-column">
                    <h2><?php _e('Archives by Category', 'thematic') ?></h2>
                    <ul>
                        <?php wp_list_categories(array('optioncount' => true,
                                                        'feed' => 'RSS',
                                                        'title_li' => '',
                                                        'show_count' => true)); ?>
                    </ul>
                </li>
<?php }
} // end category_archives

add_action('thematic_archives', 'thematic_category_archives', 3);

The optioncount array value isn't an avalible parameter for wp_list_categories, does nothing different if you remove it or set it to false. ;P

http://codex.wordpress.org/Template_Tags/wp_list_categories
http://codex.wordpress.org/Function_Reference/wp_list_cats

Something like thematic_is_legacy() or thematic_is_xhtml()
Will be handy in places where we want to check the backwards compatibility mode

Where: in helpers.php

• #59 convert commentform to html5
• #50 update html ID's to classes
• convert to html5 markup -- [pull request #67]
• #60 convert comments callback to html5 -- [pull request #69 ]
• #51 add html5shiv for older browsers -- [pull request #68]
• #56 integrate with theme customizer
• #61 create a new stylesheet for the new markup
• add media queries to new stylesheet

Add the accessibility-ready theme tag by making sure the theme complies to the recommendations here: http://make.wordpress.org/themes/guidelines/guidelines-accessibility/

What is the recommended procedure for getting latest translation from Glotpress to repo - should I export it myself and create pull request... or is it done automatically at some point?

(fixed an earlier typo, actually some months ago already...)

First noticed in the "footer" widget areas, feel free to just drop the Monster Widget in one and you will see a few notices as you scroll down the output.

It appears to be related to the code found here: \library\extensions\widgets-extensions.php:281

Specifically with these lines:
// Remove WP default Widgets
// WP 2.8 function using $widget_class
unregister_widget( 'WP_Widget_Meta' );
unregister_widget( 'WP_Widget_Search' );

// Finished intializing Widgets plugin, now let's load the thematic default widgets
register_widget( 'Thematic_Widget_Search' );
register_widget( 'Thematic_Widget_Meta' );

Commenting out each of those unregister / register lines will remove the error messages but I have not delved further into the code to address that modifications deeper effects.

Keep original for reference and enqueue the minified.

file.css       <---- with plenty of comments
file.min.css   <------ enqueued file

finished Estonian (et) translation on http://translate.thematictheme.com/

now if somebody could get the strings out of "waiting" state I could presumably export the .po and start using it on master branch, thankyouverymany :-)

btw, there was one string with nothing but URL http://themeshaper.com - perhaps a mistake?

Hi there,

in library/languages/de_DE.po there are following two bugs:

Line 186: msgstr "<span class=\"meta-nav\">&laquo;</span> &Auml;ltere Beitr&aumlge"
needs to be
Line 186: msgstr "<span class=\"meta-nav\">&laquo;</span> &Auml;ltere Beitr&auml;ge"

and

Line 191: msgstr "Neuere Beitr&aumlge <span class=\"meta-nav\">&raquo;</span>"
needs to be
Line 191: msgstr "Neuere Beitr&auml;ge <span class=\"meta-nav\">&raquo;</span>"

In 2010 I created my Thematic child theme based on Thematic 0.9.6.2. During the years I updated from WP 2.9.2 to the current 3.8. Although not remembering I obviously updated the Thematic parent theme up to version 1.0.3.2, too, as I can see in my latest backup of the css-file. So far everything worked properly.

After updating to WP 3.8 "Parker" now I was suggested to update my Thematic parent theme as well, because I "seemed to run a child theme". So I did. Right after the updates still everything seemed to work properly. But one day later my horizontal menu did not work any more!

In my child theme I included some scripts in the horizontal menu. So hovering over the main menu items opens the submenu of the secondary pages below. Hovering over the secondary pages opens the menu of their child pages. Additionally the currently hovered item changes the color, so you always know, which page your click will open.

The occuring problems: After the update(s) none of the scripts seem to work any more.

a) Hovering over the main menu items still effects a color change of the currently hovered item. But after leaving the item the color does not switch back to the primary color or it takes a lot of time. So after hovering over all items of the usually black backgrounded horizontal menu the whole menu is light grey in the end. :-(

b) Much more important and really bad for my business: The sub menus are not shown any more! So it is impossible to read the child pages below the main items. Therefore visitors and potential customers miss a lot of important information about my company. (I did not link to the child pages on every page, because to keep them updated would cause a lot of effort. Therefore I have a custom menu with all pages and subpages, which is updated. This one is still shown. But I am not sure, if every visitor will notice it.)

Announcement, if neccessary: I am not sure, if this function belongs to Thematic itself or to my child, but hovering links in the text causes a change of the link background. This still works.

My questions:

Actually I am not sure, if the parent theme update, the WP update oder even something at my provider does cause the trouble. Most probably the theme does not work with WP 3.8. Bit I am kinda confused, because right after updating it seem to work. So be so kind togive me some ffeedback, what I can do n the meanwhile.

Thanx in advance!
Vita

@middlesister I think it is time they be put to rest. By the time 1.1 rolls out its safe to say enough time has elapsed to justify removing them, no?

Templates in question: archive.php and template-page-blog.php

ref: http://wordpress.org/support/topic/overriding-thematic_validate_opt-needlessly-hard

Since WordPress core has started doing this, I think it would be a good idea to follow suit. While it won't mitigate the need for filling out the docs site, it will help to clarify what things do to people that are looking at the source code. See http://make.wordpress.org/core/handbook/inline-documentation-standards/php-documentation-standards/#4-hooks-actions-and-filters

thematic_show_rss();
thematic_show_commentsrss();

both return broken feed links. i'm not sure why they use get_feed_link() instead of get_bloginfo() or if we stick with get_feed_link(), how to use it properly to return the correct links

obvi, we're deprecating that whole shebang, because we're eventually getting rid of the constant: THEMATIC_COMPATIBLE_FEEDLINKS

if we fix this and the span, we should probably push a mini-update.

from the forums:
"Since 1.0.2, both posts and comments RSS feeds in my sites are broken. For some reason, the suffix "rss2_url" gets added at the end of their URLs."

it's just a bit snappier right? and should minimal effort.

Totally optional via add_theme_support. Also see Hybrid Core for that. I do not like using a plugin for pagination.

Hi Gang!! Working on a client project, and I think there's a typo in the child theme's functions.php

`

headimg

`

I presume that should be #heading ?

Hope all is well w/ you! Happy 2013!

I have never noticed until now, but you have 3 options for content to display, full, excerpt and none.

The none option doesn't work. Test snippet.

// show nothing on post categories
function snix_thematic_content($content) {
    if ( is_category() ) {
        $content= 'none';
    }
    return $content;
}
add_filter('thematic_content', 'snix_thematic_content');

If you look in the function thematic_content(), it is there as an option, but produces an error.

Currently is, but doesn't work

elseif ( strtolower($thematic_content_length) == 'none') {
}

Fixed, works.

elseif ( strtolower($thematic_content_length) == 'none') {
    $post= '';
}

I didn't submit a pull request because I don't know if this is the best way to fix it, either way it currently isn't working. :P

Depends on #50

I like the strucure and TOC of twentythirteen

/**
 * Table of Contents:
 *
 * 1.0 - Reset
 * 2.0 - Repeatable Patterns
 * 3.0 - Basic Structure
 * 4.0 - Header
 *   4.1 - Site Header
 *   4.2 - Navigation
 * 5.0 - Content
 *   5.1 - Entry Header
 *   5.2 - Entry Meta
 *   5.3 - Entry Content
 *   5.4 - Galleries
 *   5.5 - Post Formats
 *   5.6 - Attachments
 *   5.7 - Post/Paging Navigation
 *   5.8 - Author Bio
 *   5.9 - Archives
 *   5.10 - Search Results/No posts
 *   5.11 - 404
 *   5.12 - Comments
 *   5.13 - Multisite
 * 6.0 - Sidebar
 *   6.1 - Widgets
 * 7.0 - Footer
 * 8.0 - Media Queries
 * 9.0 - Print
 */

I'd like to add a plugin-integration section for plugin styles like wp-pagenavi etc as well

Hi,

Maybe you already know about this issue, or not, because I see it has not been corrected already, or if it must stay like that you can remove this issue.

I have checked my theme with Theme Check plugin and it shows the following recommendations for thematic:

RECOMMENDED: get_theme_data found in the file functions.php. Deprecated since version 3.4. Use wp_get_theme() instead.
Line 88: $frameworkData = get_theme_data( get_template_directory() . '/style.css' );
Line 94: $childthemeData = get_theme_data( get_stylesheet_directory() . '/style.css' );
RECOMMENDED: get_current_theme found in the file theme-options.php. Deprecated since version 3.4. Use wp_get_theme() instead.
Line 257:

Thanks and good luck further

Totally love Thematic, but is it still being supported?

Other than the fact that it is 'open source' it seems to need a little refresh.

Mainly, it could use a little HTML5'ing (a la HTML5 Boilerplate) plus usage of classes instead of id's in the syntax & css.

I keep thinking of morphing it myself, but feel like an update may be out 'at any moment!' ...

Am I holding my breath for nothing?

Thanks!

Is this possible or will older sites get borked?

• Set postMessage transport on site title and tagline
• Add footer text section
• Create js file for customizer-admin
• Add created js file to customizer screen

The post class "is-full" is not properly displayed on single post views that have excerpts or more tags

Instead of id='thematic_style-css' it should be id='childthemename-style-css'

See https://github.com/justintadlock/hybrid-core/blob/master/functions/utility.php#L109 for how it's done