Code Monkey home page Code Monkey logo

Comments (4)

middlesister avatar middlesister commented on July 3, 2024

What is it that you are referring to here? Is it the name of the enqueued stylesheet?

Why would you want to change that to use the child theme name? The name comes from the handle used in wp_enqueque_scripts. The way it is now, if a child theme wants to remove the default styles completely it can dequeue the styleseheet using the handle thematic_style.

I think it would be confusing if they were to dequeue the parent stylesheet using a handle named childthemename-style. And then if a child theme tries to enqueue a stylesheet with the handle childthemename-style, it would not get used since the name would already be taken. So I am skeptic to the idea.

from thematic.

middlesister avatar middlesister commented on July 3, 2024

Ok I see where you are getting at. I activated the sample child theme and saw that the child stylesheet is enqueued with the handle of thematic_style. So you are right, it should be changed to childthemename-style. If we chose to go the same route regarding styles as we do now, as per the discussion started at #41

from thematic.

JamesGeiger avatar JamesGeiger commented on July 3, 2024

@middlesister see I am always right ;) haha jk

from thematic.

middlesister avatar middlesister commented on July 3, 2024

:)
This is the simple fix for the issue while the rest is waiting to be decided

from thematic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.