Comments (6)
I haven't looked into meta tags in a while, but if I remember correctly there is something wrong with every variation. I am curious, so I will also look into it too.
I will have to think about the other stuff. In my dream world I vote to drop all backwards compatibility and drop xhtml as even being supported... and uhm...anything else that will attract a higher caliber developer community to get interested in Thematic again.
from thematic.
Well dropping backwards support is not happening. Upgrading then could break thousands of sites.
But I hear you on the dev part. I am itching to put in grunt and sass and everything else. But you are using gulp are you not? Pros? Cons?
My ideal is to sassify the main stylesheet and use grunt to generate both expanded and minified stylesheets from that. And I wonder if it would be possible to wait with that until 2.1. If there would be any logical place for any css changes to happen then that is in 2.0, but I really really really want to get this release out the door by now.
But I am not really happy with the stylesheet. That's the one thing that makes me hesitate to launch. I feel it's a mashup and not really structured well. And since responsive styling is a feature of this release I think it just looks stupid to rearrange the code again in the next one.
from thematic.
The branch in #115 makes it so that upgrading child themes from 1.0.4 will only need to add
add_theme_support( 'thematic_html5' );
add_theme_support( 'thematic_responsive' );
to their functions.php to use the new features.
The main stylesheet gets enqueued by default in new installs. Any child theme that wants to roll its own styles will need to de-queue it.
from thematic.
hm, thinking more about it, I dislike the #115 approach. Better to educate beginners on how to enqueue the parent styesheet than forcing users to de-enqueue when they want use their own stylesheet. Enqueuing the parent stylesheet seems non-standard to me and could be confusing for the more tech-savvy crowd. Do you agree @scottnix?
WordPress 4.0 is slated for this week, I'd like to get Thematic ready this week or the next. Any remaining glitches can be dealt with in point releases.
from thematic.
Done. Child themes still need to enqueue parent stylesheet, meta viewport tag is only added in html5/responsive mode. This assumes html5 sites automatically are responsive, xhtml reponsive sites can use add_theme_support('thematic_meta_viewport').
from thematic.
Great enqueue is the way forward.
from thematic.
Related Issues (20)
- Breadcrumbs HOT 1
- Pagination HOT 1
- Remove obscure widgets HOT 1
- Child theme does not work properly after updating Thematic parent HOT 10
- cannot override thematic_validate_opt HOT 1
- Version 2.0 release checklist HOT 20
- Make sure the mobile menu toggle link is not displayed in legacy mode
- Remove the html5-shiv from legacy mode
- Remove postheader_posttitle "Permalink to" text from .entry-title HOT 5
- Move thematic.js enqueue HOT 7
- Fix browser body class issue (on Chrome iOS but potentially others)
- Any news for 2.0? HOT 4
- Develop Version Possible Bugs HOT 6
- do not save default settings to database
- use theme_support instead of checkbox for legacy mode
- Primary Menu not work after update wordpress to 4.1... HOT 1
- Search Placeholder Text
- Incompatibility with PHP 7.1
- Background Colour in Posts changed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thematic.