Comments (7)
It's easy enough to tack on the last #comment-ID bit, that was just an oversight. But I need to also make sure no comment-page is added to the permalink if you are not breaking the comments into pages.
Thanks for reporting.
from thematic.
Ok, I think I fixed it.
Please test the latest version from the master branch, either by pulling/cloning with git or use the master zipball download
from thematic.
Wow, awesome response time!
On Sep 3, 2012, at 12:53 PM, Karin Taliga [email protected] wrote:
Ok, I think I fixed it.
Please test the latest version from the master branch, either by pulling/cloning with git or use the master zipball download—
Reply to this email directly or view it on GitHub.
from thematic.
So it seems to be working now, although now the comment form compatibility with Jetpack seems to be broken:
define('THEMATIC_COMPATIBLE_COMMENT_FORM', true);
from thematic.
all those constants were deprecated.
from thematic.
How then can we use the Jetpack comment form?
Sent from my iPhone
On Sep 3, 2012, at 2:46 PM, helgatheviking [email protected] wrote:
all those constants were deprecated.
—
Reply to this email directly or view it on GitHub.
from thematic.
What is broken and in what way?
Using that constant made thematic render a completely own comment form. Without that constant thematic is calling the wordpress comment_form()
function with arguments, which means it's using core functionality instead of rolling its own. I would be surprised if the core functionality would clash with jetpack.
If you want to change the comment form you can use the filter thematic_comment_form_args
. And if you really really need the old form, you can put add_theme_support( 'thematic_legacy_comment_form' );
in your functions.php but I would say that's the last resort. It's not been removed, just deprecated.
Since this issue is closed maybe this question should be moved to the forums.
from thematic.
Related Issues (20)
- Remove postheader_posttitle "Permalink to" text from .entry-title HOT 5
- Move thematic.js enqueue HOT 7
- Fix browser body class issue (on Chrome iOS but potentially others)
- Any news for 2.0? HOT 4
- Develop Version Possible Bugs HOT 6
- do not save default settings to database
- use theme_support instead of checkbox for legacy mode
- add initial-scale=1 to meta viewport tag HOT 6
- Primary Menu not work after update wordpress to 4.1... HOT 1
- Search Placeholder Text
- Incompatibility with PHP 7.1
- Background Colour in Posts changed
- Breadcrumbs HOT 1
- Pagination HOT 1
- Remove obscure widgets HOT 1
- Child theme does not work properly after updating Thematic parent HOT 10
- cannot override thematic_validate_opt HOT 1
- Version 2.0 release checklist HOT 20
- Make sure the mobile menu toggle link is not displayed in legacy mode
- Remove the html5-shiv from legacy mode
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thematic.