get_permalink doesn’t return full permalinks about thematic HOT 7 CLOSED

It's easy enough to tack on the last #comment-ID bit, that was just an oversight. But I need to also make sure no comment-page is added to the permalink if you are not breaking the comments into pages.

Thanks for reporting.

from thematic.

Ok, I think I fixed it.
Please test the latest version from the master branch, either by pulling/cloning with git or use the master zipball download

from thematic.

Wow, awesome response time!

On Sep 3, 2012, at 12:53 PM, Karin Taliga [email protected] wrote:

Ok, I think I fixed it.
Please test the latest version from the master branch, either by pulling/cloning with git or use the master zipball download

—
Reply to this email directly or view it on GitHub.

from thematic.

So it seems to be working now, although now the comment form compatibility with Jetpack seems to be broken:

define('THEMATIC_COMPATIBLE_COMMENT_FORM', true);

from thematic.

all those constants were deprecated.

from thematic.

How then can we use the Jetpack comment form?

Sent from my iPhone

On Sep 3, 2012, at 2:46 PM, helgatheviking [email protected] wrote:

all those constants were deprecated.

—
Reply to this email directly or view it on GitHub.

from thematic.

What is broken and in what way?

Using that constant made thematic render a completely own comment form. Without that constant thematic is calling the wordpress comment_form() function with arguments, which means it's using core functionality instead of rolling its own. I would be surprised if the core functionality would clash with jetpack.

If you want to change the comment form you can use the filter thematic_comment_form_args. And if you really really need the old form, you can put add_theme_support( 'thematic_legacy_comment_form' ); in your functions.php but I would say that's the last resort. It's not been removed, just deprecated.

Since this issue is closed maybe this question should be moved to the forums.

from thematic.