I get this error, I moved my Windows repos to my Linux filesystem and Windows can still commit and pull just fine.

This is on Fedora 27, never tested on Arch Linux.

"The repository does not seem to exist anymore. You may not have access, or it may have been deleted or renamed"

My repo is "private", I pay monthly to use GitHub private repos. This means it may be a bug with that, also my other issue with links not appearing. It lacks permission to access these repos due to broken account settings in the client.

Normal repos work fine. I tested out sync.

Description

While on KDE I see the option "Open in GNOME Terminal" in the repository drop down menu.
Clicking on it results in a error in a popup window: "Cannot read property 'path' of undefined".
I can't see additional information in the developer console.

Version

• GitHub Desktop: 1.2.0
• Operating system: Fedora 28 KDE

Expected Behavior

Opens the system console in the git repository directory.

Actual Behavior

Error: "Cannot read property 'path' of undefined".

Logs

renderer.js:5 App ready time: 130.8272879999131ms
renderer.js:5 Load time: 1841.185415000189ms
renderer.js:5 Renderer ready time: 1177.47ms
renderer.js:12 launching: 1.2.0 (Linux 4.16.11-300.fc28.x86_64)
renderer.js:12 execPath: '/opt/GitHubDesktop/desktop'

A picture always self explanatory

It is a fresh installation of Debian, and a fresh installation of the last release (1.1.1) of GitHub Desktop for Linux.

Please refer to desktop#4625 for more details.

Description

So, first of all, I'm reporting this but it's really not a big deal. I'm also almost sure the problem is with Electron.

Setting the default dark theme on Fedora 27 makes the menu look black, and I'm not sure you're okey with this color 😄

Version

GitHub Desktop version: 1.0.11

OS version: Fedora 27 with GNOME

Steps to Reproduce

1. Set the theme to Adwaita-dark using GNOME tweaks
2. Open the app
3. See the menu

Expected behavior: The menu should be gray, I guess?
Actual behavior: They're too dark

Reproduces how often: 100%

This is not really a standard path on Debian/Ubuntu. I think it should just go under /usr/lib.

Fedora is broken when you pull, commit, or sync.
libcurl-gnutls.so.4

I read that you have to create a symbolic link since Fedora uses a different name.
ln -s libcurl.so.4.4.0 libcurl-gnutls.so.4
Although, this is old and won't work on the latest release of Fedora.

Description

When trying to use any of the built in git operatins (clone, fetch, etc), an error pops up saying that libcurl-gnutls.so.4 cannot be opened.

Version

GitHub Desktop version: 1.0.11

OS version: OpenSUSE Tumbleweed

Steps to Reproduce

Sign in
Try to clone a repo or use the fetch option on a local repo
See error that libcurl-gnutls.so.4 is missing.

Expected behavior: git operations should work

Actual behavior: Error displayed about missing libcurl-gnutls.so.4

Reproduces how often: 100%

Logs

/tmp/.mount_githubbZudXq/app/resources/app/git/libexec/git-core/git-remote-https: error while loading shared libraries: libcurl-gnutls.so.4: cannot open shared object file: No such file or directory

Adding private repositories are added as "Other" and not GitHub.

This is follow up to desktop#3568.

With 1.0.12 Linux RC1.

I cleared all my databases as instructed. I am not getting anymore any visible error in UI, but just private repositories are not recognized as GitHub repositories. I can still pull and push normally (probably because it goes over SSH).

Version

• GitHub Desktop:

• Operating system: Ubuntu 18.04.1

Steps to Reproduce

Expected Behavior

Description

Version

GitHub Desktop version: 4f17723

OS version: Ubuntu 16.04

Steps to Reproduce

1. git clone from desktop/desktop
2. Follow the installation instructions
3. Run yarn, yarn build:dev, yarn start

Expected behavior:

When starting the app, I expect to see no errors in the console.

Actual behavior:

Starting the app shows this error in the console:

info: [ui] launching: 1.0.12-beta0 (Linux 4.4.0-103-generic)
Failed to read content scripts { Error: EACCES: permission denied, open '/home/fernando/.config/GitHub Desktop-dev/extensions/fmkadmapgofadopljbjfkapdkoienihi/build/inject.js'
    at Object.fs.openSync (fs.js:584:18)
    at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:173:20)
    at Object.fs.readFileSync (fs.js:491:33)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:505:29)
    at readArrayOfFiles (/home/fernando/workspace/picandocodigo/desktop_source/dist/desktop-linux-x64/resources/electron.asar/browser/chrome-extension.js:235:23)
    at Array.map (native)
    at contentScriptToEntry (/home/fernando/workspace/picandocodigo/desktop_source/dist/desktop-linux-x64/resources/electron.asar/browser/chrome-extension.js:242:21)
    at Array.map (native)
    at injectContentScripts (/home/fernando/workspace/picandocodigo/desktop_source/dist/desktop-linux-x64/resources/electron.asar/browser/chrome-extension.js:250:48)
    at loadExtension (/home/fernando/workspace/picandocodigo/desktop_source/dist/desktop-linux-x64/resources/electron.asar/browser/chrome-extension.js:279:3)
  errno: -13,
  code: 'EACCES',
  syscall: 'open',
  path: '/home/fernando/.config/GitHub Desktop-dev/extensions/fmkadmapgofadopljbjfkapdkoienihi/build/inject.js' }

Also, if I cd into ~/.config/GitHub Desktop-dev/extensions/fmkadmapgofadopljbjfkapdkoienihi I can see an issue with installed files:

$ ls -la build/
ls: cannot access 'build/contentScript.js': Permission denied
ls: cannot access 'build/..': Permission denied
ls: cannot access 'build/panel.js': Permission denied
ls: cannot access 'build/background.js': Permission denied
ls: cannot access 'build/main.js': Permission denied
ls: cannot access 'build/inject.js': Permission denied
ls: cannot access 'build/backend.js': Permission denied
ls: cannot access 'build/.': Permission denied
total 0
d????????? ? ? ? ?            ? .
d????????? ? ? ? ?            ? ..
-????????? ? ? ? ?            ? backend.js
-????????? ? ? ? ?            ? background.js
-????????? ? ? ? ?            ? contentScript.js
-????????? ? ? ? ?            ? inject.js
-????????? ? ? ? ?            ? main.js
-????????? ? ? ? ?            ? panel.js

Reproduces how often: 100%

Logs

fernando@cultivate-xps ~/.config/GitHub Desktop-dev/logs 10:08:08
$ cat 2017-12-14.desktop.development.log 
2017-12-14T09:57:24.735Z - info: [ui] [AppStore] loading 0 repositories from store
2017-12-14T09:57:24.770Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:24.779Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:24.944Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:25.029Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:25.126Z - info: [ui] launching: 1.0.12-beta0 (Linux 4.4.0-103-generic)
2017-12-14T09:57:25.224Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:27.435Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:32.655Z - info: [ui] [Welcome] advancing to step: SignInToDotCom
2017-12-14T09:57:32.662Z - info: [ui] [Welcome] current sign in state not found. ignoring...
2017-12-14T09:57:37.609Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2017-12-14T09:57:38.426Z - info: [ui] [AppStore] adding account picandocodigo (Fernando Briano) to store
2017-12-14T09:57:38.436Z - info: [ui] [Welcome] advancing to step: ConfigureGit
2017-12-14T09:57:38.604Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:38.665Z - info: [ui] [Welcome] no sign in step found. ignoring...
2017-12-14T09:57:46.904Z - info: [ui] [Welcome] advancing to step: UsageOptOut

Additional Information

I searched for this error and it seems related to electron.

• LN-Zap/zap-desktop fixed it here
• MarshallOfSound/electron-devtools-installer here

Description

When prompted to sign in to the app, the "Sign in using your browser" option doesn't work.

Version

GitHub Desktop version: 1.0.11

OS version: Ubuntu 16.04.3

Steps to Reproduce

1. Launch the app for the first time
2. Press buttons until you can choose to sign in in a browser, and do so
3. Go through the OAuth prompts
4. Finish the OAuth prompts, and the redirect to the app doesn't work – you get prompted (by Chrome) to open xdg-open, but the webpage doesn't close, and the GitHub app just sits there with the loading spinner until you press Cancel.

Expected behavior: Signing in through a browser should work

Actual behavior: The redirect back to the app doesn't work

Reproduces how often: Presumably always, at least when using the AppImage

Logs

Can't find these on Linux, will happily provide if someone tells me where they are

Additional Information

Description

I cannot clone my repositories, when I attempt to do so I get an error about libcurl.so.4: cannot open shared object file: no such file or directory

Version

• GitHub Desktop: 1.4.0-linux2 (also happened on 1.3.x and earlier) snap

• Operating system: Ubuntu 16.04 with Xfce 4.12

Steps to Reproduce

1. Open GitHub desktop on Ubuntu 16.04 Xfce 4.12
2. Click clone repository
3. Pick a repository to clone then click clone repository

Expected Behavior

I expect it to clone the repository

Actual Behavior

I get an error about libcurl.so.4: cannot open shared object file: no such file or directory

Here is a screenshot of the error:

This is a duplicate of desktop#5606, as requested here.

Description

Can't login to GitHub using the snap version of GitHub Desktop.

Version

$ snap info github-desktop 
name:      github-desktop
summary:   Extend your GitHub workflow beyond your browser with GitHub Desktop
publisher: Snapcrafters
contact:   https://github.com/snapcrafters/github-desktop/issues
license:   unset
description: |
  Extend your GitHub workflow beyond your browser with our Desktop,
  completely redesigned with Electron. Get a unified cross-platform
  experience that's completely open source and ready to customize.
commands:
  - github-desktop
snap-id:      vxuDrMy9vuqIU5Abf2MQOowf2e09tcm9
tracking:     edge
refresh-date: today at 15:50 EDT
channels:                     
  stable:    –                
  candidate: –                
  beta:      –                
  edge:      1.3.4 (31) 140MB -
installed:   1.3.4 (31) 140MB -

* Operating system:

$ neofetch --off
nato@HelionUbuntu 
----------------- 
OS: Ubuntu 18.04.1 LTS x86_64 
Kernel: 4.15.0-34-generic 
Uptime: 4 hours, 44 mins 
Packages: 2148 
Shell: bash 4.4.19 
Resolution: 1920x1080 
DE: GNOME 3.28.3 
WM: GNOME Shell 
WM Theme: Adwaita 
Theme: Adwaita-dark [GTK2/3] 
Icons: Ubuntu-mono-dark [GTK2/3] 
Terminal: gnome-terminal 
CPU: Intel i5-3570K (4) @ 4.100GHz 
GPU: NVIDIA GeForce GTX 660 Ti 
Memory: 6003MiB / 7922MiB 

Steps to Reproduce

1. `sudo snap install github-desktop --edge`

2. Open GitHub Desktop. It takes a while the first time.

3. Login

Expected Behavior

The login completes successfully.

Actual Behavior

The login fails with the following message : An AppArmor policy prevents this sender from sending this message to this recipient; type="method_call", sender=":1.291" (uid=1000 pid=22162 comm="/snap/github-desktop/31/opt/GitHubDesktop/desktop " label="snap.github-desktop.github-desktop (enforce)") interface="org.freedesktop.Secret.Service" member="OpenSession" error name="(unset)" requested_reply="0" destination=":1.20" (uid=1000 pid=1732 comm="/usr/bin/gnome-keyring-daemon --daemonize --login " label="unconfined").

Additional Information

I believe it's because of an undeclared capability in the app. It should be as simple as modifying the package.json file by adding an interface.

Logs

... and I noticed I reported at the wrong place. There's already snapcrafters/github-desktop#9.

Edit

Solution :

sudo snap connect github-desktop:password-manager-service

Is your feature request related to a problem? Please describe.
Right click on icon in taskbar, and select add to favorites to keep the icon there

Description

just installed the .deb version from https://github.com/shiftkey/desktop/releases/tag/release-1.0.11 it installed fine but fails to log in to my github account consistently, and shows the error

then I tried the "Sign in using you browser" but that also fails and shows

Version

GitHub Desktop version: 1.0.11

OS version:

Steps to Reproduce

1. install
2. try to login
3. fail to login

Expected behavior: log in somehow
Actual behavior: doesn't log in

Reproduces how often: 100%

Logs

couldn't find logs in ~/GitHub Desktop which is where I expected them to be. so these are the logs in the devtools

and judging from the network tab, it seems i was successfully authenticated by the server

Additional Information

if there more information needed about the environment feel free to let me know

Description

I am unsure on how to use the Github Desktop internal Git in terminal with the folder scope.

Version

• GitHub Desktop: 1.1.1

• Operating system: Ubuntu 17.10

Steps to Reproduce

1. Open GitHub Desktop with some repo
2. Click on Repository -> Open in GNOME Terminal
3. Type git

Expected Behavior

I expected it to work with GitHub Desktop's internal git, like in Windows.

Actual Behavior

The system asks me to install Git separately, therefore I would have to create a duplicate clone just to use terminal commands.

Additional Information

I am not sure what is the app's launchable name, so I wasn't able to try that. It certainly wasn't github (from #32).

Description

Can't find Github Desktop directory under $HOME/.config/.
But I can find them when I tried to install the AppImage one.

Version

• GitHub Desktop: 1.4.2 Linux RC1
• Operating system:
  Distributor ID: Ubuntu
  Description: Ubuntu 18.04.1 LTS
  Release: 18.04
  Codename: bionic

Description

The app icon is missing in some places:

I'm using the Appimage. I think that's the problem, because I have the exact same problem with NoSQLBooster and they're using Appimages too.

Version

GitHub Desktop version: 1.0.11
OS version: Fedora 27 with GNOME

Steps to Reproduce

1. Launch the app
2. Observe the icon is missing

Expected behavior: The icon is present

Actual behavior: The icon is not present

Reproduces how often: 100%

I got here because I saw a reference that said there were some packages to install github desktop on Linux (ubuntu 18.04 for me).

For the life of me I see not a single reference to instructions about how to install this...

Please, somebody, point me in the right direction...

Thank you,
Chris.

Description

I'm not able to clone a repository with the app installed via rpm:

/opt/GitHubDesktop/resources/app/git/libexec/git-core/git-remote-https: error while loading shared libraries: libcurl-gnutls.so.4: cannot open shared object file: No such file or directory

Version

GitHub Desktop version: 1.0.12-linux1

OS version: Fedora 27

Steps to Reproduce

1. Try to clone something

Description

After merging a pull request, it is still shown in the pull requests list. I cannot confirm at the moment, but I do not believe that new PRs are shown. This is not specific to a single installation, as I see the same thing on my Fedora laptop.

The specific PR is shgysk8zer0/awesome-rss#64

I will be updating the issue soon with observations of my next PR.

Update:

After opening another pull request, I noticed that the merged PR had vanished and the new PR was visible. After merging, the now closed PR was still listed in the Pull requests tab.

I also noticed that the PR listed on my Fedora laptop was different from what was shown currently and initially on my Ubuntu desktop. The laptop was not on when the PR was created and merged.

My best guess is that PR data is only being updated if there is an open PR, and any closed / merged PRs are being ignored. This would cause the differences between laptop and desktop and also explain why merging PRs does not cause the PR tab to update. If my assumption is correct, having an un-merged / open PR is does trigger an update to the PR tab, which is why the old PR disappeared on desktop, but not on the laptop (GitHub app was not opened until after the merge).

Version

GitHub Desktop version: 1.1.0

OS version: Ubuntu 17.10 (.deb), Fedora 27 (.rpm)

Steps to Reproduce

1. Go to Branch -> Create pull request
2. Create PR in browser
3. Merge PR
4. View Pull request in branch tab
5. Wait several days and repeat previous step with same results

Expected behavior: Merged/closed pull requests should not be shown

Actual behavior: At least one merged pull request is still visible

Reproduces how often: Unknown. Happened once

Logs

Logs contain no info that seems to relate. But, the ISSUE_TEMPALTE should be updated to say that the logs directory can be found using Help -> Show logs in your File Manager, which opens ~/.config/GitHub Desktop/logs/

Additional Information

I use [email protected]... for remotes, but the open PR remains even after deleting/removing and cloning again from https://...

Summary of the issue: Going to "About GitHub Desktop" throws an error message regarding update checking.

Description:

An error message appears saying "Couldn't determine the last time an update check was performed. You may be running an old version. Please try manually checking for updates and contact GitHub Support if the problem persists. "

GitHub Desktop Version: 1.0.11 RC1 for Linux

OS Version: Ubuntu 17.10 with the latest updates installed.

Steps to Reproduce

1. Open GitHub Desktop app
2. Click on "Help" and "About GitHub Desktop".

Expected behavior: Show that it's the latest version.

Actual behavior: Error message suggesting it's an outdated version.

Reproduces how often: 100% of the time.

Description

Version

• GitHub Desktop: 1.4.2 Linux RC1

• Operating system:

No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.1 LTS
Release: 18.04
Codename: bionic

Steps to Reproduce

1. Run $ sudo snap install GitHubDesktop-linux-amd64-1.4.2-linux1.snap --dangerous --classic
2. Click the icon in the launcher, nothing happens
3. Run $ /snap/bin/desktop, output shows:

cp: '/home/ying/.config/user-dirs.locale' and '/home/ying/.config/user-dirs.locale' are the same file
/snap/desktop/x1/app/desktop: error while loading shared libraries: libgconf-2.so.4: cannot open shared object file: No such file or directory

How many official distro should we support ?

I think it should be AppImage, deb and rpm. Keep too many maybe a tedious job.

Easy way to build linux distro

I think we can give docker a try, since it can build many format linux supported, see linux part in this page https://www.electron.build/multi-platform-build. Docker, in many way, make everyone's life easier.

Auto update

Turn on auto-update for AppImage, this will be much convenient.

I generally use most programs with the top menu bar to be hidden to maximize screen space until I actually need it, in which case I press Alt to reveal it. This behaviour is available in other Electron apps (namely Atom) so should be easy enough to implement in this as well

Description

Installed 1.4.2 Linux RC1 in Ubuntu 16.04.5 LTS. Doing Enterprise login, OAuth fails with 404 error. The same procedure fine when tried with latest Windows client

Version

• GitHub Desktop: 1.4.2 Linux RC1

• Operating system:Ubuntu 16.04.5 LTS

Steps to Reproduce

1. Launch desktop in Ubuntu 16.04.5 LTS
2. Click File->Options->Accounts->Enterprise Signin
3. Enter Enterprise URL
4. Click on 'Sign In'
5. Enterprise URL

Expected Behavior

OAuth to succeed and Desktop able to list repositories.

Actual Behavior

404 Page when redirected for OAuth. The same steps works correctly from windows version.

Additional Information

Logs

I do not know where to look for linux logs.

Description

Installed from last version of ".dep" packages on Ubuntu 14.04 LTS and GUI is not shown at all when application launched. If I kill the process of desktop a then try to launch with "desktop" command from terminal then I get following output:

xdg-settings: unexpected/missing argument
Try 'xdg-settings --help' for more information.
xdg-settings: unexpected/missing argument
Try 'xdg-settings --help' for more information.

If I try to launch dektop again it shows empty GUI window.

Version

• GitHub Desktop:
  GitHubDesktop v.1.2.3, v.1.2.0
• Operating system:
  Ubuntu 14.04.05 LTS

Steps to Reproduce

1. Launch desktop
2. No GUI
3. Launch desktop again
4. Window of desktop is shown but it's blank.

Expected Behavior

GUI is shown correctly

Actual Behavior

GUI is not shown or is empty window

Additional Information

I used one of the first versions like 1.0.something and it worked like charm.

Logs

IDK where are logs for Ubuntu

The application shortcut /usr/share/applications/desktop.desktop is in conflict with /usr/share/kservices5/desktop.desktop therefore kcmshell5 desktop can not run anymore and KDE Virtual Desktop settings become inaccessible and no more listed in the KDE System Settings

Quick solution : rename or delete /usr/share/applications/desktop.desktop

Durable solution : renamed desktop.desktop

I guess that some users went nuts why virtual desktop settings wont open lol

could you please create a package in aur that people who are working with yaourt package manager can install and update it automatically?

there is already a package for this but its version is old

https://aur.archlinux.org

Summary: Users are unable to clone repositories from the organization(s) the user is part of in the cloning repositories menu.

GitHub Desktop Version: 1.0.11 RC1 for Linux

OS Version: Ubuntu 17.10 with latest updates.

Steps to Reproduce

1. Open GitHub Desktop App
2. Click on "File" and "Clone Repository.
3. Look through repository list under GitHub.com

Expected behavior: Show repositories from organizations that the user is part of.

Actual behavior: Shows only repositories that belong to the user.

Reproduces how often: Every time.

Description

I believe the minimum height is too large for my setup and causes the GitHub Desktop to open up with maximum height on the wrong monitor.

Version

• GitHub Desktop: 1.4.0-linux2 (also happened on 1.3.x and earlier) snap

• Operating system: Ubuntu 16.04 with Xfce 4.12

Steps to Reproduce

1. Open GitHub desktop on Ubuntu 16.04 Xfce 4.12 with a 768p screen with a 48 pixel tall bottom panel/bar/dock and a 30 pixel tall top panel/bar/dock (whatever you want to call it)
2. It now opens on my second monitor (a 1080p screen)

Expected Behavior

I expect it to open minimum size for height and width as it does on two 1080p monitors.

Actual Behavior

The minimum height of GitHub desktop is too large. Is there any way to decrease the minimum height - even if just for the Linux port, or maybe upstream? Or, perhaps fixing it so that it opens with the correct minimum height on my second monitor? I am not sure if this issue belongs upstream or in the Linux port.

Keep in mind, when I launch GitHub desktop with my mouse on my second (1080p) screen, the minimum height and width are what they should be - it is only when I keep my mouse on my primary (768p) screen that the height becomes maximum.

Sorry for my very strange use-case, but, these things happen in life.

Here are some (horizontally cropped to redact info) pictures that show what I am talking about.

Here is an example of the issue I am talking about:

Here is what it should look like:

Notice the 713px height instead of the 1080px height.

ubuntu 18.04 many app support suppot libcurl4
if i replace libcurl4 to libcurl3 many app to be remove

Description

When opening github desktop from the terminal on osx like this: github A_REPO_PATH it opens the app with either

• That directory open (if already added)
• The "add local repository" popup open and filled in.

This is useful when working primarily from the command line.

The linux version so far doesn't seem to support this, I think it's just a matter of passing along command line parameters.

Version

GitHub Desktop version: GitHubDesktop-linux-x86_64-1.1.0.AppImage

OS version: Ubuntu 16.04

Using 1.0.12 Linux RC1 .deb file. You can see in the DEBIAN/control file inside it that package is still named desktop and not github-desktop or something like that. I think this name is way to generic to be useful as a package name.

(I have no idea where to ask this, so here it goes :-) probably something silly and I'm being blind...)

I've been trying to set up a development environment on my linux machine. Although it okay for the most part, I can't make it run smoothly. A summary of what I tried when following the documentation:

• yarn test fails integration test
• yarn start displays app, but becomes unresponsive after a few seconds
• yarn build package fails.

Branches tried (shiftkey/desktop):

• master
• tags/release-1.3.5 (release runs fine on ubuntu 18.04)

OS is Linux Mint 19 Tara (same packages from Ubuntu 18.04) with 4.15 stable kernel:

$ lsb_release -a
No LSB modules are available.
Distributor ID:	LinuxMint
Description:	Linux Mint 19 Tara
Release:	19
Codename:	tara
$ uname -a
Linux HOSTNAME 4.15.0-34-generic #37-Ubuntu SMP Mon Aug 27 15:21:48 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Versions seem fine; installed yarn using the native installer:

$ yarn -v
1.9.4
$ whereis yarn
yarn: /usr/bin/yarn /usr/share/yarn
$ npm -v
6.4.1
$ node -v
v8.12.0

yarn and yarn build:dev run fine:

$ git clone https://github.com/shiftkey/desktop.git desktop-linux && cd desktop-linux
$ yarn
(...)
Done in 98.54s
$ yarn build:dev
(...)
Done in 220.46s

• Integration test fails -- doesn't pass opens a window on launch.

$ yarn test
  yarn run v1.9.4
  $ yarn test:unit --runInBand && yarn test:script && yarn test:integration
  $ cross-env ELECTRON_RUN_AS_NODE=1 node_modules/.bin/electron ./node_modules/jest/bin/jest --detectOpenHandles --silent --config ./jest.config.js --runInBand
   (...)
  Test Suites: 68 passed, 68 total
  Tests:       2 skipped, 553 passed, 555 total
  Snapshots:   0 total
  Time:        127.361s, estimated 219s
  $ mocha -P ./tsonfig.json -t 10000 --require ts-node/register script/changelog/test/*.ts
  (...)
  5 passing (27ms)
  $ cross-env TEST_ENV=1 ELECTRON_NO_ATTACH_CONSOLE=1 xvfb-maybe --auto-servernum -- mocha -t 30000 --require ts-node/register app/test/integration/*.ts
  
    App
      1) opens a window on launch
  
    0 passing (7s)
    1 failing
  
    1) App
         opens a window on launch:
       Error: Invalid Chai property: browserWindow
        at Object.proxyGetter [as get] (node_modules/chai/lib/chai/utils/proxify.js:66:17)
        at Context.<anonymous> (app/test/integration/launch-test.ts:39:13)
        at <anonymous>
        at process._tickDomainCallback (internal/process/next_tick.js:229:7)
  
  Failed with exit code: 1
  Output:
  
  error Command failed with exit code 255.
  info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Launching with yarn start opens a window with the developer console on the right. I can click and do stuff... However, it becomes unresponsive after a 2-5 seconds (can't click on anything; no keyboard shortcuts; nothing).

Trying to pack and run unmodified also results in error. (git checkout tags/release-1.3.5 && yarn build:prod && yarn build package)

$ yarn build package
yarn run v1.9.4
$ /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/.bin/build package
  • electron-builder version=20.27.1
  • writing effective config file=dist/builder-effective-config.yaml
  • rebuilding native production dependencies platform=linux arch=x64
  • rebuilding native dependency name=keytar
  • rebuilding native dependency name=registry-js
  • rebuilding native dependency name=runas
  • packaging       platform=linux arch=x64 electron=2.0.5 appOutDir=dist/linux-unpacked
Error: Application entry file "main.js" in the "/home/joaomlneto/Documents/GitHub/shiftkey/dist/linux-unpacked/resources/app.asar" does not exist. Seems like a wrong configuration.
    at error (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/asar/asarFileChecker.ts:7:12)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/asar/asarFileChecker.ts:33:11
    at Generator.next (<anonymous>)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/graceful-fs/polyfills.js:287:18
    at FSReqWrap.oncomplete (fs.js:153:5)
From previous event:
    at checkFileInArchive (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/out/asar/asarFileChecker.js:78:17)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:390:13
    at Generator.next (<anonymous>)
From previous event:
    at LinuxPackager.checkFileInPackage (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:387:110)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:439:16
    at Generator.next (<anonymous>)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/graceful-fs/polyfills.js:287:18
    at FSReqWrap.oncomplete (fs.js:153:5)
From previous event:
    at LinuxPackager.sanityCheckPackage (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:426:70)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:231:16
    at Generator.next (<anonymous>)
    at runCallback (timers.js:810:20)
    at tryOnImmediate (timers.js:768:5)
    at processImmediate [as _immediateCallback] (timers.js:745:5)
From previous event:
    at LinuxPackager.doPack (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:157:165)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:112:16
    at Generator.next (<anonymous>)
From previous event:
    at LinuxPackager.pack (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/platformPackager.ts:110:95)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/packager.ts:376:24
    at Generator.next (<anonymous>)
    at xfs.stat (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/fs-extra-p/node_modules/fs-extra/lib/mkdirs/mkdirs.js:56:16)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/graceful-fs/polyfills.js:287:18
    at FSReqWrap.oncomplete (fs.js:153:5)
From previous event:
    at Packager.doBuild (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/packager.ts:344:39)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/packager.ts:314:57
    at Generator.next (<anonymous>)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/graceful-fs/graceful-fs.js:99:16
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/graceful-fs/graceful-fs.js:43:10
    at FSReqWrap.oncomplete (fs.js:135:15)
From previous event:
    at Packager._build (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/packager.ts:285:133)
    at /home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/packager.ts:281:23
    at Generator.next (<anonymous>)
    at runCallback (timers.js:810:20)
    at tryOnImmediate (timers.js:768:5)
    at processImmediate [as _immediateCallback] (timers.js:745:5)
From previous event:
    at Packager.build (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/packager.ts:238:14)
    at build (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/app-builder-lib/src/index.ts:58:28)
    at build (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/electron-builder/src/builder.ts:227:10)
    at then (/home/joaomlneto/Documents/GitHub/shiftkey/node_modules/electron-builder/src/cli/cli.ts:42:48)
    at <anonymous>
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Issue: I don't know if this is intentional or not but the GitHub Desktop App icon is not shown. And the icon shown for when a window does open is weird looking.

The GitHub Desktop window which is open is the one with the red stop/close thing in the icon. And the one on the left of the screenshot tool is the GitHub Desktop App icon although as you can no doubt see, it is not the real GitHub Desktop icon.

GitHub Desktop Version: 1.0.11 RC1 for Linux

OS version: Ubuntu 17.10 with latest updates.

Steps to Reproduce

1. Pin GitHub Desktop App to favorites/taskbar
2. Launch GitHub Desktop App

Expected behavior: Official GitHub Desktop app icon to be used in taskbar/favorites and to create a window with that icon.

Actual behavior: A generic app icon was used in taskbar/favorites and it created a window a weird icon.

Reproduces how often: [Every Time

Description

I can't install the .deb package. Seems like broken dependencies on Ubuntu.

Version

• GitHub Desktop: 1.4.0 Linux RC

• Operating system: Ubuntu 18.04 LTS (Minimal Install)

Steps to Reproduce

1. sudo dpkg -i GitHubDesktop-linux-amd64-1.4.0.deb

Preparing to unpack GitHubDesktop-linux-amd64-1.4.0.deb ...
Unpacking desktop (1.4.0) ...
dpkg: dependency problems prevent configuration of desktop:
 desktop depends on libcurl3; however:
  Package libcurl3 is not installed.

dpkg: error processing package desktop (--install):
 dependency problems - leaving unconfigured
Processing triggers for hicolor-icon-theme (0.17-2) ...
Processing triggers for gnome-menus (3.13.3-11ubuntu1.1) ...
Processing triggers for desktop-file-utils (0.23-1ubuntu3.18.04.1) ...
Processing triggers for mime-support (3.60ubuntu1) ...
Errors were encountered while processing:
 desktop

2. sudo apt install libcurl3

You might want to run 'apt --fix-broken install' to correct these.
The following packages have unmet dependencies:
 libcurl3 : Conflicts: libcurl4 but 7.58.0-2ubuntu3.2 is to be installed
 libcurl4 : Conflicts: libcurl3 but 7.58.0-2ubuntu2 is to be installed
E: Unmet dependencies. Try 'apt --fix-broken install' with no packages (or specify a solution).

3. sudo apt install --fix-broken

The following packages will be REMOVED:
  desktop
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
1 not fully installed or removed.

4. Repeat

Expected Behavior

The program should install.

Actual Behavior

It doesn't install, and attempting to fix the dependencies sends the user in circles.

Additional Information

The GitHub Desktop 1.3.5 Linux RC installs just fine, and the 1.4.0 Linux RC AppImage runs fine.

The Github.com links don't show. I am using Fedora 27.

Description

The New branch button text in the branch switcher is wrapped, causing it to flow outside the bounds of the button

The button text was updated in 1.1.0 in desktop#4032 and I thought we fixed the wrapping after it was first spotted here desktop#4032 (comment)

Version

• GitHub Desktop: 1.1.1
• Operating system: Ubuntu 16.04

Steps to Reproduce

1. Launch the application
2. Add an existing repository to the application
3. Open the branch switcher to switch to a different branch

Expected Behavior

New branch text is on one line

Actual Behavior

New branch text is wrapped on two lines

Additional Information

N/A

Logs

N/A

I noticed while installing the .deb on my computer, that the package name in the .deb file was desktop.

You should probably rename the package to something like github-desktop.

Description

After authenticating with my account GithubDesktop app shows an empty repo list.

Version

• GitHub Desktop: 1.1.1

• Operating system: kubuntu 18.04

Steps to Reproduce

1. Open app
2. add your account
3. See empty repo list instead of actual repo list.

Expected Behavior

See my repos.

Actual Behavior

Empty repo list.

Additional Information

Logs

2018-05-11T06:04:54.870Z - info: [ui] [AppStore] loading 0 repositories from store
2018-05-11T06:04:54.882Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:04:54.882Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:04:54.941Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:04:55.042Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:04:55.058Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:04:55.090Z - info: [ui] launching: 1.1.1 (Linux 4.15.0-20-generic)
2018-05-11T06:04:55.091Z - info: [ui] execPath: '/opt/GitHubDesktop/desktop'
2018-05-11T06:04:55.109Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:04:55.149Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:05:00.059Z - info: [ui] [Welcome] advancing to step: SignInToDotCom
2018-05-11T06:05:00.061Z - info: [ui] [Welcome] current sign in state not found. ignoring...
2018-05-11T06:05:27.452Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2018-05-11T06:05:27.894Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2018-05-11T06:05:39.847Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2018-05-11T06:05:40.040Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2018-05-11T06:05:43.884Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2018-05-11T06:06:04.349Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2018-05-11T06:06:12.468Z - info: [ui] [Welcome] kind Authentication is the same as Authentication. ignoring...
2018-05-11T06:06:13.060Z - info: [ui] [AppStore] adding account juanluisbaptiste (Juan Luis Baptiste) to store
2018-05-11T06:06:13.063Z - info: [ui] [Welcome] advancing to step: ConfigureGit
2018-05-11T06:06:13.131Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:06:13.187Z - info: [ui] [Welcome] no sign in step found. ignoring...
2018-05-11T06:06:15.682Z - info: [ui] [Welcome] advancing to step: UsageOptOut
2018-05-11T06:07:40.745Z - info: [ui] [AppStore] loading 0 repositories from store
2018-05-11T06:07:40.746Z - info: [ui] [AppStore] found account: juanluisbaptiste (Juan Luis Baptiste)
2018-05-11T06:07:41.042Z - info: [ui] Opt in reported.
2018-05-11T06:07:41.159Z - info: [ui] launching: 1.1.1 (Linux 4.15.0-20-generic)
2018-05-11T06:07:41.159Z - info: [ui] execPath: '/opt/GitHubDesktop/desktop'
2018-05-11T06:07:41.334Z - info: [ui] Stats reported.
2018-05-11T06:07:53.118Z - info: [ui] [AppStore] removing account juanluisbaptiste (Juan Luis Baptiste) from store
2018-05-11T06:08:12.275Z - info: [ui] [AppStore] adding account juanluisbaptiste (Juan Luis Baptiste) to store

Description

App fails to starts. Due to GLIBCXX_3.4.21 not found

This can be solved. By installing libstdc++6. Refer to this answer

After the lib's installation I can confirm that the app starts normally.
But it fails to login to github account.

1. By the fetch origin button
   

2. By the sign-in from the options menu (crashes the whole process)
   

Version

GitHub Desktop version: 1.1.0

OS version: Ubuntu 14.04

Steps to Reproduce

1. Install the app in ubuntu with GLIBCXX < 3.4.21

Expected behavior: Spawn the app and sign-in flawless

Actual behavior: App crashes. Fails to sign-in with any way.

Reproduces how often: Every time

Description

When attempting to run GH desktop on CentOS 7 (from the launcher) nothing appears to happen. No processes exist for electron or desktop when I check and if I attempt to launch from the command line it hangs with no output.

I did manage to get it to launch one time (double clicking the icon in the file explorer) but when it launched I only had the chrome and the menu bar. Clicking entries in the menu bar did nothing (visible).

Our environment has a self signed cert for our GH enterprise install, and applies a self signed cert to all external https connections.

Version

GitHub Desktop version: 1.1.0 (could not check in-app)

OS version: centos-release-7-4.1708.el7.centos.x86_64

Steps to Reproduce

1. Attempt to launch desktop from the command line or launcher
2. Then attempt to launch desktop from the file manager

Expected behavior: The application should launch and display something

Actual behavior:
After (1): Nothing appears.
After (2): The chrome and menu appears but nothing is functional and the inner window area is blank.

Reproduces how often: All of the time

Logs

These only appeared after the window opened with nothing in it. When the window did not appear, none of the logs (or config folder) were generated.

2018-02-28T23:27:42.105Z - info: [main] Received possible protocol arguments: 1

Additional Information

I also tried to delete any pref/settings files that I could find to try from the beginning but that didn't help (just deleting .config/GitHub Desktop/ which gets recreated everytime I start the app).
FYI @quandtm

Description: Trying to push any commits will fail and it'll provide the reason of authentication or lack thereof.

Version

GitHub Desktop version: 1.0.11 for Linux RC3

OS version: Ubuntu 17.10 with latest updates,

Steps to Reproduce

1. Install RC3
2. Try to commit any changes and then push them to a repo you have permissions on.

Expected behavior: Pushes commit to the repository.

Actual behavior: Provides error message and doesn't push changes.

Reproduces how often: Every Time

Logs

2017-12-19.desktop.production.log

Description

Admittedly, this is a very minor issue, and I'd like to say thanks for your work on this!

KDE uses a generic "Desktop" icon in the launcher rather than the GitHubDesktop icon. This is some combination of #22 and KDE confusing the two icons. I was not able to change it via the Edit Applications... menu until I renamed the icons github-desktop.png (see below for more detail). The correct icon is used elsewhere, so this is not a duplicate of #16

Version

• GitHub Desktop: 1.1.1 Linux RC

• Operating system:
  Kubuntu 17.10

• KDE Plasma 5.10.5

Steps to Reproduce

1. Install GitHubDesktop via most recent .deb
2. Open launcher
3. Find GitHubDesktop entry (generic "Desktop" icon displayed)
4. Right click launcher > Edit Applications... > Development > GitHubDesktop
5. Click icon to change > choose desktop icon that matches GitHubDesktop
6. Exit > Save
7. Repeat steps 2-3

Expected Behavior

Find GitHubDesktop in launcher, see GitHubDesktop icon.

Actual Behavior

GitHubDesktop icon is generic "desktop" icon, can't be changed via KDE Menu Editor.

Workaround

1. Rename icons desktop.png to github-desktop.png

sudo mv /usr/share/icons/hicolor/1024x1024/apps/desktop.png /usr/share/icons/hicolor/1024x1024/apps/github-desktop.png
sudo mv /usr/share/icons/hicolor/512x512/apps/desktop.png /usr/share/icons/hicolor/512x512/apps/github-desktop.png
sudo mv /usr/share/icons/hicolor/256x256/apps/desktop.png /usr/share/icons/hicolor/256x256/apps/github-desktop.png

2. Right click launcher > Edit Applications... > Development > GitHubDesktop
3. Click icon to change > choose github-desktop icon that matches GitHubDesktop
4. Exit > Save

Description

When trying to sign into a github enterprise server, github desktop responds with The GitHub Enterprise version does not support GitHub Desktop. Talk to your server's administrator about upgrading to the latest version of GitHub Enterprise
This only occurs using the Linux build, I am able to do it easily with the Windows build

Version

GitHub Desktop version: 1.011
Git Hub Enterprise version: 2.11

OS version: Ubuntu 16.04.3 LTS

Steps to Reproduce

1. Open Options
2. Select Sign in under Enterprise
3. Enter Valid Credentials
4. Click Sign in
5. Look at the error code

Selecting Sign in using your browser also fails

Expected behavior: Connect to a GitHub Enterprise (2.11) Server

Actual behavior: Error Message

Reproduces how often: Every Time

Logs

2017-12-18T04:16:50.306Z - info: [ui] [SignInStore] initializing OAuth flow
2017-12-18T04:16:50.309Z - info: [main] opening in browser: https://github.[REMOVED]/login/oauth/authorize?client_id=[REMOVED]&scope=repo%20user&state=[REMOVED]

Additional Information

Description

The parallel-webpack tool does not complete the build for renderer.js. All other targets are built correctly. It does not spit out an error message either, but instead goes in an infinite loop state: webpack writes these two lines over and over

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /builds/sarbakan/github-desktop/tsconfig.json.

Version

• GitHub Desktop: Master HEAD
• Operating system: Alpine Linux inside a docker container

Steps to Reproduce

install docker and pull the image node:7.7-alpine

docker run -it node:7.7-alpine sh

and then once inside the container, run these commands

npm i -g gyp node-gyp
apk update && apk add python libsecret-dev pkgconfig make gcc g++ git
git clone https://github.com/desktop/desktop.git
cd ./desktop
yarn install && yarn build:dev

Expected Behavior

(tested on my host machine using Arch)

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /home/sbegin/Dev/desktop/tsconfig.json.

[at-loader] Checking started in a separate process...

[at-loader] Ok, 7.468 sec.
Hash: c1bd20a10777582336fd
Version: webpack 3.10.0
Time: 39814ms
          Asset       Size  Chunks                    Chunk Names
    keytar.node    45.8 kB          [emitted]         
     runas.node    31.3 kB          [emitted]         
    renderer.js    4.57 MB       0  [emitted]  [big]  renderer
renderer.js.map    5.86 MB       0  [emitted]         renderer
     index.html  225 bytes          [emitted]         
   [1] ./app/node_modules/react/index.js 190 bytes {0} [built]
   [2] external "path" 42 bytes {0} [not cacheable]
 [122] ./app/src/lib/get-os.ts 758 bytes {0} [built]
 [162] (webpack)/buildin/module.js 517 bytes {0} [built]
 [163] external "querystring" 42 bytes {0} [not cacheable]
 [165] ./app/src/lib/source-map-support.ts 4.65 kB {0} [built]
 [171] ./app/src/ui/app.tsx 55.2 kB {0} [built]
 [283] ./app/src/lib/databases/index.ts 351 bytes {0} [built]
 [284] multi webpack-hot-middleware/client?path=http://localhost:3000/__webpack_hmr ./app/src/ui/index 40 bytes {0} [built]
 [285] ./app/node_modules/webpack-hot-middleware/client.js?path=http://localhost:3000/__webpack_hmr 7.04 kB {0} [built]
 [286] ./app/node_modules/strip-ansi/index.js 150 bytes {0} [built]
 [288] ./app/node_modules/webpack-hot-middleware/client-overlay.js 1.82 kB {0} [built]
 [293] ./app/node_modules/webpack-hot-middleware/process-update.js 3.87 kB {0} [built]
 [294] ./app/src/ui/index.tsx 5.33 kB {0} [built]
 [295] ./app/src/lib/logging/renderer/install.ts 1.19 kB {0} [built]
    + 742 hidden modules
Child html-webpack-plugin for "index.html":
         Asset    Size  Chunks  Chunk Names
    index.html  567 kB       0  
       [0] ./node_modules/html-webpack-plugin/lib/loader.js!./app/static/index.html 511 bytes {0} [built]
       [1] ./node_modules/lodash/lodash.js 540 kB {0} [built]
       [2] (webpack)/buildin/module.js 517 bytes {0} [built]
[WEBPACK] Finished building renderer.js within 39.814 seconds

Actual Behavior

(from inside the node:7.7-alpine container)

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /builds/sarbakan/github-desktop/tsconfig.json.

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /builds/sarbakan/github-desktop/tsconfig.json.

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /builds/sarbakan/github-desktop/tsconfig.json.

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /builds/sarbakan/github-desktop/tsconfig.json.

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /builds/sarbakan/github-desktop/tsconfig.json.

[WEBPACK] Started building renderer.js

[at-loader] Using [email protected] from typescript and "tsconfig.json" from /builds/sarbakan/github-desktop/tsconfig.json.

...

Additional Information

There has been another instance of this problem in a different context

Logs

complete output of yarn build:dev from inside the container

Description

Hi @shiftkey, thanks again for your work/teamwork. Appreciate it.

sign in via website at 1.0.11 Linux RC3 not working. callback is not going back and button state is 'loading'.
Ubuntu 16.04, 64-bit
But I can login using login form only. just want to contribute.

Have a good day and please hug somebody at desktop team, cause it makes(Linux version) me so happy!
[Description of the issue]

Version

GitHub Desktop version: 1.0.11 Linux RC3
I use this version cause it was pointed from this issue desktop#1525
Maybe it'll be great if you can update link on your comment: desktop#1525 (comment)

Shall I try the latest release(1.0.13 Linux RC)?

OS version: Ubuntu 16.04, 64-bit

Steps to Reproduce

1. Install on Ubuntu, open an app
2. Sign in screen
3. Tried to login via OAuth link(Sign in via browser) and after authorizing at website I think callback is not going back.

Expected behavior: github oauth page must be closed. desktop app must login me into my account

Actual behavior: github oauth page not closed and blank. desktop app sign in form not sumbitted. submit button is loading.

Reproduces how often: only first time when you login. not critical.

Logs

Additional Information

This is not really a full issue or bug report, but as an Ubuntu developer, I am acutely aware of the evils of package naming. This is a suggestion on the basis of my experience as a Packager.

The current binaries built for GitHub Desktop for Linux (RCs) are generated so that the package itself in the debian/control files and others is named desktop.

This is extremely ambiguous and unclear what it actually is, and makes understanding what is actually installed or usable or not equally more difficult.

If possible, I would suggest that you adjust the packaging so that the binary for GitHub Desktop is installed as github-desktop, and that the package name be adjusted as well. It currently installs as desktop and that is very ambiguous as to what it actually is.