Code Monkey home page Code Monkey logo

Comments (7)

Croydon avatar Croydon commented on July 17, 2024 1

/usr/bin/konsole does exists.

The options menu within GitHub Desktop actually calls it "Konsole" as well in the drop-down menu to select which console should get used.

However, the "Open with.." menu point under "Repository" then displays "Open in GNOME Terminal" and the error as reported as above when executed.

from desktop.

ziggy42 avatar ziggy42 commented on July 17, 2024

Do you actually have GNOME Terminal installed? I'm not very familiar with KDE, do you have konsole (/usr/bin/konsole) installed? Do you see it in the list of available terminals?

from desktop.

immackay avatar immackay commented on July 17, 2024

Hi all. I originally expanded the linux based code for shells and it seems it's not working now. I've got URxvt installed and selected, but GitHub Desktop only shows the "Open in GNOME Terminal" option, and fails to find it (though it too is installed).

I'm on Arch Linux, fyi.

I'll play around with it and see if I can find out what's going on, as it (theoretically?) should be working

from desktop.

Croydon avatar Croydon commented on July 17, 2024

@immackay It might be an initial config error, e.g. the value might be wrong when the user never changed the setting (which is not possible when you only see one option displayed).

Somebody wrote somewhere (sorry, not sure where anymore), that after a switch in the option to another selected console and afterwards a switch back the the original desired one it worked.

from desktop.

immackay avatar immackay commented on July 17, 2024

Okay thanks, I'll check out that avenue.

If I am understanding the error correctly it seems the Shell object that is supposed to be returned by getAvailableShells() is returning null instead, but I'm not sure why - as it should at least resort to Default, which is definitely available at the path defined in linux.ts. UPDATE - as @Croydon previously mentioned, the variable is being set to default but if GNOME Terminal is not available, this result is undefined. If instead we could check for each of the listed shells and choose one of them as default, this issue would be fixed.

Also, I'm thinking that perhaps we can probe for the current desktop environment (if available) and attempt to use the DE terminal emulator by default. "ls /usr/bin/*session" returns a list of xorg sessions.

Alternatively, we could just implement all available VTEs from https://wiki.archlinux.org/index.php/List_of_applications#Terminal_emulators as well as WM specific ones, such as i3-sensible-terminal, and use the default from the xorg-session listed in .xinitrc as "Default".

One final method we could accept any VTE is by having an input box for path and commands. I think this would probably be the easiest honestly. @shiftkey what do you think of this idea?

from desktop.

shiftkey avatar shiftkey commented on July 17, 2024

@Croydon are you able to re-test things with a more recent version of the app? I'm wondering if this was a "we don't have any valid shells, but we need to show something" option, and I wonder if this is a non-issue now that we have a more complete set of shells to support.

Otherwise, if this is still occurring, could you please share what list of editors you have under File | Options and the Integrations tab:

I only have GNOME Terminal but that works because I'm on Ubuntu.

I guess I need to look into improving the tracing in this area, similar to #224, so we can ensure we're able to launch this editor.

from desktop.

Croydon avatar Croydon commented on July 17, 2024

I installed 2.4.0 via rpm on Firefox 31 with KDE Plasma 5.17.5

I was almost reporting that the error is still the same as I got the same result the first time. The second time I opened the settings it finally picked up Konsole and removed the GNome Terminal from the shell list.

With Konsole selected it finally works for me.

Thanks!

from desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.