Code Monkey home page Code Monkey logo

Comments (10)

shiftkey avatar shiftkey commented on July 17, 2024 3

Found this extra context for the first error:

keytar uses libsecret, which is a frontend to gnome-keyring. KWallet does not support org.freedesktop.secrets
just installed the package gnome-keyring and everything workes fine

I'm not sure how feasible that is for your use case, but I also don't have enough familiarity with whether there's an alternative to gnome-keyring that's more suitable (KWallet/KSecretService support seems to be an ongoing discussion).

from desktop.

shiftkey avatar shiftkey commented on July 17, 2024 2

I'm going to close this out because this is outside the scope of GitHub Desktop. I'd recommend looking for alternatives to KWallet for KDE systems, but I don't seem to be able to find any based on a quick google search.

from desktop.

shiftkey avatar shiftkey commented on July 17, 2024

@obedm503 thanks for the details!

My initial gut feeling on this is that the login flow where you provide username/password/2fa is failing when we try and add credentials to the OS credential store. We're using node-keytar which then uses libsecret which should work with both GNOME and KDE services for storing secrets, but maybe I'm missing something.

Using the browser to login is probably the same as #10, which is an Electron limitation that was fixed recently. Even if that was working, you'll probably still face the above issue because we need somewhere to store stuff.

from desktop.

obedm503 avatar obedm503 commented on July 17, 2024

so if I install gnome-keyring it should work?

from desktop.

shiftkey avatar shiftkey commented on July 17, 2024

@obedm503 I believe so

from desktop.

shiftkey avatar shiftkey commented on July 17, 2024

If this can be of some help, in VS Code KWalet is used without problems.

@Bleser92 if you can find out which Node library they're using (and how they're using it) I'm happy to figure out if this can be applied to keytar in some way.

EDIT: I see VSCode is up to 4.0.5 of keytar, which is not far ahead of Desktop which is using 4.0.4 currently.

from desktop.

mathetes87 avatar mathetes87 commented on July 17, 2024

I'm also using KDE Neon and installing gnome-keyring solved the login problem for me!

from desktop.

sl1pkn07 avatar sl1pkn07 commented on July 17, 2024

any other alternative? i don't what install gnome-keyring because my system is crafted for gnome-free

is possible use kwallet instead?

from desktop.

shiftkey avatar shiftkey commented on July 17, 2024

is possible use kwallet instead?

Not currently - someone needs to contribute support for KWallet to node-keytar as well as the ability to detect and choose the right backend.

This is the issue discussing that change: atom/node-keytar#17

EDIT: node-keytar actually uses libsecret which is intended to be agnostic of the desktop you use, but KWallet doesn't implement support for it. This is the discussion you want to follow along with.

from desktop.

obedm503 avatar obedm503 commented on July 17, 2024

After almost a year, I decided to replace KWallet with Gnome's Seahorse. It now lets me login.

from desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.