0.58.4 Discussion about releases HOT 29 CLOSED

The CI is back green and 0.58.5 is out.

from releases.

from releases.

I will be releasing another 0.58 release tomorrow with the commits mentioned.

from releases.

Cherry-picked almost all the commits.

@Jyrno42, your commit is already part of the release.
@noahtallen, I didn't cherry-pick your commit since it's already part of 0.59 where it's been deprecated too. I think it's good to not cherry-pick deprecations. I hope it's not a deal breaker for you.

Waiting for the tests to pass.

from releases.

This is going to help with the TextInput issues -> facebook/react-native@f307ac7

from releases.

@afilp, we have already discussed this in #41 and came to the agreement that cherry-picking this commit could greatly affect the stability of 0.58 release.

It's going to be in 0.59, which isn't far away. Please subscribe to #79 issue for further details.

from releases.

Fixes build issues for iOS -> facebook/react-native@2aa2401

from releases.

Another build issue fix for iOS -> facebook/react-native@9f72e6a

from releases.

Fix textTransform when used with other text styles on Android - facebook/react-native@3a33e75

from releases.

Yep, it's in 0.59, so I proposed it for 0.58.5 if released. I learned that people are changing targetSDK to 28 and having network issues with 0.58 release, because Android Studio is suggesting to use the latest or 28 version.
…

Yes, it will be pretty good if you release .58.5 for the Android issues with sdk 28.

from releases.

If there is going to be a 0.58.5, can we please get this in too: facebook/react-native@a9dd828 It was introduced in 0.58.x so it'd be great if we could backport a fix for it too.

from releases.

Fix Inverted Horizontal ScrollView on Android -> facebook/react-native@4521cff

from releases.

I understand! In this case, one thing I can do for you is to encourage you to try the RC :)

from releases.

Yes, that's the commit -- sorry I put the PR link initially instead.

from releases.

I'll include that one too, just doing final touches before the release.

from releases.

@grabbou no problem! That certainly makes sense. My hope was that it would help with a different issue I was having related to react native screens.

from releases.

@cihati I think you just ask for a specific commit, like so facebook/react-native@dd209bb in this case?

from releases.

@grabbou many thanks!! Just for my understanding: what's the release process timeline like in general? For instance, I see that you bumped version numbers to 0.58.5 ~4 hours ago ( facebook/react-native@9d90696 ) but I don't see the new react-native version in NPM yet (or in CHANGELOG.md)

from releases.

Generally speaking, it takes an hour from the tag pushed to Github to land on npm. Unfortunately, the CircleCI failed to checkout the code (https://circleci.com/gh/facebook/react-native/73354). I am investigating the issue.

from releases.

facebook/react-native@f3e5cce

Thanks!

from releases.

How about this one? facebook/react-native@dda2b82

from releases.

@grabbou Sorry, I missed that part. Thank you!

from releases.

network security configuration for people who change targetSDK to 28 in build.gradle -
facebook/react-native@5747094

from releases.

@dulmandakh this is showing up when I look at the patches - pvinis/rn-diff-purge@version/0.58.4...version/0.59.0-rc.0 - it appears to be incorporated already?

from releases.

I would love if this made it to the 0.58.x release facebook/react-native@7795a67

from releases.

(I apologize, I still haven't figured out how it's decided that certain commits are put into certain releases. Any pointers would be helpful)

@grabbou Any chance to get facebook/react-native#22439 into the next release, assuming there will be 0.58.5 release? It's merged on Jan 2nd, and our app crashes a lot due to this issue. I see that the fix's already in the 0.59 branch: https://github.com/facebook/react-native/blob/0.59-stable/Libraries/WebSocket/RCTSRWebSocket.m

from releases.

Hmm the problem with internet connection on Android still persists with sdk 28 :(. Or there is any config to do? Or this release doesn't included that fix?

from releases.

@andresmtz98 can you comment on the related issue on the main repo? So that we can close this, open a new one for 0.58.6 if we decide to do a next one (before 0.59.0).

(also, you should double check that the issue is still present on the 0.59 rc)

from releases.

Closing in favor of -> #95

from releases.