Code Monkey home page Code Monkey logo

Comments (23)

sandfox avatar sandfox commented on May 27, 2024 5

@kelset I'll see if I can do that then: facebook/react-native#30688
So far it's working properly on our internal test case

from releases.

tido64 avatar tido64 commented on May 27, 2024 4

@anchi20: Please read the first post:

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

Please let us know when your PR has landed on master.

from releases.

kelset avatar kelset commented on May 27, 2024 4

update: it's not likely we'll do a 0.63.5 patch, but since the Xcode 12.5 issue is fairly big it could be the case. We are still waiting for a commit to land in master, but I've started to update the top post with the list of commits we should cherry pick.

from releases.

grabbou avatar grabbou commented on May 27, 2024 3

I am going to cherry-pick the aforementioned commit and test whether it fixes the issue on this branch as well, as a part of my testing of the same commit for the 0.64 branch!

from releases.

grabbou avatar grabbou commented on May 27, 2024 2

When facebook/react-native#30543 lands, we will need to cherry-pick it to this branch too. It is affecting users on older React Native versions as well that upgraded to latest Xcode.

Edit: there it is: facebook/react-native@fdcacd7

from releases.

grabbou avatar grabbou commented on May 27, 2024 2

This should also be cherry-picked facebook/react-native#30592 to avoid adding a whole new post install hook to a Podfile.

from releases.

retyui avatar retyui commented on May 27, 2024 2

Really wait for these changes facebook/react-native@b7b0e23

To have an opportunity to get tap location on the <TextInput/> component

from releases.

priteshrnandgaonkar avatar priteshrnandgaonkar commented on May 27, 2024 2

Just a reminder, please use the latest Flipper pod, as we have solved the issues related to Apple M1 machines and arm compatibilities. Latest Flipper pod is 0.75.1

from releases.

kelset avatar kelset commented on May 27, 2024 1

@retyui that commit adds new functionality so it's not a candidate for a patch release.

from releases.

kelset avatar kelset commented on May 27, 2024 1

@sandfox I've already attempted cherry-picking it during the last round, but it's really complicated because the files involved changed a lot - so it's not achievable. The only option would be for someone to do a PR against the 0.63 branch with the fix "repurposed" to work on it.

from releases.

mrousavy avatar mrousavy commented on May 27, 2024 1

@priteshrnandgaonkar a bit off-topic, but does the latest Flipper pod also fix facebook/react-native#30836?

from releases.

kelset avatar kelset commented on May 27, 2024 1

potential cherry pick: facebook/react-native@3399896

from releases.

retyui avatar retyui commented on May 27, 2024 1

p.s. @kelset seem you recommend a legacy ruby syntax

-use_flipper!('Flipper' => '0.75.1')
+use_flipper!({ 'Flipper' => '0.75.1' })

from releases.

kelset avatar kelset commented on May 27, 2024 1

@todorone if you are on 0.63 you only need to tweak your podfile to address the Xcode 12.5 issue, see details here: facebook/react-native#31480

from releases.

sandfox avatar sandfox commented on May 27, 2024

Could we backport in facebook/react-native@d85d5d2 from facebook/react-native#29882
It's a fix for Modal onDismiss behaviour. It's already in 0.64

from releases.

kelset avatar kelset commented on May 27, 2024

@mrousavy from the comments in the issue seems like it did. In my experience, you can just change your podfile to

use_flipper!('Flipper' => '0.75.1')

To change the Flipper version

from releases.

retyui avatar retyui commented on May 27, 2024

Still waiting for a fix for Modal::onDismiss on iOS facebook/react-native@d85d5d2

from releases.

kelset avatar kelset commented on May 27, 2024

We are getting closer to 0.64.0 so atm we are fully focused on that - no ETA for a new patch for 0.63.x.

from releases.

sandfox avatar sandfox commented on May 27, 2024

@retyui - there's an open (mine) PR for it facebook/react-native#30688 that can be used if 0.63.5 gets the go ahead (assuming poeple are ok with merging it of course).

from releases.

kelset avatar kelset commented on May 27, 2024

potentially useful to consider: facebook/react-native@0e9296b

from releases.

anchi20 avatar anchi20 commented on May 27, 2024

here, facebook/react-native#29070

from releases.

todorone avatar todorone commented on May 27, 2024

@kelset Not everybody can migrate to 0.64 yet, so releasing a fix to XCode 12.5 will be a lifesaver... 🥺

from releases.

kelset avatar kelset commented on May 27, 2024

Given how the update for Xcode 12.5 didn't require an update for 0.63, I'm going to close this off. We are currently focused on 0.64 and 0.65 so there won't be new 0.63 releases for the time being.

from releases.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.