react-native-community / releases Goto Github PK

Please report any major issues and commits to cherry-pick in this thread for discussion.

Hi,

I upgraded my react native project from 0.56 to 0.57 using the steps provided in this repository because I was facing facebook/react-native#18886 issue.

However after upgrading my project, the static images are not properly bundled together in my react native project which is referenced at facebook/react-native#21309 issue. Later I wanted to use firebase in my project hence had to install react-native-firebase. There, I followed their instructions to upgrade my project to Gradle 4.4 . After the upgrade, the static images got bundled properly.

I think the steps to upgrade gradle is a necessary info to provide in the changelog in this repository which will fix issue with bundling static images in android....

Please report any major issues and commits to cherry-pick in this thread for discussion.

Use something like NaiveBays from Natural to classify commits; maybe this should take into account the files changed and the commit message? This is an attempt to help improve the auto-classification of changes to RN.

Hi,
we had long discussion within the team about it but without consensus. Maybe you can help?

Conversation on this thread are limited to 0.58.0 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

Latest release: 0.55.4

0.56.0

Hello,

One of my fixes is going to land in 0.56 🎉 and it might impact previous usage / workarounds with the local-cli link command:
facebook/react-native@dbd4759

Do you guys need me to add this to the changelog, or is it not necessary ?

Thanks for the hard work on 0.56 ⚡️

Conversation on this thread are limited to 0.57.5 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.6 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

Hey there, sorry, not sure if this is the place for this.
However, after having some major pains trying to upgrade jest to play nice with tests for RN 0.57.3

I wondered if there should be a upgrade path described within the changelog for the defacto testing framework of RN as well.

Thanks

Conversation on this thread are limited to 0.58 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

Conversation on this thread are limited to 0.57 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

Conversation on this thread are limited to 0.57.8 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.9 release in the near future. Unless some serious bugs pops up, the release will happen after Jan 6th 2019.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.8 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

Conversation on this thread are limited to 0.59.0 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

Conversation on this thread are limited to 0.59 releases, major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

Latest: https://www.npmjs.com/package/react-native/v/0.57.0-rc.0

Conversation on this thread are limited to 0.57.1 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.0 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

Conversation on this thread are limited to 0.57.2 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.3 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.1 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

Please note that we haven't cut 0.60-stable branch yet.

The latest release candidate is 0.59.0-rc.3. You can track it's progress here: #79

This thread is to inform you when next release candidate is going to happen. We are checking whether there is any "work-in-progress" that we should be aware of and wait before we make a next Release Candidate.

The plan is to release 0.60.0-rc.0 this week.

A fix for facebook/react-native#18209 is now on master, but is not yet part of any release.

This fixes a regression that is preventing live reloading from working correctly in 0.54 and 0.55.

Would we consider releasing a 0.54.2 version with this fix?

As for 0.55, the fix should make it when the RC is cut.

C:\bond\workspace\igApp>react-native info
info
React Native Environment Info:
System:
OS: Windows 7
CPU: (4) x64 Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz
Memory: 7.99 GB / 15.64 GB
Binaries:
Yarn: 1.15.2 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.7.0 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version 3.3.0.0 AI-182.5107.16.33.5314842

C:\bond\workspace\igApp>react-native run-android --verbose
info JS server already running.
info Building and installing the app on the device (cd android && gradlew.bat app:installDebug)...

Configure project :react-native-gesture-handler
WARNING: Configuration 'provided' is obsolete and has been replaced with 'compileOnly'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
WARNING: The specified Android SDK Build Tools version (25.0.2) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.3.1.
Android SDK Build Tools 28.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '25.0.2'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

Configure project :react-native-keychain
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

Configure project :react-native-splash-screen
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
WARNING: Configuration 'testCompile' is obsolete and has been replaced with 'testImplementation'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
WARNING: The specified Android SDK Build Tools version (26.0.3) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.3.1.
Android SDK Build Tools 28.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '26.0.3'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

Task :app:signingConfigWriterDebug FAILED

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':app:signingConfigWriterDebug'.

org/apache/commons/io/FileUtils

• Try:
  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

• Get more help at https://help.gradle.org

BUILD FAILED in 2s
74 actionable tasks: 1 executed, 73 up-to-date
<-------------> 0% WAITING

IDLE
IDLE
error Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html
error Command failed: gradlew.bat app:installDebug
debug Error: Command failed: gradlew.bat app:installDebug
at checkExecSyncError (child_process.js:637:11)
at execFileSync (child_process.js:655:13)
at runOnAllDevices (C:\bond\workspace\igApp\node_modules@react-native-community\cli\build\commands\runAndroid\runOnAllDevices.js:58:39)
at buildAndRun (C:\bond\workspace\igApp\node_modules@react-native-community\cli\build\commands\runAndroid\runAndroid.js:142:41)
at then.result (C:\bond\workspace\igApp\node_modules@react-native-community\cli\build\commands\runAndroid\runAndroid.js:104:12)
at processTicksAndRejections (internal/process/task_queues.js:86:5)

Hey :)

Thanks for taking the time to write such detailed changelogs, it helps a lot! Here's a small feedback on latest changelog (0.54):

It would be great to highlight the big breaking changes, for example:

• [BREAKING] Delete RCTBatchedBridge

I upgraded my app from 0.55.5 to 0.58.3. While running the app on ios simulator, i am getting the below error:

Loading dependency graph, done.
error: bundling failed: Error: Unable to resolve module axios/index from /Users/testuser/Documents/Work/Projects/MyApp/src/api/http_methods/environment.js: Module axios/index does not exist in the Haste module map.

Tried the following steps to resolve by referring facebook/react-native#4968

1. Clear watchman watches: watchman watch-del-all.
2. Delete the node_modules folder: rm -rf node_modules && npm install.
3. Reset Metro Bundler cache: rm -rf /tmp/metro-bundler-cache-* or npm start -- --reset-cache.

I am still getting the same issue.

Conversation on this thread are limited to 0.58.6 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.6 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

In this particular scenario, we actually won't publish a 0.58.7 release unless major issues appear: we are getting close to the 0.59.0 stable status so we prefer to focus on that - you can keep up to date about it here.

in 0.57.0 release third-party-library is not supporting in ios getting issue like e.g. .default.set.

The changelog has the following text:

Revive react-native-xcode.sh made improvements (b8c86b8 and 0d4ff1b by @yungsters and @brunolemos)

, pointing to two "remove all" / "re-add file" commits due to facebook-bot bug.

That's not clear to the user what has changed (and even kinda makes it look like I messed up).

The text could be something like this:

[iOS] Add $EXTRA_PACKAGER_ARGS extensibility point on react-native-xcode.sh script (facebook/react-native#16933) by @brunolemos

npm version: 0.54.3

I don't know if this discussion is right place, but there is no space where users and developers can read changelogs about patch versions of RN in friendly way.
Every minor (major because before version 1?) version of RN has nice description about what has changed but patch versions doesn't. I think there is legitimate requirement to tell what is different in every version. Many changes are significant (eg. Android studio 3.2/Xcode 10 support, some important fixes).
It could increase awareness about RN and making better apps because upgrading between last patch version and new minor version is less annoying (baby steps, less painful changes in code).
On the other hand it could also decrease opening some unnecessary issues on RN Github project cause every change is visible in human readable form.

Is there any way how to automatically generate changelog from release notes of cherry-picked commits?

Originally posted by @radeno in #46 (comment)

Conversation on this thread are limited to 0.59.4 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

I have a suggestion by creating issue placeholder template saying what to do with this repository and giving options when this is not the place to post issue, to keep this repository only with relevant issues, does it necessary?

0.60.0-rc.0 is most likely going to be released tomorrow. The branch is already cut. We are working on the changelog.

Stay tuned.

Please report any major issues and commits to cherry-pick in this thread for discussion.

@hramos or anybody, Could you mind to cherry pick commit (facebook/react-native@41975f7) into the RN0.55 release?

I understand 0.56 included this commit, but in my case, we are very close to release our RN app, and we have tested 0.55 for weeks, so far the only issue left is this android emoji crush in suggestion bar, and this commit solved it, I would really hope you can consider my request, 0.56 introduced new versions requirements, and 0.56 may also introduce more new bugs, but we do not have enough time upgrade RN and test at this moment, we will definitely upgrade our RN later, but at the moment, I am really hope if you guys can consider to cherry pick this commit to RN 0.55.

Much appreciated !!!

0.59.0-rc.0 Flatlist inverted horizontal with ListFooterComponent or ListHeaderComponent:
when data is empty array and ListFooterComponent or ListHeaderComponent rendering component - the component show on left instead of right.
when adding data - the ListFooterComponent or ListHeaderComponent is ok.

The bug is on iOS and Android.
The bug not happened on 0.58.4 version

Code:

const data = []; // The ListFooterComponent or ListHeaderComponent Is on the right
// data = ["test"]; // The ListFooterComponent or ListHeaderComponent Is on the left = OK
 <FlatList
                    data={data}
                    keyExtractor={item => item}
                    ListFooterComponent={<View
                        style={{
                            backgroundColor: "#D6D6D6",
                            paddingVertical: 6,
                            marginVertical: 6,
                            borderRadius: 20,
                            alignItems: 'center',
                            paddingHorizontal: 15
                        }}>
                        <Text>{"+"}</Text>
                    </View>}
                    ListHeaderComponent={<View
                        style={{
                            backgroundColor: "#D6D6D6",
                            paddingVertical: 6,
                            marginVertical: 6,
                            borderRadius: 20,
                            alignItems: 'center',
                            paddingHorizontal: 15
                        }}>
                        <Text>{"+"}</Text>
                    </View>}
                    inverted
                    horizontal
                    renderItem={({item, index}) => {
                        return <View style={{justifyContent: 'center'}}>
                            <Text>{"Test"}</Text>
                        </View>
                    }}/>

Thank you

Created issue as per @hramos, not sure what the content should be here :-)

Hi
TextInput:
on Android only, textAlign: "right" doing "left" instead of right.
and "left" doing "right" instead of left.

And the the textAlign property doesn't effect the placeholder at all

only on 0.59.3 and only on Android

This is my render code:

    return (<View style={{
      display: "flex",
      backgroundColor: "green",
      paddingVertical: 20
    }}>
      <View style={{ backgroundColor: "red", flex: 1, position: "absolute", height: "100%", width: "100%" }} />
      <Text>This is the text</Text>
      <Text>This is the text</Text>
      <Text>This is the text</Text>
      <Text>This is the text</Text>
    </View>)

What is see is the following:

What I expected was the height of the red child View to match the height of the parent green View.

Conversation on this thread are limited to 0.58.0 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.58.4 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.3 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

Conversation on this thread are limited to 0.57.4 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.5 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

Conversation on this thread are limited to 0.59.3 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.3 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

Hi
Text:
on Android only, textAlign: "right" doing "left" instead of right.
and "left" doing "right" instead of left.
only on 0.59.3 and only on Android

Conversation on this thread are limited to 0.58.5 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

When compared to other versions Size is increased which is a key point , So is there any way to reduce size in react native 0.58.4 , Just for one page it took 18MB
The following are my dependencies
"react": "16.6.3", "react-native": "0.58.4", "react-native-elements": "^1.0.0", "react-native-gesture-handler": "^1.0.15", "react-native-vector-icons": "^6.3.0", "react-navigation": "^3.2.3"

Conversation on this thread are limited to 0.57.7 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.8 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.7 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

When this migrated from my account to the org, the scope changed to include release status updates as well. We need to update the readme to reflect this, as well as provide better information of the existing purpose.

Hey,
Congrats for the new release.
WE just been waiting for the new release and unfortunately am not able take up your update.

import type {CommandT} from './commands';
^^^^^^

SyntaxError: Unexpected token import
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Module._compile (module.js:599:28)
at Module._compile (F:\Users\nw\Work\ReactNative\newapps\node_modules\pirates\lib\index.js:91:24)
at Module._extensions..js (module.js:646:10)
at Object.newLoader [as .js] (F:\Users\nw\Work\ReactNative\newapps\node_modules\pirates\lib\index.js:96:7)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)
at Function.Module._load (module.js:489:3)
at Module.require (module.js:579:17)

Conversation on this thread are limited to 0.57.3 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.4 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.3 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

Conversation on this thread are limited to 0.57.6 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.7 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.6 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.