0.57.1 Discussion about releases HOT 31 CLOSED

We are waiting for Metro fix to land (hopefully tomorrow) to eliminate one last Flow error and we are good to go!

from releases.

Thank you @kelset for your comment. I was actually about to mention 👎 as really discouraging. I understand you are all hoping for a next release to have all the fixes, but merging and resolving conflicts is a non-trivial process. I am trying to do my best to resolve them when appropriate, but I may overlook some of them or simply fail to resolve.

It was an issue with links - I am going to update the the comment. Meanwhile, the overflow support has been added via: facebook/react-native@5906c26

from releases.

My list of commits to (potentially) cherry pick for 0.57.2:

• Remove global babelHelpers and regenerator
• Remove overflow hidden killswitch
• ReactScrollView should account for overflow: scroll
• Fix HEAD request failing with Invalid response for blob
• Android ScrollView fix for pagingEnabled
• Bump [email protected]
• Remove absolute path parameter from transformers
• Android subpixel text
• Fix event handlers for DPad arrows on Android TV
• Use babel runtime instead of relying on global babelHelpers and regenerator
• React: Upgrade to react-devtools@^3.4.0
• Change new Date() to Date.now() to save on date allocations
• Android ScrollView support for overflow: visible
• Rounded corner rendering fixed on Android N

Aside from those, I'm currently waiting for a React sync commit then IMHO we can proceed to test and then release 0.57.2.

from releases.

@mjmasn, yes it's actually just wrong wording/linking, as you can see for yourself in the branch both Android ScrollView commits are there:

• facebook/react-native@0869e54
• facebook/react-native@5906c26

That said, if we didn't cherry-pick what you want there are good reasons for it so please remember to keep a positive environment here (I literally have no clue how Mike latest comment got 👎). And that you can always fork the main repo or use solutions like patch-packages.

When we do create a release we try to ensure that it works, so if a commit didn't make it in the release there are good reasons.

Anyway once the release is out we'll close this and open a new issue for 0.57.2 with requests for cherry picks for 0.57.3.

from releases.

It wasn't actually a mistake in linking - I first cherry-picked facebook/react-native@4af4da9 while trying to cherry-pick facebook/react-native@201f2f1.

Then, when I got to facebook/react-native@4af4da9 itself, I got tons of conflicts - I forgot that I've already cherry-picked it for another commit.

As a result, I simply got confused. All changes requested where cherry-picked.

from releases.

4 more commits that may be worth adding:

• Android: fix cookies lost on Android 5.0 and above
• Check if child view != null before dropping
• Expose a getter for overflow setting in ReactViewGroup
• allow zero offset when shadow radius is nonzero

from releases.

We know, there are Flow issues, we had to cherry pick a couple more commits. There is one flow issue left, we are working on it.

from releases.

We should cherry pick this for Android Studio 3.2 compatibility facebook/react-native@ff084a4

from releases.

Additionally, I had to cherry-pick few more commits:

• facebook/react-native@4af4da9 for facebook/react-native@201f2f1 to be applied w/o conflicts.

from releases.

@grabbou I think you've pasted the wrong commit url for that first link, seems to be the same as the third one? And are you saying it's not possible to cherry-pick those ScrollView regression fixes before 0.58, because that is somewhat frustrating :/

from releases.

from releases.

This one, please: facebook/react-native@7e9c3f7

from releases.

0.57.* has a nasty babel bug - babel/babel#8709

facebook/react-native#21425 (comment)

from releases.

@grabbou makes sense, thanks. FWIW my 👎 was a thumbs down to the issue you encountered with cherry picking those fixes, not aimed at you at all, but can see how that might have been interpreted. Sorry for that, and please don't be discouraged because us switching from Android native to RN has been a hugely positive experience! :)

from releases.

Are you planning to release 0.57.2 or 0.57.1? The topic is "0.57.1 Discussion", but I see you guys are talking about 0.57.2.

I need these two Android ScrollView fixes:

• facebook/react-native@e0170a9
• facebook/react-native@4af4da9

Not sure what to expect.

Thanks!

from releases.

Thanks. 0.57.1 is not marked as released in RN repo thus the confusion.

from releases.

Can this be included in the next version: facebook/react-native@36199d3? Or will this be automatically added in 0.58.0?

from releases.

@karanjthakkar that's already in 0.57.1 (#34 (comment) && facebook/react-native@4ea3ac7)

from releases.

Oh perfect! Thanks for letting me know. Just FYI, have we changed something in the release process? Coz now this comment seems to be no longer valid then: facebook/react-native#20820 (comment)?

from releases.

No I think it's a bug with GitHub, saw it happen for another couple commits too 🤷‍♂️

from releases.

I think this commit facebook/react-native@458d56c need a release , because it broken the template build. Related issue facebook/react-native#21310.

from releases.

@gengjiawen That commit is already listed in
#45 (comment) (at the top of the list).

from releases.

With all these fixes, this looks like a really solid release. Do you have a target date yet for 0.57.2?

from releases.

@grabbou I put my 👎 for the very same reason as @mjmasn - like "oh, thats too bad that there are conflicts" 😉

from releases.

0.57.2 still not on NPM, just FYI

from releases.

Patiently waiting for the package to hit NPM so I can fix a bunch of Android Pie issues.. Thanks for the hotfix release!

from releases.

from releases.

Figured that out. The latest release on npm is 0.57.1 but on the React Native Github page, the latest is still 0.57.0.

from releases.

would be good to ship any commits that fix anything about facebook/react-native#19573 even if its not the full solution. of course it would be nice to have all of it solved and shipped in 0.57.x, but even part of it will be helpful for many devs.

from releases.

0.57.2 is up on NPM, for anyone subscribed to this

from releases.

Hey everyone, since 0.57.2 is released I'm closing this and opening a new one for 0.57.2.

from releases.