Code Monkey home page Code Monkey logo

Comments (22)

mikehardy avatar mikehardy commented on May 27, 2024 23

Pick and release, no rn release is ever fast and .0 releases have low adoption based on feedback. A point release is immediate and more trusted. 2 cents 😁

from releases.

mikehardy avatar mikehardy commented on May 27, 2024 13

I guess I should say there is no such thing as a fast rn .0 release, quite evidently there are fast point releases! That was super quick. Thanks @lunaleaps

from releases.

oblador avatar oblador commented on May 27, 2024 11

Please revert facebook/react-native@cb0e1d6 or pick facebook/react-native#32398

from releases.

mikehardy avatar mikehardy commented on May 27, 2024 9

I believe these both need testing but in the continued effort to make the iOS build experience better, these two from @barbieri replace the current workarounds with what appear to be real solutions:

facebook/react-native@a1c445a
facebook/react-native@51bf557

My only hesitation on those (other than "needs testing") is that I'm not sure of the implications with regard to transitive dependencies. Specifically:

  • I'm not sure if those also bring in the requirement for cocoapods >= 1.11 or not,
  • "deprecate the __apply_Xcode_12_5_M1_post_install_workaround() as it's not needed anymore, at least with recent versions of the dependencies, no patching is required with RCT-Folly" --> do we already transitively depend on "recent version" (and what are those minimum versions?)

So I'm not sure if they fit (or can be made to fit) for a patch release or should wait for 0.67, but they have landed on main branch at least

from releases.

lunaleaps avatar lunaleaps commented on May 27, 2024 9

0.66.1 is out: https://www.npmjs.com/package/react-native

from releases.

gaodeng avatar gaodeng commented on May 27, 2024 8

please revert facebook/react-native@1b0fb9b
Related Discussion
facebook/react-native#31461
facebook/react-native#28236 (comment)

from releases.

lunaleaps avatar lunaleaps commented on May 27, 2024 7

Hey guys, sorry about the lack of responsiveness on this thread. I think my big question here has been, since we're planning on releasing 67 (cutting this week), and there are roughly a month of changes from 66 -> 67, should we just focus on getting 67 with these changes?

Are there any issues here that fundamentally break 0.66 usage? I think the strongest contenders are:

But these don't feel like major usage breakages for 0.66?
True, the delta of changes between 0.66 and 0.67 may elongate release testing, I'm tempted to focus on releasing 67. Maybe if we see within a week that 67 has major release blockers, then I can start a patch release -- what do you guys think?

from releases.

lunaleaps avatar lunaleaps commented on May 27, 2024 6

Okay sounds good, I can create a patch today. I've updated this issue with the picks I'm going to be taking which are all already on main

from releases.

lubomyr avatar lubomyr commented on May 27, 2024 5

request (fix ios release build via xcode)
facebook/react-native@cc59a7c

from releases.

svbutko avatar svbutko commented on May 27, 2024 2

Kotlin and Gradle bump maybe if possible, if not maybe in 0.67:
facebook/react-native@9ae3367

from releases.

mikehardy avatar mikehardy commented on May 27, 2024 2

That PR (32398) hasn't landed (since you made it...2 hours ago :-) ) but I just looked and it looks great IMHO

from releases.

lunaleaps avatar lunaleaps commented on May 27, 2024 2

Let's have any 0.66.2 in this discussion: reactwg/react-native-releases#3

from releases.

mikehardy avatar mikehardy commented on May 27, 2024 1

Kotlin and Gradle bump maybe if possible, if not maybe in 0.67: facebook/react-native@9ae3367

Just to note that I'm running those locally in 4 react-native 0.66 projects (two of which have big e2e harnesses, 2 of which are deployed on app stores) and they work fine as far as I can tell, no breaks seen when I moved on those

[edit to add that's just a success report, probably doesn't make sense for a patch release as it's not fixing a bug in react-native, per se]

from releases.

svbutko avatar svbutko commented on May 27, 2024

Android appearance module fix
facebook/react-native@25a2c60

from releases.

lunaleaps avatar lunaleaps commented on May 27, 2024

please revert facebook/react-native@1b0fb9b Related Discussion facebook/react-native#31461 facebook/react-native#28236 (comment)

Has this been reverted on main?

from releases.

radko93 avatar radko93 commented on May 27, 2024

@svbutko I don't that will be included in 0.66.x. You can also upgrade gradle yourself.

from releases.

svbutko avatar svbutko commented on May 27, 2024

@svbutko I don't that will be included in 0.66.x. You can also upgrade gradle yourself.

That's for the RN template, if it won't be in 0.66.x I mentioned that it would be fine to include it in 0.67

from releases.

svbutko avatar svbutko commented on May 27, 2024

Kotlin and Gradle bump maybe if possible, if not maybe in 0.67: facebook/react-native@9ae3367

Just to note that I'm running those locally in 4 react-native 0.66 projects (two of which have big e2e harnesses, 2 of which are deployed on app stores) and they work fine as far as I can tell, no breaks seen when I moved on those

[edit to add that's just a success report, probably doesn't make sense for a patch release as it's not fixing a bug in react-native, per se]

Same thing, I just wanted to note about since there's no 0.67 discussion yet

from releases.

aliraza-noon avatar aliraza-noon commented on May 27, 2024

@mikehardy it has been merged so i think we good to pick

from releases.

mikehardy avatar mikehardy commented on May 27, 2024

@aliraza-noon indeed! @lunaleaps merged it in facebook/react-native@d1a33cd and since they own this issue I'll assume they know the pick, but I'm committing here to close the loop in this thread. 🚀

from releases.

lfiorini avatar lfiorini commented on May 27, 2024

-- what do you guys think?

The Android appearance module fix facebook/react-native@25a2c60 is a block for my app.

from releases.

divinghero avatar divinghero commented on May 27, 2024

from 0.63.4 to 0.66.1,encounter this:
ios/Pods/Headers/Public/RCT-Folly/folly/math.h:26:10: 'cmath' file not found
ios/Pods/Headers/Public/React-Core/React/RCTConvert.h:17:9: Could not build module 'yoga'
image

from releases.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.