Code Monkey home page Code Monkey logo

Comments (17)

Theofilos-Chamalis avatar Theofilos-Chamalis commented on May 27, 2024 14

First of all thank you very much for the release of v0.65! I 've tested it on an existing app and with Hermes enabled it feels even snappier on Android :)

What I'd like to request for v0.65.1 if possible is a bugfix that was mentioned on the v0.65 discussion about the taps on views outside parent bounds that are not working on Android. The PR link (if I am correct) is the following: facebook/react-native@e35a963 and hopefully we could see this in the next release!

Cheers and thanks again for your work!

from releases.

taylorkline avatar taylorkline commented on May 27, 2024 10

facebook/react-native@842bcb9 should fix a regression on Android where suddenly some components are transparent. Would be nice to have cherry-picked if it applies cleanly.

from releases.

gaodeng avatar gaodeng commented on May 27, 2024 7

facebook/react-native#31461 RefreshControl causes an unwanted visual jump in the list content when the refreshing prop goes from true to false

The commit causing the problem is this one facebook/react-native@1b0fb9b, PR is this one facebook/react-native#28236
Can you revert this commit?

@dandre-hound it is safe to rollback this commit if you don't use navigation large headers. Will work on a fix asap.

Originally posted by the PR author @yogevbd in facebook/react-native#28236 (comment)

from releases.

kelset avatar kelset commented on May 27, 2024 6

the 4 commits listed in the top post are cherry picked cleanly - already on the 0.65 branch. Local testing looks ✅ just waiting for a couple feedbacks then probably we'll do a quick 0.65.1 before end of the week

from releases.

kelset avatar kelset commented on May 27, 2024 3

gotcha, thanks @matt-oakes 👍

from releases.

nextlevelbeard avatar nextlevelbeard commented on May 27, 2024 3

I believe the test automation community would highly appreciate these:
facebook/react-native@efb359f (facebook/react-native#31865)
facebook/react-native@91cac20 (facebook/react-native#31942)

Small but important fixes to the testID prop on Android builds.
It is currently not working with certain important components like TextInput and ScrollView.

from releases.

TheSavior avatar TheSavior commented on May 27, 2024 1

First of all thank you very much for the release of v0.65! I 've tested it on an existing app and with Hermes enabled it feels even snappier on Android :)

What I'd like to request for v0.65.1 if possible is a bugfix that was mentioned on the v0.65 discussion about the taps on views outside parent bounds that are not working on Android. The PR link (if I am correct) is the following: facebook/react-native@e35a963 and hopefully we could see this in the next release!

Cheers and thanks again for your work!

That change is pretty major, and while it makes sense that people want it in a release, it might make sense to bake it longer at Facebook in case it needs to be reverted or tweaked to be stable at scale in the Facebook app.

from releases.

truongngodang avatar truongngodang commented on May 27, 2024 1

I got a issue when start app build release on ios rn 0.65 'RCTFatalException: Could not get BatchedBridge, make sure your bundle is packaged correctly', reason: 'Could not get BatchedBridge, make sure your bundle is packaged correctly'

from releases.

mrousavy avatar mrousavy commented on May 27, 2024 1

@truongngodang does that happen in the bare React Native template or in your own app? If it's happening in your own app, please check if it's also happening in the template. If not, you might have missed something while upgrading.

from releases.

kelset avatar kelset commented on May 27, 2024 1

@vskavgaci I don't know where you've found that commit but is not in the repo:
Screenshot 2021-08-19 at 11 11 52

So it can't be cherry picked

from releases.

matt-oakes avatar matt-oakes commented on May 27, 2024 1

@kelset It looks to be from this unmerged PR. So yes, it can't be cherry picked until it's merged in

from releases.

Bardiamist avatar Bardiamist commented on May 27, 2024

I noticed that react-test-renderer still 17.0.1 in RN 0.65.0. But react is up to 17.0.2. Should I use 17.0.1 or 17.0.2? Maybe need to cherry pick facebook/react-native@d272880

from releases.

kelset avatar kelset commented on May 27, 2024

@Bardiamist good catch, I'll add it to the list

from releases.

vskavgaci avatar vskavgaci commented on May 27, 2024

log keypress events from numeric keys on android fix facebook/react-native@bd52916

from releases.

Bardiamist avatar Bardiamist commented on May 27, 2024

facebook/react-native@842bcb9 should fix a regression on Android where suddenly some components are transparent. Would be nice to have cherry-picked if it applies cleanly.

Yea, seems I waiting this fix because after update to React native 0.65.0 a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button).

from releases.

dandre-hound avatar dandre-hound commented on May 27, 2024

Yeah, the team @tradehounds is surprised that this pull to refresh issue mentioned above has been present in the last two minor react-native releases. It's pretty disruptive to the user experience when using lists. It's also very easily reproducible and could be cleanly reverted. We've been waiting to upgrade until this is either reverted or a fix from the original PR author is merged in. Would love to see this commit reverted until then :)

from releases.

kelset avatar kelset commented on May 27, 2024

hey folks, we wanted to make sure to do a quick patch with the few important fixes right away so we have already released a 0.65.1 release.

Let's move the conversation here for 0.65.2 -> #245 (which won't come out as fast)

from releases.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.