Comments (5)
I'm not sure what you're talking about, exactly. Ideally, the test adapter works like the other adapters as much as possible.
from faraday.
I am doing this request:
Faraday.get do |req|
req.url "foo", :bar => "bãz"
end
If I add the following stub:
stubs.get "foo?bar=bãz"
The stub won't match because the connection object will escape the query and then "baz" will become "b%C3%A3z". So one proposal is that all URLs passed to stubs.METHOD is properly escaped as well.
from faraday.
I think you'd need a similar API then:
stubs.get 'foo', :bar => "bãz"
stubs.get "foo?a=1", :bar => "bãz"
I would expect anything passed in as a URL to be properly encoded already.
from faraday.
The stubs API for .get is the same as Faraday::Connection#get, the issue is that none of them accepts params. The only way to pass some parameter is by accessing the request object (which is when they get escaped).
from faraday.
Closing...
from faraday.
Related Issues (20)
- Typo in Adapters documentation
- URL not included in response hash HOT 2
- Support for Ubuntu 22.04, using OpenSSL 3.0.2 (i.e. Heroku 22) HOT 1
- ArgumentError due to missing ruby2_keywords on Ruby 3.2.0 HOT 4
- 2.7.3 breaks compatibility with Addressable as URI parser HOT 5
- Impossible to make request with same-name multi-value headers HOT 6
- Remove `default_uri_parser` config HOT 3
- Header matching inconsistency with strict_mode and verify_stubbed_calls HOT 4
- Fix YARD doc for Options HOT 1
- Faraday::ConnectionFailed if proxy: "" is passed on Ruby 3.2.1
- Block private ips (allow_private_ips) HOT 3
- Multiple "already initialized constant" warnings HOT 2
- NoMethodError: undefined method `method=' for #<Faraday::RequestOptions (empty) HOT 5
- Faraday::Response - argument order causes unexpected behaviour HOT 3
- Incompatible with Firebase-admin-sdk HOT 1
- Streaming Stop with Connection Close? HOT 3
- `Faraday::Request::Json` doesn't encode the value `false` while it encodes `true` to `"true"` HOT 2
- Lots of "warning: method redefined; discarding old" printed during testing HOT 7
- Faraday using PUT with Transfer-Encoding: chunked
- Faraday::ParsingError.response_status doesn't return expected value when stubbing response HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faraday.