Code Monkey home page Code Monkey logo

Comments (5)

technoweenie avatar technoweenie commented on July 16, 2024

I'm not sure what you're talking about, exactly. Ideally, the test adapter works like the other adapters as much as possible.

from faraday.

josevalim avatar josevalim commented on July 16, 2024

I am doing this request:

Faraday.get do |req|
  req.url "foo", :bar => "bãz"
end

If I add the following stub:

stubs.get "foo?bar=bãz"

The stub won't match because the connection object will escape the query and then "baz" will become "b%C3%A3z". So one proposal is that all URLs passed to stubs.METHOD is properly escaped as well.

from faraday.

technoweenie avatar technoweenie commented on July 16, 2024

I think you'd need a similar API then:

stubs.get 'foo', :bar => "bãz"
stubs.get "foo?a=1", :bar => "bãz"

I would expect anything passed in as a URL to be properly encoded already.

from faraday.

josevalim avatar josevalim commented on July 16, 2024

The stubs API for .get is the same as Faraday::Connection#get, the issue is that none of them accepts params. The only way to pass some parameter is by accessing the request object (which is when they get escaped).

from faraday.

josevalim avatar josevalim commented on July 16, 2024

Closing...

from faraday.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.