Code Monkey home page Code Monkey logo

Comments (3)

iMacTia avatar iMacTia commented on September 17, 2024

Hi @miguelrod I'm sorry but to my knowledge, there's such option in Faraday (or in any Ruby http library?).

I'm not really sure about the value in adding this check to Faraday, as you can easily test if the IP you're passing to the connection is private yourself.

I'm closing this for now, but feel free to let me know if you'd like to discuss this further

from faraday.

miguel-s-rodrigues avatar miguel-s-rodrigues commented on September 17, 2024

Hi @iMacTia 👋

Thank you for getting back to me, appreciate the info.

However, the issue here is that we're using your redirect class and, thus, the check for the IP address could be done before following up on a redirect. Otherwise, we can't follow up on your redirects at all... since we need to check the IP address before connecting to it.

from faraday.

iMacTia avatar iMacTia commented on September 17, 2024

Ah, I see the issue.
Are you using faraday-follow_redirects?

That middleware has a callback option that you can use to check the new URL

from faraday.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.