2.7.3 breaks compatibility with Addressable as URI parser about faraday HOT 5 CLOSED

Hm, would it be possible to use URI::Generic's https://rubyapi.org/2.5/o/uri/generic#method-i-check_opaque

from faraday.

Apologies about that @pharmaceutics.
I've checked the code and indeed Utils.URI can be configured to use other parsers as well, but in this scenario we need to call opaque which is not a very standard method.

I don't like this open-ended configurability, since we don't have a way to enforce that the configured parser returns an object that behaves exactly like a URI, but I'm happy to change this to bring back compatibility as it was before.

Just as a curiosity, why do you override the default_uri_parser?

from faraday.

@pharmaceutics PR with a fix is merged and released as v2.7.4 👍

I'd still be interested to hear about your use-case to use Addressable::URI as a parser, if possible 🙏

from faraday.

@iMacTia thanks a lot! The actual parser in the code looked like this

Faraday::Utils.default_uri_parser = -> (v) { Addressable::URI.parse(v).normalize }

and two use cases I see tested are handling IDNAs and path parts with invalid characters that both wouldn't normally work (for example, with Addressable https://はじめよう.みんな/some|path is automatically encoded as https://xn--p8j9a0d9c9a.xn--q9jyb4c/some%7Cpath)
But there's probably no real reason why the URL couldn't be normalized separately first, with Faraday getting an already encoded version that would work with the regular Kernel#URI

from faraday.

Thanks @pharmaceutics, it doesn't seem like an extremely useful feature and it does create some maintainance issues, so it's likely we'll remove it on the next major version.

from faraday.