Comments (2)
Great catch @yykamei, I think you spot a valid bug.
I had a quick look and yes, according to the JSON specification true
or false
are valid JSON payloads like any other scalar value (like a single string or number).
So false
should be encoded into "false"
as you'd expect.
There's also the extreme edge-case scenario where you might want to send a plain null
value, which is interestingly also a valid JSON! But we can leave that for another day 😄
Would you have some time to open a PR to fix the false
edge case and add some tests?
from faraday.
Thank you for your reply! I'll do that 💪
There's also the extreme edge-case scenario where you might want to send a plain
null
value, which is interestingly also a valid JSON! But we can leave that for another day 😄
Yes, I agree with you. there could be null
body. I guess there could be programs that make the payload by putting nil
to env[:body]
, so I will keep it as is.
from faraday.
Related Issues (20)
- Unable to use webdav verbs HOT 3
- Change connection proxy HOT 2
- Drop Ruby < 3.0 support HOT 1
- `no_proxy` Parameter in Manual Proxy Configuration HOT 4
- connection headers are ignored when using build_response directly HOT 5
- Add tests and documentation to make sure adapters support streaming requests HOT 2
- Any solution for Digest Auth in Faraday 2? HOT 2
- Case Insensitivity Issue with #dig Method on Response Headers HOT 1
- Test friction HOT 2
- Is it possible when stubbing to execute the original request? HOT 2
- Allow not setting Content-Length when Transfer-Encoding header is set HOT 1
- Some API providers cannot interpret encoded colons in the path HOT 6
- Faraday removes preconfigured URI from instance on requests HOT 2
- Would you be open to me contributing a `#clear` method in `Faraday::Adapter::Test::Stubs`? HOT 1
- Support for chained client certificates? HOT 6
- Connecting to unix domain sockets HOT 3
- Add ciphers to SSL options HOT 6
- Async::HTTP::Faraday cannot use "in_parallel" HOT 6
- Support ciphers SSLOptions setting across adapters HOT 3
- Feature Suggestion: Make RaiseError middleware configurable to not raise error on certain status codes (e.g. 404) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faraday.