Comments (4)
facing the same issue
from faraday.
Thank you @anero, I was reading through Ruby 3.2 release notes and figured this change might cause some issues.
At the time we decided to remove it because it wasn't causing any issues, but I agree we should now follow Ruby 3.2 requirements.
Please feel free to open a PR and address this. Ideally I'd like to fix the main
branch first, and we can then backport the fix over to 1.x
as I assume the same issue would affect main
as well?
It goes without saying we would need a test to demonstrate this as well. I'm surprised none of our tests failed but I guess that's because we never test adding a middleware with keyword arguments
from faraday.
Fixed in #1483.
from faraday.
And released! Closing this issue.
from faraday.
Related Issues (20)
- Streaming Stop with Connection Close? HOT 3
- `Faraday::Request::Json` doesn't encode the value `false` while it encodes `true` to `"true"` HOT 2
- Lots of "warning: method redefined; discarding old" printed during testing HOT 7
- Faraday using PUT with Transfer-Encoding: chunked
- Faraday::ParsingError.response_status doesn't return expected value when stubbing response HOT 5
- Missing HTTP 408 Request Timeout specific Faraday ClientError? HOT 3
- Dead link to Faraday Team in README and docs HOT 1
- Strange behaviour with response HOT 1
- Setting ActiveRecord DatabaseResolver to enable multi database does not work with Faraday adapter HOT 3
- Unable to use webdav verbs HOT 3
- Change connection proxy HOT 2
- Drop Ruby < 3.0 support HOT 1
- `no_proxy` Parameter in Manual Proxy Configuration HOT 4
- connection headers are ignored when using build_response directly HOT 5
- Add tests and documentation to make sure adapters support streaming requests HOT 2
- Any solution for Digest Auth in Faraday 2? HOT 2
- Case Insensitivity Issue with #dig Method on Response Headers HOT 1
- Test friction HOT 2
- Is it possible when stubbing to execute the original request? HOT 2
- Allow not setting Content-Length when Transfer-Encoding header is set HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faraday.