response_headers return nil instead of {} when blank about faraday HOT 4 CLOSED

refactor how adapters save response params to env

Ensures :response_headers always get initialized

Closed by b85e0a1

from faraday.

Thanks for catching this bug. How did you detect this, if I may ask? Only net_http and em_synchrony adapters were affected by the bug, but I couldn't make a failing test case in our "live" test suite because I don't know how to make Sinatra + Webrick respond with no HTTP headers :/

from faraday.

I was been working on a faraday-0.6 branch of the twitter gem and had to apply this patch to make specs pass, which clued me in that the behavior had changed since 0.5.

Thanks for the quick fix! Are you planning to release 0.6.1 soon?

from faraday.

Ah I see what happened in the twitter library. You're using webmock and you probably stubbed a HTTP response that returned empty headers. That never happens in real HTTP, that's why I don't think this bug is huge.

Still, since it can bite developers like you in their test suites, I guess I'll make a bugfix release soon.

from faraday.