Code Monkey home page Code Monkey logo

Comments (3)

fenomas avatar fenomas commented on June 7, 2024

Hi, nice catch. The intent there was that remeshing isn't needed when a non-solid non-opaque object block changes into air, but I was only checking if the new block is terrain, and not the old.

I will replace it with something like:

    var wasTerrain = (!objOld && (oldID !== 0))
    var nowTerrain = (!objNew && (newID !== 0))
    if (solidityChanged || opacityChanged || wasTerrain || nowTerrain) {
        this._terrainDirty = true
    }

from noa.

MCArth avatar MCArth commented on June 7, 2024

ah yes, I don't have any opaque objects but that does make sense - looks good

from noa.

fenomas avatar fenomas commented on June 7, 2024

Ok thanks! This is done and I'll push it soon.

from noa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.