Comments (5)
One problem with exposing List.Enumerator is that you are going to break ABI compatibility if you switched the underlying collection.
from unity-reorderable-list.
That is true, but is also quite unlikely to happen? And even if the impl. would change it is even more unlikely that anyone will ever declare a variable of this explicit type. i.e. List < XYZ >.Enumerator e = stuff.GetEnumerator(); It is most likely to nearly always be used in foreach loops or if explicitly stored in a variable then by using var e = ...; so for the sake of performance which is paramount in game dev it is imho a risk worth considering to take.
from unity-reorderable-list.
Oh, yeah, no, I completely agree. I was just putting out the possible ABI break so a custom enumerator struct is used that is specific to this type.
That way ABI compat issues can be avoided alltogether by having ReorderableList.Enumerator wrap the underlying list enumerator.
So you can modify implementation details in the future without breaking ABI.
from unity-reorderable-list.
Yes, that would be a sufficient solution, albeit with a small overhead in non optimized scenarios, but still much better than using the IEnumerator. Can we get a comment from the author on this? Should be a 10 min fix.
from unity-reorderable-list.
Hey, I'm super busy with another project right now. If you could add a pull request with the change, I'll approve it
from unity-reorderable-list.
Related Issues (20)
- Screenshots
- Recursion HOT 1
- Unable to load the icon: 'MiniPopupNoBg'. HOT 1
- Adding element to list via code throws error when multiple objects with reorderable list are selected
- Nested list unity lag HOT 2
- Is there anyway to add names to each element in the draggable list.
- New elements added without correct default values. HOT 2
- Possible to use in an editor window? HOT 3
- DrawElementCallback foldout issue HOT 2
- Inner Array Attributes HOT 3
- Strange Property Size on First Layout
- Package fails to add on Unity 2019.3 HOT 1
- Version control HOT 2
- Paging based on certain features or callbacks
- Select Object Popup not working HOT 2
- Reorderable item force jump to the top HOT 1
- List of base class does not draw the inheritance attributes HOT 1
- asmdef conflicts with System.Collections.Generic
- ReorderableList.onChangedCallback did not dispatch, when drag finished. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unity-reorderable-list.