Code Monkey home page Code Monkey logo

Comments (9)

jerryz123 avatar jerryz123 commented on July 24, 2024

This looks like it's fixed right now on the master branch. We'll push a release by the end of the week.

from chipyard.

zephray avatar zephray commented on July 24, 2024

Hi, thanks for your quick reply! However I am already on the latest main branch (#26f86d). Maybe I am missing something, or the behavior is actually expected and the old 1.8.1 release behavior is wrong?

from chipyard.

jerryz123 avatar jerryz123 commented on July 24, 2024

No, it should definitely be generating ports...this is what I see on 9ef3001 :

module ChipTop(                                                                                                      
  input         serial_tl_bits_in_valid,                                                                             
  input  [31:0] serial_tl_bits_in_bits,                                                                              
  input         serial_tl_bits_out_ready,                                                                            
                axi4_mmio_0_bits_aw_ready,                                                                           
                axi4_mmio_0_bits_w_ready,                                                                            
                axi4_mmio_0_bits_b_valid,                                                                            
  input  [3:0]  axi4_mmio_0_bits_b_bits_id,                                                                          
  input  [1:0]  axi4_mmio_0_bits_b_bits_resp,                                                                        
  input         axi4_mmio_0_bits_ar_ready,                                                                           
                axi4_mmio_0_bits_r_valid,                                                                            
  input  [3:0]  axi4_mmio_0_bits_r_bits_id,                                                                          
  input  [63:0] axi4_mmio_0_bits_r_bits_data,                                                                        
  input  [1:0]  axi4_mmio_0_bits_r_bits_resp,                                                                        
  input         axi4_mmio_0_bits_r_bits_last,                                                                        
                custom_boot,                                                                                         
                clock_clock,                                                                                         
                reset,                                                                                               
                jtag_TCK,                                                                                            
                jtag_TMS,                                                                                            
                jtag_TDI,                                                                                            
                uart_0_rxd,                                                                                          
  output        serial_tl_clock,                                                                                     
                serial_tl_bits_in_ready,                                                                             
                serial_tl_bits_out_valid,                                                                            
  output [31:0] serial_tl_bits_out_bits,                                                                             
  output        axi4_mmio_0_clock,                                                                                   
                axi4_mmio_0_reset,                                                                                   
                axi4_mmio_0_bits_aw_valid,                                                                           
  output [3:0]  axi4_mmio_0_bits_aw_bits_id,                                                                         
  output [30:0] axi4_mmio_0_bits_aw_bits_addr,                                                                       
  output [7:0]  axi4_mmio_0_bits_aw_bits_len,                                                                        
  output [2:0]  axi4_mmio_0_bits_aw_bits_size,                                                                       
  output [1:0]  axi4_mmio_0_bits_aw_bits_burst,                                                                      
  output        axi4_mmio_0_bits_aw_bits_lock,                                                                       
  output [3:0]  axi4_mmio_0_bits_aw_bits_cache,                                                                        output [2:0]  axi4_mmio_0_bits_aw_bits_prot,                                                                         output [3:0]  axi4_mmio_0_bits_aw_bits_qos,                                                                          output        axi4_mmio_0_bits_w_valid,                                                                              output [63:0] axi4_mmio_0_bits_w_bits_data,                                                                          output [7:0]  axi4_mmio_0_bits_w_bits_strb,                                                                          output        axi4_mmio_0_bits_w_bits_last,                                                                                        axi4_mmio_0_bits_b_ready,                                                                                            axi4_mmio_0_bits_ar_valid,                                                                             output [3:0]  axi4_mmio_0_bits_ar_bits_id,                                                                           output [30:0] axi4_mmio_0_bits_ar_bits_addr,                                                                         output [7:0]  axi4_mmio_0_bits_ar_bits_len,                                                                        
  output [2:0]  axi4_mmio_0_bits_ar_bits_size,                                                                       
  output [1:0]  axi4_mmio_0_bits_ar_bits_burst,                                                                      
  output        axi4_mmio_0_bits_ar_bits_lock,                                                                       
  output [3:0]  axi4_mmio_0_bits_ar_bits_cache,
  output [2:0]  axi4_mmio_0_bits_ar_bits_prot,
  output [3:0]  axi4_mmio_0_bits_ar_bits_qos,
  output        axi4_mmio_0_bits_r_ready,
                jtag_TDO,
                uart_0_txd
);

from chipyard.

zephray avatar zephray commented on July 24, 2024

That's interesting, I deleted my local repo and started from scratch with 9ef3001, now I can getting the same result as you have. However, isn't this still wrong? The MMIO port is present, but the front bus port is still missing.

from chipyard.

kgreig87 avatar kgreig87 commented on July 24, 2024

I'm also seeing the same issue as @zephray - DigitalTop contains a MMIO port, but is missing a Front Port.

from chipyard.

jerryz123 avatar jerryz123 commented on July 24, 2024

Yeah, I'm looking into this.

from chipyard.

jerryz123 avatar jerryz123 commented on July 24, 2024

The latest commit on this branch: https://github.com/ucb-bar/chipyard/pull/1399/files#diff-e72d7730b5de7057f15f513757aa310c4a51b21e8d5d0e1cb7b206b132e802d9 should fix this.

from chipyard.

kgreig87 avatar kgreig87 commented on July 24, 2024

Thanks Jerry, this resolved the issue. I also like what you're adding with the custom IO cells

from chipyard.

zephray avatar zephray commented on July 24, 2024

Awesome, thanks jerry, just tried and it works great! Should I close the issue or wait for the PR to be merged first?

from chipyard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.