Comments (4)
Kryptos-FR
commented on July 17, 2024
2
First of all, congrats for the #666 issue 😈
Secondly, could you update the description and provide a link to the related file(s) in the sources?
from xenko.
guygodin
commented on July 17, 2024
1
It should be a list since it is iterated over a lot (iterating over lists performs better than dictionaries). The solution is to iterate over the items of the list in the Remove method and check for KeyValuePair.Key equality like it’s done elsewhere in my opinion.
from xenko.
guygodin
commented on July 17, 2024
Woah wicked! Links added to issue.
from xenko.
stefnotch
commented on July 17, 2024
More info regarding this issue:
The AddGameSystem call specifies a ProfilingKey as the KeyValuePair.Value
Also, according to this answer, "[A KeyValuePair] is a struct. This means it uses the default value equality. This simply compares the values of the fields to test for equality." So, this is almost certainly a bug.
Lastly,updateableGameSystems is a normal C# list instead of a seemingly more fitting dictionary?
from xenko.
Related Issues (20)
- v2.1.2.1 Crashing on startup HOT 4
- RequireComponentAttribute unuseable HOT 3
- Check [NotNull] in the game studio HOT 2
- Corrupted Project HOT 1
- TrackingCollectionChangedEventArgs Generics HOT 2
- Error while loading assembly reference HOT 2
- Shader Compilation fails and corrupt .sln when Generics changed
- Game crashes on startup because it can't connect to Xenko connection router HOT 3
- SamplerState.OpenGL doesn't properly set the MaxAnisotropy parameter
- Audio not working in 64bit builds on Android
- Compressed Cubemap textures end up black on Android
- Script files created in Visual Studio are overwritten with blank file. HOT 1
- CPU/GPU soars when game form are minimized
- Unable to get data from IndexBuffer or VertexBuffer with OpenGL
- Input.IsMouseButtonDown bugged when multiple mouse buttons are held down
- TextInput bug HOT 1
- the engine crashes HOT 1
- Missing cleanup on uninstall HOT 2
- Can't clone the project from git
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xenko.