shisatoyano / autonomousvehiclecontrolbeginnersguide Goto Github PK

Thanks for the great work with this library. I have a feature request though.

Currently, in order to find the other files in the project, you add them to the path manually. This is not a good practice in general and leads to several problems. One of them is I am not able to get any Language Server completions since LSP can't recognize the path additions. This makes navigating the code much harder. Also, with this hardcoded addition, the library cannot be installed and used with other libraries. For example, if I had a different mapper than NDT, i can't use it with the existing code easily without making additions to your library as well which would make it difficult to keep up with the newer Github releases.

My suggestion is to package the project using pyproject.toml so that library users can install this to their machine and get full LSP support and flexibility in adding additional stuff.

One more suggestion is also use a linter and formatter such as ruff. It would greatly help in organizing the imports, enforce good code and provide better readibility.

If you are open to it, I can add pyproject support with tooling.