[proposal] Allow Custom Generator Options about scalapb HOT 5 CLOSED

Hi @Joshua-Scurr ,
I read the write up a few times and trying to make sure I understand the problem you are trying to solve. Here's what I got: you generate an OpenAPI JSON file using your own protoc plugin, and you want the generated file to include a version number that is avaialable as a value in SBT. It is possible to pass custom parameters to protoc plugins through sbt-protoc. If you follow writing custom plugins look for request.parameters to see how these can become available in your code generator.

from scalapb.

That sounds correct; thank you - I will have a look at that this morning

from scalapb.

@thesamet it looks like indeed this is turned into a closed vocabulary of parameters, here:

do you think we could change GeneratorParams to:

case class GeneratorParams(
    javaConversions: Boolean = false,
    flatPackage: Boolean = false,
    grpc: Boolean = false,
    singleLineToProtoString: Boolean = false,
    asciiFormatToString: Boolean = false,
    lenses: Boolean = true,
    retainSourceCodeInfo: Boolean = false,
    customOptions: List[String] = Nil
)

... then all the unrecognized options end up in customOptions and do not generate an error?

from scalapb.

The success type of fromStringCollectUnrecognized is a (GeneratorParams, Seq[String]). The Seq[String] represents all the options that are not ScalaPB options, for third-party code generators to process further.

from scalapb.

That looks to have been the answer. Many thanks!
EDIT: Confirming this worked for us. Closing the issue.

from scalapb.