When using collection_type if a proto file contains a

`collection_type` and `extends` with a `repeated` field does not compile about scalapb HOT 4 CLOSED

guymers commented on June 4, 2024

`collection_type` and `extends` with a `repeated` field does not compile

from scalapb.

Comments (4)

guymers commented on June 4, 2024 1

Everything compiles with 0.11.13+37-3d0668d2-SNAPSHOT, cheers

from scalapb.

thesamet commented on June 4, 2024

Thanks for the report. I was able to reproduce. A fix will be coming soon.

from scalapb.

guymers commented on June 4, 2024

My apologies, I only included the first two errors in the issue. Thank you for fixing those but the same issue seems to be occurring on "packable" fields:

[error] target/scala-2.13/src_managed/main/com/google/api/field_behavior/FieldBehaviorProto.scala:38:125: polymorphic expression cannot be instantiated to expected type;
[error]  found   : [C <: scalapb.ExtendableMessage[C]]scalapb.GeneratedExtension[C,Seq[com.google.api.field_behavior.FieldBehavior]]
[error]  required: scalapb.GeneratedExtension[com.google.protobuf.descriptor.FieldOptions,scala.collection.immutable.Vector[com.google.api.field_behavior.FieldBehavior]]
[error]     _root_.scalapb.GeneratedExtension.forRepeatedUnknownFieldPackable(1052, _root_.scalapb.UnknownFieldSet.Field.varintLens)({__valueIn => com.google.api.field_behavior.FieldBehavior.fromValue(__valueIn.toInt)}, {(__valueIn: com.google.api.field_behavior.FieldBehavior) => __valueIn.value.toLong}, _.readInt64()
[error]                                                                                                                             ^
[error] target/scala-2.13/src_managed/main/com/google/api/field_behavior/FieldBehaviorProto.scala:38:70: type mismatch;
[error]  found   : scalapb.GeneratedExtension[C,Seq[com.google.api.field_behavior.FieldBehavior]]
[error]  required: scalapb.GeneratedExtension[com.google.protobuf.descriptor.FieldOptions,scala.collection.immutable.Vector[com.google.api.field_behavior.FieldBehavior]]
[error]     _root_.scalapb.GeneratedExtension.forRepeatedUnknownFieldPackable(1052, _root_.scalapb.UnknownFieldSet.Field.varintLens)({__valueIn => com.google.api.field_behavior.FieldBehavior.fromValue(__valueIn.toInt)}, {(__valueIn: com.google.api.field_behavior.FieldBehavior) => __valueIn.value.toLong}, _.readInt64()

extend google.protobuf.FieldOptions {
  repeated google.api.FieldBehavior field_behavior = 1052;
}

from scalapb.

thesamet commented on June 4, 2024

Thanks for catching that this issue happens for both packable and non-packable fields. Fix is in. We do have a snapshot release built for each commit - it would be great if you can test version 0.11.13+37-3d0668d2-SNAPSHOT.

from scalapb.

Recommend Projects