Code Monkey home page Code Monkey logo

Comments (8)

thesamet avatar thesamet commented on May 24, 2024

Can you provide step-by-step instructions on how to reproduce the problem you are seeing?

from scalapb.

shikai93 avatar shikai93 commented on May 24, 2024

I've setup a small sample project here: https://github.com/shikai93/scalapb-test
I hope thats helpful ~
It only contains the scalapb.proto and google well-known protos.

from scalapb.

thesamet avatar thesamet commented on May 24, 2024

Can you include the project directory and build.sbt files? Is it possible that you are trying to generate Scala or Java code for protos in protos/google/protobuf which already have classes generated for?

from scalapb.

thesamet avatar thesamet commented on May 24, 2024

It looks like it is generating code for messages that are already included with protobuf-java here: https://github.com/shikai93/scalapb-test/blob/24c0e187c5d9aa9e1ea15eb78d792c85d7bab630/scala/project/Settings.scala#L18

They can be made available by adding:

libraryDependencies += "com.thesamet.scalapb" %% "scalapb-runtime" % scalapb.compiler.Version.scalapbVersion % "protobuf"

from scalapb.

shikai93 avatar shikai93 commented on May 24, 2024

they are actually within the scala folder, let me pull them up one level.

you are right that i am trying to generate the messages already included. But i did not integrate in the relevant dependencies for common-proto
libraryDependencies ++= Seq( "com.thesamet.scalapb.common-protos" %% "proto-google-common-protos-scalapb_0.11" % "2.9.6-0" % "protobuf", "com.thesamet.scalapb.common-protos" %% "proto-google-common-protos-scalapb_0.11" % "2.9.6-0" )
so i was under the impression that this clash would not occur

from scalapb.

thesamet avatar thesamet commented on May 24, 2024

But i did not integrate in the relevant dependencies for common-proto

The one causing the problem are the one in google/protobuf which are included in scalapb-runtime for Scala and protobuf-java for Java.

from scalapb.

shikai93 avatar shikai93 commented on May 24, 2024

I see, i think this was a change induced in 0.11.14?
But yes, changing them to includePath worked for my case, updated my test case repo, thanks for the help! I shall close this issue

from scalapb.

thesamet avatar thesamet commented on May 24, 2024

The error seems to appear in the Java generated code, maybe there's a bump in the protoc version somewhere in your toolchain that triggered it, but it's odd that this set up ever worked.

from scalapb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.