Code Monkey home page Code Monkey logo

samvera / hyrax Goto Github PK

View Code? Open in Web Editor NEW
182.0 63.0 122.0 211.75 MB

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.

Home Page: http://hyrax.samvera.org/

License: Apache License 2.0

Ruby 83.34% JavaScript 4.64% HTML 9.39% CSS 0.06% CoffeeScript 0.39% XSLT 0.81% Dockerfile 0.06% Shell 0.08% SCSS 1.10% Mustache 0.12% Smarty 0.02%
repository sufia rails hydra-community fcrepo blacklight hyrax samvera samvera-community

hyrax's People

Contributors

abelemlih avatar adamjarling avatar alishaevn avatar atz avatar awead avatar blancoj avatar bwatson78 avatar carolyncole avatar cbeer avatar cjcolvar avatar dancoughlin avatar dlpierce avatar dunn avatar elrayle avatar escowles avatar flyingzumwalt avatar grosscol avatar hackartisan avatar hectorcorrea avatar jcoyne avatar jeremyf avatar jmfrenzel avatar lsitu avatar marrus-sh avatar mjgiarlo avatar no-reply avatar orangewolf avatar revgum avatar straleyb avatar tpendragon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

hyrax's Issues

Jasmine test fails quite regularly on travis.

What's interesting is that the spec count: 183 specs is often not correct.

************************  Jasmine Output *************

Output: Puma starting in single mode...

* Version 3.6.2 (ruby 2.3.3-p222), codename: Sleepy Sunday Serenity

* Min threads: 0, max threads: 16

* Environment: test

* Listening on tcp://0.0.0.0:36595

Use Ctrl-C to stop

Waiting for jasmine server on 36595...

jasmine server started

............................F..........................................................................................................................................................

Failures:

          SaveWorkControl validateFiles when a required files are missing is incomplete

          Expected 0 to equal 1.

          stack@http://localhost:36595/__jasmine__/jasmine.js:1640:37

buildExpectationResult@http://localhost:36595/__jasmine__/jasmine.js:1610:19

expectationResultFactory@http://localhost:36595/__jasmine__/jasmine.js:655:40

addExpectationResult@http://localhost:36595/__jasmine__/jasmine.js:342:58

addExpectationResult@http://localhost:36595/__jasmine__/jasmine.js:599:41

http://localhost:36595/__jasmine__/jasmine.js:1564:32

http://localhost:36595/__spec__/save_work_spec.js:123:59

          Expected 1 to equal 0.

          stack@http://localhost:36595/__jasmine__/jasmine.js:1640:37

buildExpectationResult@http://localhost:36595/__jasmine__/jasmine.js:1610:19

expectationResultFactory@http://localhost:36595/__jasmine__/jasmine.js:655:40

addExpectationResult@http://localhost:36595/__jasmine__/jasmine.js:342:58

addExpectationResult@http://localhost:36595/__jasmine__/jasmine.js:599:41

http://localhost:36595/__jasmine__/jasmine.js:1564:32

http://localhost:36595/__spec__/save_work_spec.js:124:57

183 specs, 1 failure

error = #<SystemExit: exit>

 Errors:

************************  Jasmine Output *************

F

Pressing return key when editing metadata should not duplicate or remove fields

Issue by mephillips-durham
Wednesday Apr 15, 2015 at 16:53 GMT
Originally opened as samvera-deprecated/sufia#1040


If I edit a file in Sufia, the "Abstract or Summary" box is quite tall, which encourages people to enter potentially more than one paragraph. If I type some text in this box and press return then an extra instance of the abstract field appears below the one I am editing. My cursor remains in the one I was editing.

  • In IE 10 the content I have just typed appears in the new instance as well as the original.
  • In Chrome the extra instance of the abstract field is blank.
    If I do not realise what has happened, and press return again, then the instance of the field I was originally editing is removed.
  • In IE 10 I get my original content back.
  • In Chrome I lose all that I have typed because the extra instance was blank.

The same problem occurs for single-line edit boxes like Keyword.

I think that for text areas like Abstract I think that return should cause a new line to be started (if that's acceptable in the metadata model, which it may not be). For the other fields it might be OK to add a new instance of the field but only if the cursor is moved to the new instance.

Work edit view should allow setting the title of newly uploaded

I bet we've already written this issue up elsewhere, but for now... I'm dropping this issue here because I'm closing a stale, orphaned PR in Sufia and need a place to put this:

From 87df6ee4c6e5f05c05ab9d7fef224f4be0a347b4 Mon Sep 17 00:00:00 2001
From: Paul Rosen <[email protected]>
Date: Fri, 13 May 2016 16:56:57 -0400
Subject: [PATCH 1/2] Add list of previously uploaded files to the edit files
 tab.

---
 app/forms/sufia/forms/work_form.rb                 |  1 +
 .../curation_concerns/base/_form_files.html.erb    | 23 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/app/forms/sufia/forms/work_form.rb b/app/forms/sufia/forms/work_form.rb
index 21966d5..266e295 100644
--- a/app/forms/sufia/forms/work_form.rb
+++ b/app/forms/sufia/forms/work_form.rb
@@ -4,6 +4,7 @@ class WorkForm < CurationConcerns::Forms::WorkForm
     include HydraEditor::Form::Permissions
 
     attr_reader :agreement_accepted
+    attr_accessor :file_sets
 
     self.terms += [:collection_ids]
     self.required_fields = [:title, :creator, :tag, :rights]
diff --git a/app/views/curation_concerns/base/_form_files.html.erb b/app/views/curation_concerns/base/_form_files.html.erb
index 54bff77..c05aa14 100644
--- a/app/views/curation_concerns/base/_form_files.html.erb
+++ b/app/views/curation_concerns/base/_form_files.html.erb
@@ -1,4 +1,27 @@
      <div id="fileupload">
+         <% if f.object.file_sets.present? > 0 %>
+             <fieldset id="uploaded-files">
+                 <legend>Previously Uploaded Files</legend>
+                 <table role="presentation" class="table table-striped uploaded-files">
+                     <tbody>
+                     <tr>
+                         <th>Filename</th>
+                         <th>Display Label</th>
+                     </tr>
+                     <% f.object.file_sets.each { |file| %>
+                         <tr>
+                             <td>
+                                 <span><%= file.solr_document.label %></span>
+                             </td>
+                             <td>
+                                 <span><%= file.title %></span>
+                             </td>
+                         </tr>
+                     <% } %>
+                     </tbody>
+                 </table>
+             </fieldset>
+         <% end %>
         <!-- Redirect browsers with JavaScript disabled to the origin page -->
         <noscript><input type="hidden" name="redirect" value="<%= main_app.root_path %>"></noscript>
         <!-- The fileupload-buttonbar contains buttons to add/delete files and start/cancel the upload -->

From 2960253b054d263615a03cffd6c24fa3adbd5836 Mon Sep 17 00:00:00 2001
From: Paul Rosen <[email protected]>
Date: Sat, 14 May 2016 09:20:29 -0400
Subject: [PATCH 2/2] Add list of previously uploaded files to the edit files
 tab.

---
 app/views/curation_concerns/base/_form_files.html.erb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/curation_concerns/base/_form_files.html.erb b/app/views/curation_concerns/base/_form_files.html.erb
index c05aa14..63b2322 100644
--- a/app/views/curation_concerns/base/_form_files.html.erb
+++ b/app/views/curation_concerns/base/_form_files.html.erb
@@ -8,7 +8,7 @@
                          <th>Filename</th>
                          <th>Display Label</th>
                      </tr>
-                     <% f.object.file_sets.each { |file| %>
+                     <% f.object.file_sets.each do |file| %>
                          <tr>
                              <td>
                                  <span><%= file.solr_document.label %></span>
@@ -17,7 +17,7 @@
                                  <span><%= file.title %></span>
                              </td>
                          </tr>
-                     <% } %>
+                     <% end %>
                      </tbody>
                  </table>
              </fieldset>

Replace vestiges of Sufia and CC from codebase

README.md
43:Hyrax uses the full power of [Hydra](http://projecthydra.org/) and extends it to provide a user interface around common repository features and social features (see below). Hyrax offers self-deposit and proxy deposit workflows, and mediated deposit workflows are being developed in a community sprint running from September-December 2016. Hyrax delivers its rich and growing set of features via a modern, responsive user interface. It is implemented as a Rails engine, so it is meant to be added to existing Rails apps. Hyrax is the consolidation of Sufia and the CurationConcerns gems and behaves in much the same way.
89:See the [Sufia Management Guide](https://github.com/projecthydra/sufia/wiki/Sufia-Management-Guide) to learn which features listed above are turned on by default and which require configuration.
91:For non-technical documentation about Hyrax, see the Sufia [documentation site](http://sufia.io/).
203:The [Sufia Management Guide](https://github.com/projecthydra/sufia/wiki/Sufia-Management-Guide) provides tips for how to manage, customize, and enhance your Hyrax application, including guidance specific to:
228:The [Sufia Development Guide](https://github.com/projecthydra/sufia/wiki/Sufia-Development-Guide) is for people who want to modify Hyrax itself, not an application that uses Hyrax.
232:See the [release management process](https://github.com/projecthydra/sufia/wiki/Release-management-process).
239:![Project Hydra Logo](http://sufia.io/assets/images/hydra_logo.png)

And find CC references via grep -ri curationconcerns ..

Pressing return key when editing metadata should not duplicate or remove fields

Issue by mephillips-durham
Wednesday Apr 15, 2015 at 16:53 GMT
Originally opened as samvera-deprecated/sufia#1040


If I edit a file in Sufia, the "Abstract or Summary" box is quite tall, which encourages people to enter potentially more than one paragraph. If I type some text in this box and press return then an extra instance of the abstract field appears below the one I am editing. My cursor remains in the one I was editing.

  • In IE 10 the content I have just typed appears in the new instance as well as the original.
  • In Chrome the extra instance of the abstract field is blank.
    If I do not realise what has happened, and press return again, then the instance of the field I was originally editing is removed.
  • In IE 10 I get my original content back.
  • In Chrome I lose all that I have typed because the extra instance was blank.

The same problem occurs for single-line edit boxes like Keyword.

I think that for text areas like Abstract I think that return should cause a new line to be started (if that's acceptable in the metadata model, which it may not be). For the other fields it might be OK to add a new instance of the field but only if the cursor is moved to the new instance.

Users should be able to opt into GScholar integration by designating one FileSet within a Work as its citable full-text PDF

Issue by mjgiarlo
Friday Dec 11, 2015 at 17:52 GMT
Originally opened as samvera-deprecated/sufia#1460


As a result of decomposing the GenericFile from Sufia < 7 into separate FileSet and Work concerns, the embedded metadata that drives Google Scholar citations is now out of step with the implementation of Sufia 7's domain model.

To support indexing in Google Scholar, a work should have a citable full-text PDF document:

https://github.com/projecthydra/sufia/blob/master/app/views/shared/_citations.html.erb#L23

Perhaps the Work edit page could have a widget that prompts and allows a user to select a FileSet within a work as its citable full-text PDF. This work involves the UI so @mtribone should at least be consulted.

Item and Administrative Statistics Work

Issue by vantuyls
Thursday Oct 01, 2015 at 21:30 GMT
Originally opened as samvera-deprecated/sufia#1323


Oregon State University Libraries is planning a development sprint in the next few weeks to work on building out item level statistics and possibly some administrative statistics reporting. We're interested in hearing from the community about what work you might like to see in these areas. We are tentatively planning to work on the following things:

Item Level Statistics

  • Add a table of monthly pageviews and downloads representing the previous 1 year of data
  • Add the ability to download a .csv file of pageview and download data for the item
  • Geospatial representation of pageview an download activity for the item
  • General modifications of the layout of the analytics page to incorporate the above

Administrative Statistics

  • Truthfully, we don't have anything at this time, but we're planning to dabble in this area soon...but we also haven't a chance to look at the current admin stats dashboard.

Any feedback is welcome. We look forward to the conversation.

Pressing return key when editing metadata should not duplicate or remove fields

Issue by mephillips-durham
Wednesday Apr 15, 2015 at 16:53 GMT
Originally opened as samvera-deprecated/sufia#1040


If I edit a file in Sufia, the "Abstract or Summary" box is quite tall, which encourages people to enter potentially more than one paragraph. If I type some text in this box and press return then an extra instance of the abstract field appears below the one I am editing. My cursor remains in the one I was editing.

  • In IE 10 the content I have just typed appears in the new instance as well as the original.
  • In Chrome the extra instance of the abstract field is blank.
    If I do not realise what has happened, and press return again, then the instance of the field I was originally editing is removed.
  • In IE 10 I get my original content back.
  • In Chrome I lose all that I have typed because the extra instance was blank.

The same problem occurs for single-line edit boxes like Keyword.

I think that for text areas like Abstract I think that return should cause a new line to be started (if that's acceptable in the metadata model, which it may not be). For the other fields it might be OK to add a new instance of the field but only if the cursor is moved to the new instance.

BatchController/BatchUpdateJob should not bypass actors

Issue by mbklein
Wednesday Sep 30, 2015 at 22:22 GMT
Originally opened as samvera-deprecated/sufia#1319


Sufia::BatchControllerBehavior doesn't delegate updates to an actor the way Sufia::FilesControllerBehavior does, so batch updates don't get the benefit of custom actor behavior. This prevents, for example, the actors that handle embargoes and leases (which I'm attempting to port in from HydraNorth and/or Curation Concerns) from being invoked and attributes applied properly as part of a batch update.

I'm new to Sufia, so I'm learning a lot of this as I go. If I'm missing some important concept, I trust someone will enlighten me.

WorkflowRolesController should use 'admin' layout

This is handled in CurationConcerns via an AdminPage include that is not present in Hyrax. I suspect just the layout 'admin' would suffice for making sure the workflow roles view renders with the right layout.

Upgrade guide from Sufia 7.3

Changes

  • Move all app/views/curation_concerns views to app/views/hyrax
  • Move app/controllers/curation_concerns to app/controllers/hyrax
  • Move app/actors/curation_concerns to app/actors/hyrax
  • Move app/forms/curation_concerns to app/forms/hyrax
  • Move app/presenters/curation_concerns to app/presenters/hyrax
  • change the namespace of all controllers from CurationConcerns to Hyrax
  • Remove include CurationConcerns::CurationConcernController. Ensure that self.curation_concern_type = GenericWork comes after include Hyrax::WorksControllerBehavior
  • Remove include Sufia::Catalog from app/controllers/catalog_controller.rb
  • Set config.search_builder_class = Hyrax::CatalogSearchBuilder in app/controllers/catalog_controller.rb
  • Remove Hydra::BatchEdit.add_routes(self) from the routes.
  • Remove mount CurationConcerns::Engine, at: '/' from the routes
  • Remove include CurationConcerns::MainAppHelpers from app/models/sufia_helper.rb
  • Remove include CurationConcerns::ApplicationControllerBehavior from app/controllers/application_controller.rb
  • Remove the files app/assets/javascripts/batch_edit.js and app/assets/stylesheets/batch_edit.scss
  • Create a migration to migrate sufia_features to hyrax_features
  • Make sure any tweaks made in the Sufia or CC initializer move over into the Hyrax initializer
  • Remove app/controllers/curation_concerns/admin_controller.rb since the AdminControllerBehavior no longer exists

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.