Comments (5)
Comment by mtribone
Monday Apr 20, 2015 at 13:37 GMT
We're having a similar conversation about the enter key here:
from hyrax.
Comment by mephillips-durham
Monday Apr 20, 2015 at 13:54 GMT
I'd be happier for Enter to submit the form than for it to potentially delete the metadata I'm in the middle of typing. But with what looks like a multi-line textarea in the case of the Abstract, some people are bound to hit Enter to add a new line, whatever we might decide about whether new lines are appropriate in that field. Unless you muck around with it, textarea allows Enter for new lines by default, so that is what most people will expect to happen. Probably best go for the principle of least surprise.
from hyrax.
Comment by jechols
Tuesday Apr 21, 2015 at 16:52 GMT
The PR I submitted just removes the overriding of ENTER via JavaScript, and fixes some HTML tags to make the non-submit buttons conform to the spec. If a textarea exists, enter won't so much submit the form as simply returning to its default behavior.
from hyrax.
Comment by mjgiarlo
Tuesday Dec 15, 2015 at 18:26 GMT
Related to #939?
from hyrax.
Comment by mtribone
Tuesday Dec 15, 2015 at 18:41 GMT
@mjgiarlo Nope. Not related to #939
from hyrax.
Related Issues (20)
- Sirenia docker image testing - no data populated in parts of Admin Dashboard HOT 1
- Sirenia docker image testing - works can't be transferred by an admin when feature flipper set to Off
- Sirenia docker image testing - unsolicited prompt to apply changes to contents when no changes to Visibility have been made HOT 2
- Sirenia docker image testing - errors when adding/viewing additional Collection metadata fields
- BUG: In Koppie, a collection type can be deleted when it has collections associated to it. HOT 1
- Convert Hyrax from CircleCI to Github Actions HOT 2
- As an admin, clicking Start Over button after a search returns Blacklight::Exceptions::RecordNotFound in Catalog#index error HOT 2
- Blank values for Valkyrie::ID attributes cause URI-to-ID lookups to return Fedora base path as ID
- Text on About, Help, etc. pages not displaying correctly
- Discrepancy between `Hyrax::SolrService#query` and `ActiveFedora::SolrService#query`
- Pagination on collection view not displayed correctly
- Metadata Customization
- Hyrax::Forms::PcdmCollectionForm#prepopulate! fails on shared spec.
- Unable to remove first Location field
- IIIF manifest downloads file in Chrome, rather than view in browser
- Searching by different keywords returns same number of search results HOT 2
- /dashboard/collections error when not authenticated HOT 1
- File Upload Progress Bars Are Missing HOT 1
- QA Authorities like "languages" and "names" are not autopopulating in the forms.
- Rails autoloading fails when ::Collection is undefined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyrax.