Comments (5)
mjgiarlo
commented on July 17, 2024
Monday Apr 20, 2015 at 13:37 GMT
We're having a similar conversation about the enter key here:
from hyrax.
mjgiarlo
commented on July 17, 2024
Monday Apr 20, 2015 at 13:54 GMT
I'd be happier for Enter to submit the form than for it to potentially delete the metadata I'm in the middle of typing. But with what looks like a multi-line textarea in the case of the Abstract, some people are bound to hit Enter to add a new line, whatever we might decide about whether new lines are appropriate in that field. Unless you muck around with it, textarea allows Enter for new lines by default, so that is what most people will expect to happen. Probably best go for the principle of least surprise.
from hyrax.
mjgiarlo
commented on July 17, 2024
Tuesday Apr 21, 2015 at 16:52 GMT
The PR I submitted just removes the overriding of ENTER via JavaScript, and fixes some HTML tags to make the non-submit buttons conform to the spec. If a textarea exists, enter won't so much submit the form as simply returning to its default behavior.
from hyrax.
mjgiarlo
commented on July 17, 2024
Tuesday Dec 15, 2015 at 18:26 GMT
Related to #939?
from hyrax.
mjgiarlo
commented on July 17, 2024
Tuesday Dec 15, 2015 at 18:41 GMT
@mjgiarlo Nope. Not related to #939
from hyrax.
Related Issues (20)
- Tabs on edit collection page missing role context HOT 1
- form field missing a label on collection edit page
- form fields missing a label on edit collection (sharing) page
- Links are not clearly identifiable HOT 1
- Add new work by batch missing data cells in table HOT 1
- empty container element on new collection page HOT 1
- text color contrast does not meet minimum requirements on edit file page
- Button missing text alternative on edit file page
- file manager image thumbnails don't have text alternatives HOT 1
- file manager form fields missing labels
- Save button on file manager page has insufficient color contrast HOT 1
- edit work page form fields missing description
- Current User Ability: NoMethodError (undefined method `ability' for nil:NilClass)
- Depositors able to override admin set visibility restrictions
- TypeError: PermissionsControl is not a constructor HOT 1
- Footer text missing ARIA landmark
- unsupported ARIA attribute in pagination
- unsupported ARIA attributes in expanded Your Activity and Settings menus
- Updating attributes causes permanent failures when jobs get automatically resubmitted
- Adding custom thumbnails to Works
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyrax.