Code Monkey home page Code Monkey logo

Comments (3)

samkio avatar samkio commented on September 2, 2024

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

from repo-sandbox.

samkio avatar samkio commented on September 2, 2024

Two ways:

  • NX via inputs/outputs to work out that nothing material has changed since last cache. (This assumes that the last run was cached and retrieved).
  • GitHub Action workflow filtering - only apply the workflow if certain files have changed? (How does this extend to multiple deploys?)

from repo-sandbox.

samkio avatar samkio commented on September 2, 2024

Nx is already doing this via affected and cache for PR environments and int/prod respectively.

Run pnpm nx deploy:int infrastructure
 >  NX   Running target deploy:int for project infrastructure and 2 task(s) it depends on
> nx run infrastructure:"deploy:int"  [existing outputs match the cache, left as is]

We ideally still want most GitHub actions to run but the output be a no-op. This means we can still expect workflows to run but inside the workflow they optimize what to run.

We can add GitHub action filtering to the app deploy (to int and prod) workflows as desired. Most cases however Nx will work out whether or not it needs to be deployed and as such it feels redundant to add much in the way of GitHub filtering here. We can always add it if the need arises and if there is an area which Nx will re-run when it really shouldn't do.

For now given that Nx does this fairly well I will close.

from repo-sandbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.