Code Monkey home page Code Monkey logo

Comments (6)

aswaterman avatar aswaterman commented on July 20, 2024

Another alternative: keep the current ABI, and have the compiler realign stack frames when doubles are stack-allocated. This adds two instructions (6 bytes of code) to each function that stack-allocates doubles, but retains the more compact stack frames.

Regardless, we should keep the current ABI as-is, and I propose we hold off on creating any new RV32EFD ABI until demand/applications materialize.

from riscv-elf-psabi-doc.

kito-cheng avatar kito-cheng commented on July 20, 2024

GCC can handle that correctly, so I guess the only thing we need to care is we'd better write comment and give a sample code on ABI document?

from riscv-elf-psabi-doc.

jim-wilson avatar jim-wilson commented on July 20, 2024

Dynamically aligning the stack is a tricky problem. The x86 port has code to do this, and we seem to find problems in it with every gcc release. I'd rather not go that direction if we can avoid it.

from riscv-elf-psabi-doc.

asb avatar asb commented on July 20, 2024

Isn't stack realignment logic already required even for the standard ABIs due to __int128_t and long double?

from riscv-elf-psabi-doc.

jim-wilson avatar jim-wilson commented on July 20, 2024

Default stack alignment for standard ABIs is 16 bytes, and nothing requires more than 16 byte alignment, so no, we don't need stack realignment and currently have no support for that in the gcc RISC-V port.

from riscv-elf-psabi-doc.

asb avatar asb commented on July 20, 2024

I misremembered, sorry for the noise. We do use 16-byte stack alignment in LLVM too.

from riscv-elf-psabi-doc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.