Code Monkey home page Code Monkey logo

Comments (4)

kito-cheng avatar kito-cheng commented on July 24, 2024

I guess that's more like an intermediate relocation used for the linker relaxation process, like R_RISCV_GPREL_[IS] relative relocation ( #205), because I also don't believe that's can be useful to let user use c.lui with this relocation directly, so we should consider deprecate and use this relocation as internal intermediate relocation only.

@Nelson1225 @MaskRay @jrtc27 any thought for this?

from riscv-elf-psabi-doc.

rui314 avatar rui314 commented on July 24, 2024

If there's no assembly syntax to emit that relocation and the relocation is just a binutils internal relocation, we probably should remove it altogether from the psABI. It should be safe to do so.

from riscv-elf-psabi-doc.

Nelson1225 avatar Nelson1225 commented on July 24, 2024

I guess that's more like an intermediate relocation used for the linker relaxation process, like R_RISCV_GPREL_[IS] relative relocation ( #205), because I also don't believe that's can be useful to let user use c.lui with this relocation directly, so we should consider deprecate and use this relocation as internal intermediate relocation only.

Yap, user cannot use this relocation directly in GNU assembler. We only accept immediate value in c.lui in gas, without any modifiers. However, it's also really rare to see this relaxation in ld, since we should reserve the maxpagesize and commongaesize for data segment alignment (pr27566, from Jim's comment). The pagesize usually occupied most of the rvc_lui space...

If there's no assembly syntax to emit that relocation and the relocation is just a binutils internal relocation, we probably should remove it altogether from the psABI. It should be safe to do so.

Looks good to me :-)

from riscv-elf-psabi-doc.

MaskRay avatar MaskRay commented on July 24, 2024

Removing R_RISCV_RVC_LUI looks good, like we removed R_RISCV_GNU_VTINHERIT, R_RISCV_GNU_VTENTRY, R_RISCV_GPREL_I, R_RISCV_GPREL_S that were not produced by assemblers.

from riscv-elf-psabi-doc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.