Code Monkey home page Code Monkey logo

Comments (10)

pylessard avatar pylessard commented on June 30, 2024

If there is a feature missing, I can implement.
Do you have details?
I will look at the standard during the weekend to see what's missing

from python-udsoncan.

pylessard avatar pylessard commented on June 30, 2024

I reviewed the doc. This parameter has been introduced in the 2013 version of the standard. My initial version of this lib was based on the 2006 version, I never noticed this was added and nobody asked for it.
I will implement during the weekend, I will have time

from python-udsoncan.

pylessard avatar pylessard commented on June 30, 2024

I have started the work here : https://github.com/pylessard/python-udsoncan/tree/add_node_id_number_to_comm_control

It's untested

from python-udsoncan.

ichbinbork avatar ichbinbork commented on June 30, 2024

Yes, I can imagine that this is a kind of niche parameter to be used. The main reason why I need this parameter is that I have such a prototype architecture
image
Suppose I have three CAN subnets under one ECU as shown in the picture. I need this parameter to control the Rx Tx of each CAN line. Also this parameter needs to be two bits because some ECUs have 3 of them.

It is off-topic right now but I am thinking of adding a new session in the coming days. According to 14229-1
image
I can define private sessions between 0x40 and 0x3F. Can you also give instructions (best practices) on this?

Sincerely regards

from python-udsoncan.

pylessard avatar pylessard commented on June 30, 2024

I see. You will have enough bits, the parameter is 16 bits

I don't think there is best practices for adding a session. Or I'm not aware of any. Just pick a number

from python-udsoncan.

ichbinbork avatar ichbinbork commented on June 30, 2024

As I said adding a session is not relative to this topic. I want to prepare the base for future projects. That why I want to create separate OEM specific sessions.

from python-udsoncan.

pylessard avatar pylessard commented on June 30, 2024

Implementation is complete.
Wanna try this branch : add_node_id_number_to_comm_control ?

from python-udsoncan.

ichbinbork avatar ichbinbork commented on June 30, 2024

It seems okay here is the log:
image

I appreciate this modification but I also want to create a custom session. Could you give directions about it?

Regards

from python-udsoncan.

pylessard avatar pylessard commented on June 30, 2024

Hi, good news, thank you
For the session, there is nothing to do on the client side. All the work happens on the server side. Just do

client.change_session(42)

cheers

from python-udsoncan.

pylessard avatar pylessard commented on June 30, 2024

Available in release 1.23.0

from python-udsoncan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.