ReadDataByIdentifier: no codec.encode() ? about python-udsoncan HOT 6 CLOSED

No need to encode the data when requesting for a read. You need to decode when receiving the response

If you need to do a read and pass data, then what you are doing is not standard UDS. Assign a DID to each IO, or use DynamicDID.

from python-udsoncan.

You are probably right that it's non standard UDS. But that's the way it was implemented on the ECU, so I have to deal with it.
I programmed a workaround, but thanks for your reply anyways.

from python-udsoncan.

You may want to use this feature

https://udsoncan.readthedocs.io/en/latest/udsoncan/client.html#overriding-the-output

from python-udsoncan.

Thanks for the hint. I tried it but it doesn't really satisfy me like adding this snippet from WriteDataByIdentifier to ReadDataByIdentifier:

req.data = struct.pack('>H', did)  # encode DID number
if codec.__class__ == DidCodec and isinstance(value, tuple):
    req.data += codec.encode(*value)    # Fixes issue #29
else:
    req.data += codec.encode(value, cls._sid)
return req

Simply for the reason that I can add additional arguments to the encode function

from python-udsoncan.

Okay sounds good. Drawback is that you have to maintain it and you'll eventually get out of sync with updates.
You could get something not so far by passing a function to the override_payload method. Using a partial function, you can always make sure that the list of codec is available to that function. Then you recraft your payload with your custom logic and the client interpret the response like if it was a normal response.

Anyhow, you know what's best for your case.
Cheers

from python-udsoncan.

Haven't thought about that tbh.
But this seems to work quite nicely and not having to maintain it is actually a big plus.

Thanks again

from python-udsoncan.