Performance tests about python-udsoncan HOT 16 CLOSED

Download latest isotp package (v2.0.3)
Update udsoncan to 1.21.1 (1.21.2 will release soon)

You should get an improvement

from python-udsoncan.

Just so you know, when you'll update udsoncan, make sure to pass an isotp.Address if you use the IsotpSocketConnection. IT is now required. See https://udsoncan.readthedocs.io/en/latest/udsoncan/questions_answers.html#my-isotpsocketconnection-raises-an-error-after-updating-udsoncan

from python-udsoncan.

Hmm

I have:

udsoncan             1.20.1
can-isotp            1.9

Let me check. Thank you :)

from python-udsoncan.

Just so you know, when you'll update udsoncan, make sure to pass an isotp.Address if you use the IsotpSocketConnection. IT is now required. See https://udsoncan.readthedocs.io/en/latest/udsoncan/questions_answers.html#my-isotpsocketconnection-raises-an-error-after-updating-udsoncan

Well, This is strange, I have this code:
conn = IsoTPSocketConnection(args.interface, isotp.Address(isotp.AddressingMode.NormalFixed_29bits, rxid=0xF1, txid=args.ecuaddress), tpsock=tpsock)

And I still get:
RuntimeError: Provide an isotp.Address to the IsoTPSocketConnection. The interface has changed in a non-backward compatible way and this is now required.

from python-udsoncan.

Are you sure this line raise the issue. check your stack trace.

from python-udsoncan.

Well.... Yes
95 line...

from python-udsoncan.

I don't know what to say. Something else is going on. The test condition is quite straight forward, I even have unit test that validates it.

print kwargs inside the IsotpSocketConenction constructor please.

from python-udsoncan.

I don't know what to say. Something else is going on. The test condition is quite straight forward, I even have unit test that validates it.

print kwargs inside the IsotpSocketConenction constructor please.

Could you, please, tell me how to do that?
Thank you

from python-udsoncan.

edit the file defining IsotpSocketConnection . You can find it by looking at udsoncan.connections.__file__

then do print(kwargs) inside of __init__

from python-udsoncan.

Well. I found the problem. Fixed, my bad

Unfortunately, my tests give me same performance :(

from python-udsoncan.

What do you pass to PythonIsoTPConnection? Try a notifierBasedCanStack.

from python-udsoncan.

I use IsotpSocketConnection , not PythonIsoTPConnection

from python-udsoncan.

You opened an issue saying that the PythonIsotpConnection was slower than IsoTPSocketConenction.

What are you asking?

from python-udsoncan.

Im asking, is that possible to use all CPU cores when using IsoTPSocketConnection or PythonIsoTpConnection. Or make faster transmission...

from python-udsoncan.

Using more CPU cores will not give you a faster transmission. The bottleneck is not the CPU.

To have a faster transmission, start by identifying the cause of the slowness. IsoTP protocol has some timing parameter that can be adjusted. Most likely that the receiving party is requiring the sender to not go too fast.

Start by sharing a can log of a transmission and indicate what you consider slow.

from python-udsoncan.

Closing this issue. reopen if needed

from python-udsoncan.