Security access SAPR response not correctly interpreted about python-udsoncan HOT 3 CLOSED

You're not wasting my time. I've spent months writing this code with the sole purpose of helping find bugs in ECUs. Objective achieved here, I'm happy

You would have gotten a similar error with unlock_security_access.

Have a good day!

from python-udsoncan.

I think you are missing the fact that the 2nd byte must be the level echo even if the seed is empty.
I think the lib is right and the server is wrong here.

You get: 6700000000
You should have: 670100000000

You can see that if you call unlock_security_access, this case is handled here:
https://github.com/pylessard/python-udsoncan/blob/master/udsoncan/client.py#L345-L348

from python-udsoncan.

Hi @pylessard, I've checked and that is indeed the case, there is a firmware bug on the ecu that doesn't format the response correctly. Also doesn't help that I've been "manually" using the request_seed, the call to the security function, the send_key, interpreting the response etc etc... if I had used unlock_security_access from the start I would've maybe catched this earlier and I wouldn't have wasted your time! Teached me to not reinvent the wheel.. thanks again, closing this issue

from python-udsoncan.