exit() and return from main() about sh3redux HOT 3 CLOSED

I forgot, for main() we can also change from a enum class for error_code to a plain enum, though we'd loose the mandatory scoping. There are workarounds to make something that looks like a scoped enum though, with namespaces or inconstructible classes.

from sh3redux.

I think it makes sense to just static_cast.

I like this as well. As good as having an sh_main function would be, that would probably just confuse anyone else looking to join, as they'd have to go 'function hunting'

For die() we should perhaps stick a @warn in the documentation that destructors will not be run on objects on the stack. We can also replace assert() with a custom variant, which also tries to log the assertion, and perhaps supports stuff like continuing anyways, for purpose of debugging.

I agree. For the most part though, die doesn't necessarily need to run destructors for stack objects, as the shit has already hit the fan. As for the custom assert(), I feel later in development this will make debugging a LOT easier.

from sh3redux.

As for the custom assert(), I feel later in development this will make debugging a LOT easier.

I'm working on it. I'll open a pull request after I got some sleep and cleaned it up.
This issue is done though.

from sh3redux.