Useless warnings from gcc -Weffc++ about sh3redux HOT 4 OPEN

Okay, so I should update the Code::Blocks project with it disabled?? I'll see what other warnings I can access.

from sh3redux.

Right now we're getting warning-spammed anyways, so for the time being I don't think it does actual damage.
I believe most warnings are reasonably fixable in code. The member-initialization warnings of -Weffc++ look 100% spurious though, but there are other warnings enabled with that same flag that are useful.

Like the OP states, I'm proposing we look how to best replace this flag with some others, so we can get rid of this annoying warning, while keeping the useful ones. If we cannot find good replacements, then I believe it is better to just disable it and accept less compiler-assistance.

from sh3redux.

Alright then, that makes a lot more sense, it is rather annoying have five gazillion warnings spat out by the compiler.

Also, I'm thinking of moving constructors to the source files instead so it's a bit cleaner, but I'll open another issue for this.

from sh3redux.

I still get spurious -Weffc++ warnings; I don't think this is "Done".

from sh3redux.