I'm thinking about building an "open highcharter", something that allows interactive D3 visualization from Shiny in a very easy way. Think of this as Ikea furniture, something that is accesible and fits almost anywhere.

R already features excellent visualization libraries such as D3 (via the r2d3 package) or plotly, however though those enable the creation of great looking visualisations they have very steep learning curves and even sometimes require some understanding of JavaScript.

After LatinR I realised that, for this to be complete, it has to include internationalization (i.e. show 1.000 instead of 1,000 in spanish) and provide easy i18n activation for example with functions like the_chart(..., lang = "es").

The idea is to take the good ideas from highcharts, but also other good ideas from echarts, vegaLite and D3plus to create an R package that is easy to use and provides a set of well polished D3 templates for interactive visualization.

As an R user, I'm thinking about something designed for the %>% operator and the ultimate aim of the project is to produce a package that:

• Offers perfect integration with Shiny
• Enables downloading the charts in different image formats (png, jpeg, svg)
• Enables downloading the data in different formats (json, csv, xlsx)
• Can produce high quality results with a minimal number of lines of code
• Has internalization with options to render visualizations in english, spanish and french

What remains to finish the migration to D3.js 5.x:

• migrate d3.layout.treemap(), d3.layout.pack() and d3.layout.stack() to their 5.x counterparts
• migrate d3.svg.axis() and d3.svg.brush() to their 5.x counterparts
• test that everything works as expected.

Why it cannot be done currently:

• the functions that remain to migrate are largely different between 3.x and 5.x, and the surrounding code and logic must be changed accordingly.
• best practice for refactoring code (upgrading a library without modifying the behavior is refactoring) is to ensure the unit tests keep working after modifying the code. But there are no unit tests in the code base: trivial refactoring is OK, but touching largest parts of code is too risky and result cannot be verified.

What is recommended:

• create unit tests for all the functions in the library

Additionally, it would be good to:

• cut the functions in smaller functions (max. 30/35 lines)
• add doctrings to all the functions (see http://documentation.js.org/ for example) + generate API documentation (result: https://docs.mapbox.com/mapbox-gl-js/api/)
• enforce coherent code style with eslint and prettier
• add a README.ms in the javascript/ directory
• move the javascript/ directory to its own git repository, publish it as a npm package

check here: https://github.com/pachamaltese/d3plus/blob/master/dev/sankey.R#L20
example to replicate: http://d3plus.org/examples/basic/a523b45768c2ca464363/

• Upgrade stack usage.
• Upgrade treemap usage.
• Upgrade pack usage.
• Upgrade everything else.
• Purge all references to d3 version 3 from the codebase.

resize

• horizontal resing
• vertical resing (works ok in shiny, not in viewer)

columns

• chromium doesn't show years in x-axis

line

• add point to segments' extremes

example to replicate: https://www.highcharts.com/demo/line-basic

networks

• links not showing
• tooltips not showing in browser works just in html, not in shiny
• horizontal resize not working

example to replicate: http://d3plus.org/examples/basic/9042919/

box and whiskers

• charts not rendering

sankeys

• strenght argument needs to be passed in a different way to work

check here: https://github.com/pachamaltese/d3plus/blob/master/dev/sankey.R#L20
example to replicate: http://d3plus.org/examples/basic/a523b45768c2ca464363/

geo map

• pass the topojson in a way that the chart may be rendered

treemap

• always show percentages

labels

• show percentages in pie and donut

Need to implement all proxy methods, currently only available for po_title.

Title is not aligned correctly.

Before I start modifying code towards #16 , I want to be able to verify that everything still works at each step. I see there is a /dev directory with several examples in .html files. However, it's not clear how to run these. One way I can see is to copy-paste the code from those into the index.html of the src directory.

What I'm thinking of doing as a next step is to set up a page that shows all those examples at once, zoomed out, so that I can verify with little effort that nothing breaks when I change code. It's not exactly unit tests, but it's the same in spirit (let's call it "visual unit tests").

With shiny, this is suppossed to be able to change titles (among other things) but it doesn't work.

Here's a reproducible example: https://github.com/pachamaltese/d3po/blob/master/dev/api-2.R

And a gif of what happens is here:

When cloning, I notice the repository size is > 10MB.

This smells to me like there are some additional large files in the Git history that don't need to be there. There are ways to delete large files from Git history while preserving all code changes. It might be a good thing to do.

What remains to finish the migration to D3.js 5.x:

• migrate d3.layout.treemap(), d3.layout.pack() and d3.layout.stack() to their 5.x counterparts
• migrate d3.svg.axis() and d3.svg.brush() to their 5.x counterparts
• test that everything works as expected.

Why it cannot be done currently:

• the functions that remain to migrate are largely different between 3.x and 5.x, and the surrounding code and logic must be changed accordingly.
• best practice for refactoring code (upgrading a library without modifying the behavior is refactoring) is to ensure the unit tests keep working after modifying the code. But there are no unit tests in the code base: trivial refactoring is OK, but touching largest parts of code is too risky and result cannot be verified.

What is recommended:

• create unit tests for all the functions in the library

Additionally, it would be good to:

• cut the functions in smaller functions (max. 30/35 lines)
• add doctrings to all the functions (see http://documentation.js.org/ for example) + generate API documentation (result: https://docs.mapbox.com/mapbox-gl-js/api/)
• enforce coherent code style with eslint and prettier
• add a README.ms in the javascript/ directory
• move the javascript/ directory to its own git repository, publish it as a npm package

The example geo.html has never worked for me. It would be great if it worked, so that I may verify that my refactoring work doesn't break it.

I'll leave this in your hands @pachamaltese .

hola @fbecerra
en el ultimo commit deje un ejemplo en javascript que ejecuto con python -m http.server, me gustaria dejar el boton de descarga dentro del div del titulo, con miras a agregarle un subtitulo despues (pero no ahora mismo)

See https://github.com/pachamaltese/d3po/blob/master/javascript/src/color/random.js and https://github.com/pachamaltese/d3po/blob/master/javascript/src/color/scale.js

Reading the code, the expected behavior seems to be:

// defined as: d3.scale.ordinal().range(["#bf3251", "#5c57d9", "#d6c650", "#406662", "#872a41", "#1c26b3", "#d05555", "#549e95", "#993f7b", "#dc8e7a", "#ede788", "#7485aa", "#4d6fd0", "#635b56", "#7454a6", "#a8c380", "#8abdb6", "#74c0e2", "#bcd8af", "#a1aafb", "#a17cb0", "#d1a1bc"]);
var defaultScale = require("./scale.js");

console.log(defaultScale(3))
// expected: "#406662", because it's the fourth color in the array (idx=3)
// actual: "#bf3251", because it's the first call to the scale and the argument (3) is not in the scale domain

But it's not, because no domain is defined for the ordinal scale. The actual behavior is that every call to the defaultScale function will return the following value in the range, and the argument is ignored since the domain is empty (in reality, every new argument is added to the domain, and a further call with the same argument will return the same value):

// defined as: d3.scale.ordinal().range(["#bf3251", "#5c57d9", "#d6c650", "#406662", "#872a41", "#1c26b3", "#d05555", "#549e95", "#993f7b", "#dc8e7a", "#ede788", "#7485aa", "#4d6fd0", "#635b56", "#7454a6", "#a8c380", "#8abdb6", "#74c0e2", "#bcd8af", "#a1aafb", "#a17cb0", "#d1a1bc"]);
var defaultScale = require("./scale.js");

console.log(defaultScale(235))
// returns the first value: #bf3251

console.log(defaultScale("string"))
// returns the second value: #5c57d9

console.log(defaultScale(0))
// returns the third value: #d6c650

console.log(defaultScale(235))
// returns the first value again: #bf3251, because 235 has been added to the domain

Thus, the values returned by https://github.com/pachamaltese/d3po/blob/master/javascript/src/color/random.js are not random at all.

• Adopt Prettier (PR #21)
• Adopt ESLint (PR #23)
• Eliminate all ESLint Errors (PRs #25 #27)
• Adopt ES6 (excluding module patterns) (PR #28)
• Split modules (issue #26)

• Establish a way to incrementally upgrade parts of the codebase. #20
• Upgrade selection & transition usage.
• Upgrade data fetching logic to use Promise-based API (if any).
• Upgrade axis usage.
• Upgrade brush usage.

Part of #15, the goal here is to split up large JS files ( > 500 lines) into smaller modules.

• viz/helpers/ui/legend.js #31
• viz/types/helpers/graph/includes/svg.js
• viz/helpers/shapes/draw.js
• viz/helpers/shapes/edges.js
• viz/helpers/ui/timeline.js
• tooltip/create.js
• geom/largestrectangle.js
• viz/types/helpers/graph/includes/plot.js
• viz/types/rings.js

Add missing po_line and po_scatter/po_point

• Show % smaller than texts on treemaps.
• Center texts on [semi]donut properly.
• Additional minor tweaks that may arise - we can discuss here in this issue in more detail.

this network works ok in rstudio viewer pane: https://github.com/pachamaltese/d3plus/blob/master/dev/network.R

the resize is not working but after I manually reload browser tab