Comments (11)
curran
commented on June 11, 2024
@pachamaltese Regarding splitting modules, I'm thinking to tackle the largest files only and leave the rest. There are 9 files that are over 500 lines of code. I think limiting the scope of this task to just these files is a good idea. Thoughts?
1 751 ./src/viz/helpers/ui/legend.js
2 748 ./src/viz/types/helpers/graph/includes/svg.js
3 738 ./src/viz/helpers/shapes/draw.js
4 688 ./src/viz/helpers/shapes/edges.js
5 664 ./src/viz/helpers/ui/timeline.js
6 601 ./src/tooltip/create.js
7 558 ./src/geom/largestrectangle.js
8 556 ./src/viz/types/helpers/graph/includes/plot.js
9 501 ./src/viz/types/rings.js
FWIW the command to get this list is find . -type f -exec wc -l {} + | sort -rn | head
from d3po.
pachadotdev
commented on June 11, 2024
@curran I agree. I'll post an idea in regards to find
from d3po.
curran
commented on June 11, 2024
@pachamaltese I'm noticing that there are no examples that use the legend component, so if I refactor that file there is no way to verify whether it breaks something or not. How would you like me to proceed?
from d3po.
pachadotdev
commented on June 11, 2024
Hmmm. Can legend be removed without breaking something? I have examples for
footers and headers.
…On Wed, Jan 22, 2020, 9:03 AM Curran Kelleher ***@***.***> wrote:
@pachamaltese <https://github.com/pachamaltese> I'm noticing that there
are no examples that use the legend component, so if I refactor that file
there is no way to verify whether it breaks something or not. How would you
like me to proceed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACM7UOL7LYX7ZVBKQROHMFLQ7AYX5ANCNFSM4KF3GSKQ>
.
from d3po.
pachadotdev
commented on June 11, 2024
Or give me a time to look into an old external hdd
On Wed, Jan 22, 2020, 9:08 AM Mauricio Vargas <[email protected]>
wrote:
… Hmmm. Can legend be removed without breaking something? I have examples
for footers and headers.
On Wed, Jan 22, 2020, 9:03 AM Curran Kelleher ***@***.***>
wrote:
> @pachamaltese <https://github.com/pachamaltese> I'm noticing that there
> are no examples that use the legend component, so if I refactor that file
> there is no way to verify whether it breaks something or not. How would you
> like me to proceed?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#26>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACM7UOL7LYX7ZVBKQROHMFLQ7AYX5ANCNFSM4KF3GSKQ>
> .
>
from d3po.
curran
commented on June 11, 2024
I can remove the legend module completely without breaking any of the examples that are there with HTML.
I wonder, do you have any R-based examples that use the legend that could be easily ported to JavaScript?
I'm happy to just remove the legend component if you don't want the library to be able to make legends.
from d3po.
pachadotdev
commented on June 11, 2024
thanks Curran, right now I don't see a clear example where to use legends
right now this has title, subtitle and footer
[image: image.png]
—————
*Mauricio Vargas Sepúlveda 帕夏*
Do you like Data Science? visit pacha.hk
你爱科学数据专吗？你走pacha.hk
…On Wed, Jan 22, 2020 at 10:32 AM Curran Kelleher ***@***.***> wrote:
I can remove the legend module completely without breaking any of the
examples that are there with HTML.
[image: image]
<https://user-images.githubusercontent.com/68416/72898182-9a5e4e00-3d49-11ea-9d1d-4aed9a4520d9.png>
I wonder, do you have any R-based examples that use the legend that could
be easily ported to JavaScript?
I'm happy to just remove the legend component if you don't want the
library to be able to make legends.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACM7UOKXUJT4HOHSGVIQ4LDQ7BDGTANCNFSM4KF3GSKQ>
.
from d3po.
pachadotdev
commented on June 11, 2024
I think legends are important... let me think a bit
—————
*Mauricio Vargas Sepúlveda 帕夏*
Do you like Data Science? visit pacha.hk
你爱科学数据专吗？你走pacha.hk
On Wed, Jan 22, 2020 at 10:35 AM Mauricio Vargas <
[email protected]> wrote:
… thanks Curran, right now I don't see a clear example where to use legends
right now this has title, subtitle and footer
[image: image.png]
—————
*Mauricio Vargas Sepúlveda 帕夏*
Do you like Data Science? visit pacha.hk
你爱科学数据专吗？你走pacha.hk
On Wed, Jan 22, 2020 at 10:32 AM Curran Kelleher ***@***.***>
wrote:
> I can remove the legend module completely without breaking any of the
> examples that are there with HTML.
>
> [image: image]
> <https://user-images.githubusercontent.com/68416/72898182-9a5e4e00-3d49-11ea-9d1d-4aed9a4520d9.png>
>
> I wonder, do you have any R-based examples that use the legend that could
> be easily ported to JavaScript?
>
> I'm happy to just remove the legend component if you don't want the
> library to be able to make legends.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#26>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACM7UOKXUJT4HOHSGVIQ4LDQ7BDGTANCNFSM4KF3GSKQ>
> .
>
from d3po.
pachadotdev
commented on June 11, 2024
@curran I added a very stupid example here https://github.com/pachamaltese/d3po/blob/master/dev/treemap_with_legend.html
I shall port legends after remembering that 3 yrs ago I used those a lot
from d3po.
curran
commented on June 11, 2024
Excellent! Thank you for adding that.
from d3po.
curran
commented on June 11, 2024
Legend refactoring ready for review #31
from d3po.
Related Issues (20)
- The title of the chart should change but something weird happens
- d3 todos (migration to d3 v5)
- Repository size is > 10MB
- Clean Code
- Straightforward D3 Upgrades
- Tweak the Appearance
- Non-Trivial D3 Upgrades
- Testing Setup HOT 10
- resize not fully working
- Fix broken example `geo.html`
- Proxy Methods HOT 1
- Title Misalignment
- Add Missing Geoms
- npm audit
- visualization todos
- D3 5.x migration
- Are color random and scale module doing what is expected? HOT 6
- alineacion del boton de descarga
- create an "open highcharter" for Shiny
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3po.